Making a shared_ptr out of a stack object corrupts the heap!!

[JUANDENT]

Hi,


The following code is incorrect:

Customer customer = { 0, "John Doe", "[e-mail]" };
auto cc = std::make_shared<Customer>(customer);
cc = nullptr;

it makes a pointer to the customer object (a stack allocated object) which is destroyed when cc = nullptr!!

Thus corrupting the heap!


Correct?

Regards,
Juan Dent

[Peter87]

Not correct.

The line

auto cc = std::make_shared<Customer>(customer);

is more or less equivalent to

auto cc = std::shared_ptr<Customer>(new Customer(customer));

(the only difference is that make_shared might be more efficient because it can do a single memory allocation and store the reference counters together with the object)

In other words, it creates a heap allocated copy of customer.