String array input problem

[kethgr]

Hi everyone,
I'm trying to write a program that inputs candidate names and vote tallies from the user and outputs the name, tally, and percentage for each. It compiles, but when it gets past the for loops, I get an error message saying the "Debug assertion failed! Expression: string subscript out of range."
I'm very new to programming, so I don't know what this means or how to fix it.
I also have to press enter twice after entering the first name before the second prompt appears. And it's ignoring all of my endl statements. Thanks for any help you can give me.
Here's my code:

#include<iostream>
#include<cstring>
#include<string>
#include<iomanip>

using namespace std;

int main()
{
	string candidate[5];
	int votes[5];
	int i;
	int j;
	double total = 0.0;
	
	cout << fixed << setprecision(2);

	for (i = 0; i < 5; i++)
	{
		cout << "Enter the name of a candidate: ";
		cin.ignore(1024, '\n');
		getline(cin, candidate[i]);

		cout << "Enter the number of votes received"
		     << "by this candidate: ";
		cin >> votes[i];

		cout << endl << endl;

		total = total + votes[i];
	}

	cout << endl << endl;
	cout << setw(20) << left << "Candidate" << setw(20) << left 
	     << "Votes Received" << setw(20) << left << "% of Total Votes"
	     << endl << endl;

	for (j = 0; j < 5; j++)
	{
		cout << setw(24) << left << candidate[j] << setw(20)
		<< left << votes[j] << (votes[j] / total) * 100.0 << endl;
	}

	cout << endl;

	system("pause");

	return 0;
}

Thanks again!

[Shinigami]

It works for me :S
Only had to make line 24 and 25 in to one line.

[JLBorges]

> I also have to press enter twice after entering the first name before the second prompt appears.

Move the ignore() to after the formatted input operation:

               // ...

		// cin.ignore(1024, '\n'); *** move this
		getline(cin, candidate[i]);

		cout << "Enter the number of votes received"
		     << "by this candidate: ";
		cin >> votes[i];
		cin.ignore(1024, '\n'); // *** here
                
                // ... 

> And it's ignoring all of my endl statements.

That is strange.

In any case, you should not be writing all those unnecessary endls.
http://cppkid.wordpress.com/2008/08/27/why-i-prefer-n-to-stdendl/


Also, in general avoid magic numbers in your code.
http://en.wikipedia.org/wiki/Magic_number_(programming)#Unnamed_numerical_constants

And declare variables in the smallest scope in which they are required.

Prefer something like this:

        enum { N = 5 } ;
	string candidate[N];
	int votes[N];

        // int i ; // ***

        // ...

	for( int i = 0; i < N; ++i ) // i is local to the 'for'
        {
              // ...
        }
        

[kethgr]

Thanks for your help! My program works as it should now and my code looks better too.

I left out one thing, though. I also need it to output the winner of the election. I know how to find the largest element in the votes array, but how do I output the name associated with that element?

Thanks again for your help.

[whitenite1]

You could create another variable, lets call int winner. ( Or you could just re-use variable j. Where you see winner, substitute a j ) As your stepping through the for loop, and find a high value, have winner, ( or j ) equal the variable in the loop. Like so...

int winner,high=votes[0];
	for (i=0;i<5;i++)
	{
		if( votes[i] > high)
		{
			high = votes[i];
			winner = i;
		}
	}
	cout << "The winner of this election was " << candidate[winner] << " with " << votes[winner] << " votes." << endl;

[kethgr]

I got it. Thank you for your help. :)