Erasing a string

[jjordan33]

I have a function set to erase certain characters from a string...

  
string Filter (string clean)
{
    clean.erase(remove(clean.begin(), clean.end(), ' '), clean.end());
    clean.erase(remove(clean.begin(), clean.end(), ispunct), clean.end());
    return clean;
}
    

But, only the erase ' ' works. Do I have the other one wrong?

[Ganado]

http://www.cplusplus.com/reference/algorithm/remove/

Yes, you have the other one wrong.

You want remove if
http://www.cplusplus.com/reference/algorithm/remove_if/

[Peter87]

There are two versions of ispunct, one in <cctype> and one in <locale>, so if both of them has been declared the compiler will be confused and don't know which one to pick. The best way to avoid this sort of problem is to wrap it in a lambda.

clean.erase(remove_if(clean.begin(), clean.end(), [](char c){ return ispunct(c); }), clean.end());