counting vowels

[david lev]

I wrote a program which counting vowels, but the problem is when I enter a sentence it's kinda mixed up the program, but one I put words it works fine, so what do I do wrong here?

  #include <iostream>


using std::cout;
using std::cin;
using std::endl;

const int  size = 150;

int main()
{	
	int i = 0;
	int count = 0;
	char x [size];

	cout << "Enter string"<< endl ;
	cin.getline (x, size);
	while (x[i] != '\0')
	{	
		 x[i] ;
		i++;
	}
	

	cout << "The number of vowels are : " << endl;
	for (i = 0; i < x[i]; i++)
	{	
	
			if ( (x[i] == 'a') || (x[i] == 'o') || (x[i] == 'u') ||(x[i] == 'i') ||(x[i] == 'y') ||(x[i] == 'e')  )
			{
				count = count++;
			}
		
	}
		
	cout << count << endl;
		
	return 0;

}

[AbstractionAnon]

Line 20: What do you think this statement does? Hint: it does nothing.

Line 26: Why are you using x[i] as the upper limit of your loop?

You're counting the number of characters using our while loop at line 18, but you overlay the count (i) at line 26.

[LA48b7Xj]

change

count = count++;

to

count++;

[keskiverto]

Here is a different strategy: http://www.cplusplus.com/reference/string/string/find_first_of/

[david lev]

Ok thankes.
What the difference between (count = count++;) to (count++;) ?

[LA48b7Xj]

count = count++; is undefined behaviour.

[sabbirshawon]

"y" isn't a vowel

#include <iostream>
using namespace std;



int main()
{	
	string  x;
	int count = 0;
	
	
	
	cout << "Enter string"<< endl ;
	getline (cin, x);
	

	
	cout << "The number of vowels are : " << endl;
	for (int i = 0; i < x.length(); i++)
	{	
	
			if ( (x[i] == 'a') || (x[i] == 'o') || (x[i] == 'u') ||(x[i] == 'i') ||(x[i] == 'e')  )
			{
				 count=count+1;
			
			}
			
	}cout << count << endl;
		

		
	return 0;

}

[koothkeeper]

Actually "y" is sometimes a vowel: http://english.stackexchange.com/questions/10458/when-is-y-a-vowel