function pass by parameter

[xenovia12]

int exp_adder( int exp )

{
    if ( win )
    {
        experience += 20;
        if( experience == 100 )  //experience and character_level is global
        {
            character_level++;
            if ( true )
            {
                experience = 0;
            }
        }
    }
    return experience,character_level;
}

would this function work?
i mean, i did not use exp which i declared in the parameter of this function.
i did call this function to main but it works, the exp became 20 from 0.
it returns what it should be.

[chipp]

is experience is a global variable?

[Ganado]

What are you trying to do here?

            if ( true )
            {
                experience = 0;
            }

This will always be executed because if(true) will always evaluate to true.
Also you can only be returning 1 thing, I'm not even sure how that compiles but it definitely isn't doing what you think it is. (Edit: Oh right, see keskiverto's answer, but yeah it still isn't doing what you want it to)

Why not use classes?

//Player class defintion stuff left out

//members:
private:
  int exp;
  int level;
...
void Player::addExp(int amount)
{
    exp += amount;
    if (exp >= 100)
    {
        level++;
        exp = 0; //or exp = 100 - amount; although this doesn't take into amount being over 100.
    }
}

[keskiverto]

The comma operator evaluates its both operands, but returns only one. See operator precedence rules.

Why return global variables anyway? They are global.

The 'win' is apparently a global too.
Why have global variables at all?

Why have an unused parameter?

[xenovia12]

Why have an unused parameter?

it exactly is my question ><


'win' is a function

Why return global variables anyway? They are global.

i see i got something in my mind suddenly

[xenovia12]

@Ganado okay im going to change it but im trying to ,if the character ++ is true the exp becomes 0

[xenovia12]

@chipp read the comments

[BHX]

As pointed out, globals aren't normally a good idea (I only do globals if I make them constants; ie. const int SCREEN_W = 640;). If you are needing to return more than one variable you should pass by reference so that the function can modify the values in the function (shown below). As Ganado pointed out, you could use a class.

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32

#include <iostream> // this is just an example for my reference comment void exp_adder(int &exp, int &char_lvl, char win) { if(win == 'w'){ exp += 20; if(exp == 100){ char_lvl++; exp = 0; } } // no penalties for losing right now so no need for else } int main() { int experience = 0, level = 1; char winLose = ' '; do{ std::cout << "Did you win or lose the battle? ([w]in [l]ose [q]uit): "; std::cin >> winLose; exp_adder(experience, level, winLose); std::cout << "\n\nCharacter Level: " << level << "\nExperienc points: " << experience << std::endl; }while(winLose != 'q'); return 0; }

Did you win or lose the battle? ([w]in [l]ose [q]uit): w Character Level: 1 Experienc points: 20 Did you win or lose the battle? ([w]in [l]ose [q]uit): l Character Level: 1 Experienc points: 20 Did you win or lose the battle? ([w]in [l]ose [q]uit): l Character Level: 1 Experienc points: 20 Did you win or lose the battle? ([w]in [l]ose [q]uit): w Character Level: 1 Experienc points: 40 Did you win or lose the battle? ([w]in [l]ose [q]uit): l Character Level: 1 Experienc points: 40 Did you win or lose the battle? ([w]in [l]ose [q]uit): q Character Level: 1 Experienc points: 40

[xenovia12]

okay i learn some techniques about using or making global .

If you are needing to return more than one variable you should pass by reference so that the function can modify the values in the function

i see i did not know it was that simple ><