Getting a not-initialized error but there's nothing to be initialized! Or so I think ?

[NookLines]

Hello !

I'm working on this code for practice and (yes I know it's messy please ignore all the if-statements I'm trying to keep it in simple [and therefore really messy] - in fact maybe there's an issue in the messiness???) it keeps giving me the error below (all located in int main() ).

Could someone please tell me where the error is? As in, what do I need to fix?

Error 1 error C4700: uninitialized local variable 'OverAll' used
Error 2 error C4700: uninitialized local variable 'total' used

#include <iostream>
#include <cmath>
using namespace std;



struct MonthlyBudget
{
	double Housing,
	Utilities,
	Household,
	Transport,
	Food,
	Medical,
	Insurance,
	Ent,
	Clothing,
	Misc, total,
	resulth, resultu,
	resulthd, resultt,
	resultf, resultm,
	resulti, resulte,
	resultc, resultmi,
	OverAll, IdealOverall;
};



void Calculate(MonthlyBudget&, MonthlyBudget&, MonthlyBudget&, MonthlyBudget&);
void displayData(MonthlyBudget, MonthlyBudget, MonthlyBudget, MonthlyBudget);
void getUserInput(MonthlyBudget&);




int main()
{
	MonthlyBudget infor, total, hold, OverAll;


	
	hold.Housing = 500.00;
	hold.Utilities = 150.00;
	hold.Household = 65.00;
	hold.Transport = 50.00;
	hold.Food = 250.00;
	hold.Medical = 30.00;
	hold.Insurance = 100.00;
	hold.Ent = 150.00;
	hold.Clothing = 75.00;
	hold.Misc = 50.00;
	hold.OverAll = 1420.0;


	getUserInput(infor);
	displayData(infor, total, hold, OverAll);

	system("pause >nul");
	return 0;


    
}


void Calculate(MonthlyBudget &infor, 
MonthlyBudget &total, MonthlyBudget &hold, MonthlyBudget &OverAll)
{

	total.resulth = hold.Housing - infor.Housing;
	total.resultu = hold.Utilities - infor.Utilities;
	total.resulthd = hold.Household - infor.Household;
	total.resultt = hold.Transport - infor.Transport;
	total.resultf = hold.Food - infor.Food;
	total.resultm = hold.Medical - infor.Medical;
	total.resulti = hold.Insurance - infor.Insurance;
	total.resulte = hold.Ent - infor.Ent;
	total.resultc = hold.Clothing - infor.Clothing;
	total.resultmi = hold.Misc - infor.Misc;

	OverAll.OverAll = total.resulth + total.resultu +
 total.resulthd + total.resultt + total.resultf + 
total.resultmi + total.resulti + total.resulte + 
total.resultc + total.resultm;
	OverAll.IdealOverall = hold.OverAll - OverAll.OverAll;
}


void getUserInput(MonthlyBudget &infor)
{

	cout << "How much money did you spend on housing this month? ";
	cin >> infor.Housing;
	cout << "How much money did you spend on utilities this month? ";
	cin >> infor.Utilities;
	cout << "How much money did you spend on household expenses this month? ";
	cin >> infor.Household;
	cout << "How much money did you spend on transportation this month? ";
	cin >> infor.Transport;
	cout << "How much money did you spend on food this month? ";
	cin >> infor.Food;
	cout << "How much money did you spend on medical expenses this month? ";
	cin >> infor.Medical;
	cout << "How much money did you spend on insurance this month? ";
	cin >> infor.Insurance;
	cout << "How much money did you spend on entertainment this month? ";
	cin >> infor.Ent;
	cout << "How much money did you spend on clothing this month ? ";
	cin >> infor.Clothing;
	cout << "How much money did you spend on ???? this month? ";
	cin >> infor.Misc;
}

void displayData(MonthlyBudget infor, 
MonthlyBudget total, MonthlyBudget hold, MonthlyBudget OverAll)
{

	cout << "This Month's Expenses" << endl;

	cout << "\nHousing Expenses: " << infor.Housing;
	cout << "Utility Expenses: " << infor.Utilities;
	cout << "Household Expenses: " << infor.Household;
	cout << "Transportation Expenses: " << infor.Transport;
	cout << "Food Expenses: " << infor.Food;
	cout << "Medical Expenses: " << infor.Medical;
	cout << "Insurance Expenses: " << infor.Insurance;
	cout << "Entertainment Expenses: " << infor.Ent;
	cout << "Clothing Expenses: " << infor.Clothing;
	cout << "Misc Expenses: " << infor.Misc;



	Calculate(infor, total, hold, OverAll);



	cout << "Overall Expenses: " << OverAll.OverAll;
	if (OverAll.IdealOverall > 0)
	{
		cout << 
"Overall Expenses are under total budget by : " 
<< "$" << OverAll.IdealOverall;
	}
	if (OverAll.IdealOverall < 0)
	{
		OverAll.IdealOverall = OverAll.IdealOverall * -1;
		cout << 
"Overall Expenses are over total budget by : " 
<< "$" << OverAll.IdealOverall;
	}
	


	cout << "How much you went over/under budget" << endl;
	if (total.resulth > 0)
	{
		cout << "You were under budget by: " << "$" << total.resulth;

	}
	if (total.resultu > 0)
	{
		cout << "You were under budget by: " << "$" << total.resultu;

	}
	if (total.resulthd > 0)
	{
		cout << "You were under budget by: " << "$" << total.resulthd;

	}
	if (total.resultt > 0)
	{
		cout << "You were under budget by: " << "$" << total.resultt;

	}
	if (total.resultf > 0)
	{
		cout << "You were under budget by: " << "$" << total.resultf;

	}
	if (total.resultm > 0)
	{
		cout << "You were under budget by: " << "$" << total.resultm;

	}
	if (total.resulti > 0)
	{
		cout << "You were under budget by: " << "$" << total.resulti;

	}
	if (total.resulte > 0)
	{
		cout << "You were under budget by: " << "$" << total.resulte;

	}
	if (total.resultc > 0)
	{
		cout << "You were under budget by: " << "$" << total.resultc;

	}
	if (total.resultmi > 0)
	{
		cout << "You were under budget by: " << "$" << total.resultu;

	}
		if (total.resulth > 0)
	{
		cout << "You were under budget by: " << "$" << total.resulth;

	}
	if (total.resultu > 0)
	{
		cout << "You were under budget by: " << "$" << total.resultu;

	}
	if (total.resulthd > 0)
	{
		cout << "You were under budget by: " << "$" << total.resulthd;

	}
	if (total.resultt > 0)
	{
		cout << "You were under budget by: " << "$" << total.resultt;

	}
	if (total.resultf > 0)
	{
		cout << "You were under budget by: " << "$" << total.resultf;

	}
	if (total.resultm > 0)
	{
		cout << "You were under budget by: " << "$" << total.resultm;

	}
	if (total.resulti > 0)
	{
		cout << "You were under budget by: " << "$" << total.resulti;

	}
	if (total.resulte > 0)
	{
		cout << "You were under budget by: " << "$" << total.resulte;

	}
	if (total.resultc > 0)
	{
		cout << "You were under budget by: " << "$" << total.resultc;

	}
	if (total.resultmi > 0)
	{
		cout << "You were under budget by: " << "$" << total.resultmi;

	}


	if (total.resulth < 0)
	{
		total.resulth = total.resulth * -1;
		cout << "You were over budget by: " << "$" << total.resulth;

	}
	if (total.resultu < 0)
	{
		total.resultu = total.resultu * -1;
		cout << "You were over budget by: " << "$" << total.resultu;

	}
	if (total.resulthd < 0)
	{
		total.resulthd = total.resulthd * -1;
		cout << "You were over budget by: " << "$" << total.resulthd;

	}
	if (total.resultt < 0)
	{
		total.resultt = total.resultt * -1;
		cout << "You were over budget by: " << "$" << total.resultt;

	}
	if (total.resultf < 0)
	{
		total.resultf =total.resultf * -1;
		cout << "You were over budget by: " << "$" << total.resultf;

	}
	if (total.resultm < 0)
	{
		total.resultm = total.resultm * -1;
		cout << "You were over budget by: " << "$" << total.resultm;

	}
	if (total.resulti < 0)
	{
		total.resulti = total.resulti * -1;
		cout << "You were over budget by: " << "$" << total.resulti;

	}
	if (total.resulte < 0)
	{
		total.resulte= total.resulte * -1;
		cout << "You were over budget by: " << "$" << total.resulte;

	}
	if (total.resultc < 0)
	{
		total.resultc = total.resultc * -1;
		cout << "You were over budget by: " << "$" << total.resultc;

	}
	if (total.resultmi < 0)
	{
		total.resultmi = total.resultmi * -1;
		cout << "You were over budget by: " << "$" << total.resultmi;

	}


}

[Ganado]

That is a lot of repeated code you got there... the problem is that you seem to be initializing a lot of things, in different areas of your code. This is very prone to error, and it's hard for someone else to easily see what's going on.

For example, I wouldn't expect a displayData() function to then call a calculate function that then changes the properties in the parameters. Your code is all over the place, and chances are that you missed something.

Edit: Is your compiler giving you a particular line or two where it says it's uninitialized?

Edit 2: Before you call any other functions, you could try initializing every property in all 4 of your struct instances to be -1.0 or -100000.0. Then you can change it from there and use a debugger or give cout statements to see where the problem is.

Edit 3: Your displayData() function isn't passing any of your MonthlyBudget instances by reference. It probably doesn't like that your total or overAll instances are being passed without being initialized.

[NookLines]

Yeah, true. I think in the end I'll have to just scrap this and start again or go through the solution manual and see what they did.

I was trying to emulate what I did in my other code but this got too, too messy and now I have no idea what the heck is going on. I thought maybe someone else could but yeah @__@

Edit: woops, I actually had my error's in there but I guess I accidentally deleted them when I went over the text limit. Added the error's back in. They're all in int main() [both in line 56]

[AbstractionAnon]

Line 38: You declare total and Overall, but you never initialize these structures before passing them to displayData() at line 56.

[NookLines]

THANK YOU to the both of you!! It's fixed. I'll keep in mind for future though to have cleaner code.