if statment help!

[megacraft]

At the Mob detail part, when I press 1, it goes to the 0 part first. Please tell me how to make it go to 1 when I press 1. Thank you.

  #include <iostream>
#include <cstdio>
#include <cstdlib>

using namespace std;

float menuoption;
float minecraftoption;
int mobdetail;
int mobdetailzombie;
int mobdetailzombiepigman;

int main()

{
    start:

    cout << string(300, '\n');
    cout<<("Welcome to my c++ file! Please select one of the following options.\n1-Minecraft") << endl << endl;
    cout<<("\nCHOICE: ") << endl << endl;
    cin>> menuoption;
    if(menuoption==1)
    {
        /*MINECRAFT*/
        cout << string(300, '\n');
        cout<<("Thank you for choosing the minecraft option.\nPlease select what you want to do") << endl << endl;
        cout<<("\n1-Minecraft Item ID's, 2-Mob details") << endl << endl;
        cout<<("\nCHOICE: ") << endl << endl;
        cin>> minecraftoption;

        if(minecraftoption==1)
        {
            /*MINECRAFT ID'S*/
            cout << string(300, '\n');


        }
        else if(minecraftoption==2)
        {
            /*MOB DETAILS*/
            cout << string(300, '\n');
            cout<<("0-zombie, 1-zombie pigman, 2-skeleton, 3-spider, 4-blaze, 5-ghast, 6-wither");
            cout<<("\nPlease state the mob you want to look up: ");
            cin>> mobdetail;
            if(mobdetail==0);
            {
                /*zombie*/
                cout << string(300, '\n');
                cout<<("\n\nName - Zombie\n");
                cout<<("Found - Cave systems and at night\n");
                cout<<("Drops - Rotton Flesh, Iron Ignot, carrot, potato.\n");
                cout<<("Rare drops - Iron shovel, Iron sword, random aromor.\n");
                cout<<("Experiance - 5\n");
                cout<<("Attack strength(hp16-20) - easy - 2, normal - 3, hard - 4.\n");
                cout<<("Attack strength(hp11-15) - easy - 3, normal - 4, hard - 6.\n");
                cout<<("Attack strength(hp6-10) - easy - 3, normal - 5, hard - 7.\n");
                cout<<("Attack strength(hp1-5) - easy - 4, normal - 6, hard - 9.\n");
                cout<<("Health - 20.\n");
                cout<<("Do you want to continue? 1 - yes, 0 - no: ");
                cin>> mobdetailzombie;
                if(mobdetailzombie==0)
                {
                    /*LEAVE EMPTY*/
                }
                if(mobdetailzombie==1)
                {
                   cout << string(300, '\n');
                   goto start;
                }
            }
            if(mobdetail==1);
            {
                /*zombie pigman*/
                cout << string(300, '\n');
                cout<<("\n\nName - Zombie Pigman\n");
                cout<<("Found - Dimely lit areas in the Nether, and when a pig is struck by lightening.\n");
                cout<<("Drops - Rotton flesh, gold nugget.\n");
                cout<<("Rare drops - Golden Sword, Random Armor.\n");
                cout<<("Experiance - 5.\n");
                cout<<("Attack strength - easy - 5, normal - 9, hard - 13.\n");
                cout<<("Health - 20");
                cout<<("Need to know - If attacked, other zombie pigmen will attack you.\n");
                cout<<("Do you want to continue? 1 - yes, 0 - no: ");
                cin>> mobdetailzombiepigman;
                if(mobdetailzombiepigman==0)
                {
                    /*LEAVE EMPTY*/
                }
                else if(mobdetailzombiepigman==1)
                {
                    cout << string(300, '\n');
                    goto start;
                }
            }
            if(mobdetail==2);
            {
                /*skeleton*/
                cout << string(300, '\n');
            }
            if(mobdetail==3);
            {
                /*spider*/
                cout << string(300, '\n');
            }
            if(mobdetail==4);
            {
                /*blaze*/
                cout << string(300, '\n');
            }
            if(mobdetail==5);
            {
                /*ghast*/
                cout << string(300, '\n');
            }
            if(mobdetail==6);
            {
                /*wither*/
                cout << string(300, '\n');
            }
        }
    }
    if(menuoption!=1)
    {
        cout << string(300, '\n');
        cout<<("I'm sorry, the option you entered is not reconised. Application will now close");}


}

[skilzzz]

Well, don't hold me on it as I'm fairly new to c++ myself, but I think that if statements don't work that way. You should try while loops.

[Chervil]

I'd recommend type int rather than float for the user input.

But the main problem is the unnecessary semicolon:

if (mobdetail==0);
{
    // detailed code here            
}

The "if" is actually controlling an empty statement, ending at the semicolon. The following code in braces is always executed as it is not dependent on any condition.

Should be like this:

if (mobdetail==0)
{
    // detailed code here             
}

[keskiverto]

1. Avoid the use of goto. It can cause problems.

2. Study if else. It is better than two if clauses when the first being true already means that the other tests will fail.

3. Avoid global variables.

4. The mentioned problem migth relate to how "clean" the stream is before the read. I'm no expert on that, but I've seen the explanation in several threads.

[jidder]

1. Wouldn't typechar be better for user input as all the inputs are relatively small numbers ?

2. Also couldn't you use a switch statement instead of lots of if statements ?

3. Would it not be possible to make this a function and then call it each time goto start is used instead.

[AbstractionAnon]

@jidder
1) Not necessarily. Comparisons would have to be changed to character literals ('1'). Any possible savings in memory would be minimal or non-existant due to padding for alignment.

2) Yes. Generally preferred.

3) Yes. Cleaner approach.

[Chervil]

However, the main advantage of the char type for user input is that it doesn't fail if the user enters a non-numeric character. So it can keep the code simpler as there is less need for error-handling.