Pointer error in vector

[SkillsXP]

The error is "delete (*it)".

#include <iostream>
#include <string>
#include <vector>
using namespace std;
int main(){
	vector<string> vList;


	vList.push_back("a");
	vList.push_back("b");
	vList.push_back("c");
	vList.push_back(":");
	vList.push_back(":");
	vList.push_back(":");
	vList.push_back("d");


		std::string sswicher, str2;
	char lastChar1, lastChar2;
	bool blok1 = false;
	for(auto it = vList.begin(); it != vList.end(); it++)
	{
		if(blok1 == false){
			sswicher = (*it);
			lastChar1 = *sswicher.rbegin();
		}
			blok1 = false;	

			it++;
			sswicher = (*it);
			lastChar2 = *sswicher.rbegin();

			if((lastChar1 == ':') && (lastChar2 == ':'))
			{
				it-=1;
				delete (*it); //Expression has to be a pointer <-- What should I do now?
				(*it) = nullptr;
				it = vList.erase(it);
				lastChar1 = lastChar2;
				blok1 = true;
			}	
	}

	for(auto it = vList.begin(); it != vList.end(); it++)
	{
		cout << (*it) << endl;
	}


getchar();
return 0;
}

Thanks for any cooperation!

[Peter87]

delete is meant to be used on pointers to delete memory that was allocated using new. *it is not a pointer, it's a std::string, and you didn't use new to create it so delete is not what you should be using here.

On line 38 you remove the string from the vector. You don't need to do more than that.

Note that after line 38 it will refer to the element after the removed element and then on line 21 it will be stepped once again so the loop misses to handle the element after the removed one. To avoid this you should make sure that it++ is only executed if the previous element was not removed, something like this:

for(auto it = vList.begin(); it != vList.end();)
{
	...
	if(...)
	{
		...
		it = vList.erase(it);
		...
	}
	else
	{
		it++;
	}
}