compiling error

[nj1995]

Hi,when I attempt to run my code in unix it returns an error saying that 'data' is not a member of the vector in my toUpper function, but it runs fine when I run it else where, I would appreciate any help. Thanks.

#include <iostream>
#include <string>
#include <vector>
#include <algorithm>
#include <cstring>
using namespace std;

void loadVector(vector<char> &v);
//Precondition: char vector passed
//Postcondition: loads a word or phrase into the vector

void displayVector(vector<char> &v);
//Precondition: char vector is passed, vector must be loaded 
//with word/phrase
//Postcondition: displays the vector

void toUpper(vector<char> &v);
//Precondition: char vector is passed, vector must be loaded
//Postcondition: converts all lower case letters in the 
//phrase/word into upper case

void removeNonAlphabets(vector<char> &v);
//Precondition: char vector passed, vector must be loaded
//Postcondition: removes all non-alphabets from the vector

bool isPalindrome(const vector<char> &v);
//Precondition: char vector passed, vector must be loaded
//Postcondition: determines whether or not the word/phrase is
//a palindrome

void loadVector(vector<char> &v)
{
    string input;
 
    cout << "Enter a word, phrase or sentence to see if it's a palindrome: " << endl;
    getline(cin, input);
    for(unsigned int i=0; i<input.size(); i++)
    {
    	v.push_back(input[i]);
    	cout << endl;
	}
}


void displayVector(vector<char> &v)
{
	for(int i = 0; i < v.size(); i++)
	{
		cout << v[i];
	}
}

void toUpper(vector<char> &v)
{
	for (unsigned int i = 0; i < v.size(); i++)
    {
        char temp[v.size()];
		memcpy(temp,v.data(),v.size());
        int j = 0;

        while (temp[j]) 
		{ 
			temp[j] = toupper(temp[j]); 
			j++;
	    }
        v[i] = temp[i];
    }
}

void removeNonAlphabets(vector<char> &v)
{
    unsigned int m =0;
    for(unsigned int j = 0; j < v.size(); j++)
    {
        char temp = v[j];
        
            if (isalpha(v[j])!=0)
            {
               v[m] = temp;
               m++;
            }
    }

    v.resize(m);
}


bool isPalindrome(const vector<char> &v)
{  
  	size_t i = 0;
    size_t j = v.size() - 1;
    
    while (i < j) 
	{
        if (v[i++] != v[j--]) 
		{
            return false;
        }
    }
    return true;
}

int main()
{
	vector<char> v;
		
	loadVector(v);
		
	cout << endl <<  "The original input string contains: " << endl;
	displayVector(v);
	cout << endl << endl;	
	
	cout << "After conversion to upper-case, input string contains: " << endl;
    toUpper(v);
    displayVector(v);
    cout << endl << endl;
    
    cout << "After removal of non-alphabets, input string contains: " << endl;
    removeNonAlphabets(v);
    displayVector(v);
    cout << endl;
    
    cout << endl;
	if(isPalindrome(v) == true)
	{
		displayVector(v);
		cout << " IS a palindrome!" << endl;
	}
	else
	{
		displayVector(v);
		cout << " is NOT a palindrome!" << endl;
	}
	
	return 0;
}

[Peter87]

Make sure your compiler is up-to date enough and that you have at least enabled C++11 features. With GCC you do this by passing -std=c++11 to the compiler.

[jlb]

Also be aware that C++ doesn't allow Variable Length Arrays. Array sizes must be compile time constants.

What exactly are you trying to do in you toUpper() function? If you're just trying to convert the whole vector to uppercase why not just use std::transform() instead of all the copying?

#include <algorithm>
...
void toUpper(vector<char> &v)
{
    std::transform(v.begin(), v.end(), v.begin(), ::toupper);
}