My First Game!

[FireCoder]

Russian Roulette! My first non-graphic game. This is a 2 player game, so grab a friend and enjoy!

//First Game!
//Coder: FireCoder.
//Date: 9/2/15
//Version 1.3
/*
Cleaned Code.
Now able to add multible players.
*/
#include <iostream>
#include <cstdlib>
#include <ctime>

void checkSurvival(int i); //To print your death message.

int main()
{
    bool dead = false;
    int slot, player = 1, players = 2;
    const int BULLET_POS = 2; //Unchangable do to request.
    
    srand(time(0)); //Changes seed every secound.
    
    std::cout << "How many players?\t"; //Sets players.
    std::cin  >> players;
    std::cin.ignore(); // This is to make sure after you press "Enter" it will not
                              // miss fire.
    while(dead == false) //Game only works while alive.
    {
        slot = (rand() % 6) + 1; //What slot will be fired.
        
        std::cout << "Press 'Enter' to pull trigger...";
        std::cin.ignore(); //We only need a non-spesific input.
        
        if(BULLET_POS != slot) //If bullet was not shot.
        {
            std::cout << "*click*\n";
            checkSurvival(0); 
            if(player != players) //If Player 1 finished last.
            {
                player++;
            }
            else //If player 2 finished last.
            {
                player = 1;   
            }
            
            std::cout << "Player "<< player <<": your turn.\n"; 
        } 
        else //If bullet was shot.
        {
            
            std::cout << "BANG!!!\n";   
            checkSurvival(1);
            dead = true; //Ends game.
        }
    }
    
    std::cout << "Player "<< player <<" died...\n"; //Game ending message.
} 

void checkSurvival(int i) //To print your death message.
{
    if(i == 0) //If survived.
    {
        std::cout << "You survived for now...\n" ;
    }
    else //IF died.
    { 
        std::cout << "R.I.P.\n";
    }
}

[Peter87]

Works great! :D I prefer playing as player 2 because it improves my chances of survival.

[MiiNiPaa]

You should not reset slot and position each iteration. In this case it provides even chances for both players.

[FireCoder]

@Peter87 Thanks!
@MiiNiPaa The randomization is a sim of the barrel spin in between turns.

[MiiNiPaa]

There are variations of that game. I am just saying that not-spinning-between-turns is fair version. Another approach would be spinning barrel after each pair of turns.

[FireCoder]

@MiiNiPaa You have a point. Here is a updated version.

//First Game!
//Coder: FireCoder.
//Date: 9/2/15
//Version 1.2
/*
Cleaned Code.
Added comments.
Re-did revolver spin.
*/
#include <iostream>
#include <cstdlib>
#include <ctime>

void checkSurvival(int i) //To print your death message.
{
    if(i == 0) //If survived.
    {
        std::cout << "You survived for now...\n" ;
    }
    else //IF died.
    { 
        std::cout << "R.I.P.\n";
    }
}

int main()
{
    bool dead = false;
    int slot, player = 1;
    const int BULLET_POS = 2; //Unchangable do to request.
    
    srand(time(0)); //Changes seed every secound.
    
    while(dead == false) //Game only works while alive.
    {
        slot = (rand() % 6) + 1; //What slot will be fired.
        
        std::cout << "Press 'Enter' to pull trigger...";
        std::cin.ignore(); //We only need a non-spesific input.
        
        if(BULLET_POS != slot) //If bullet was not shot.
        {
            std::cout << "*click*\n";
            checkSurvival(0); 
            if(player == 1) //If Player 1 finished last.
            {
                player++;
            }
            else //If player 2 finished last.
            {
                player--;   
            }
            
            std::cout << "Player "<< player <<": your turn.\n"; 
        } 
        else //If bullet was shot.
        {
            
            std::cout << "BANG!!!\n";   
            checkSurvival(1);
            dead = true; //Ends game.
        }
    }
    
    std::cout << "Player "<< player <<" died...\n"; //Game ending message.
} 

[Ericool]

I like that part :

if(player == 1) //If Player 1 finished last.
{
player++;
}
else //If player 2 finished last.
{
player--;
}

[FireCoder]

Thanks.

[18hRX9L8]

You should add support for multiple players. That would be fun.

[FireCoder]

I will post a better version soon with your suggestion!

[E0p9LyTq]

Another improvement could be using one of the C++ random number engines instead of the C generator.

[FireCoder]

Thanks, I am going to work on something else, but I don't know what.