Delete Operator Is not working the program crash at the end

[Sarmadas]

int main()
{
int vnum = 0;
VEHICLE *vehiptr;
VEHICLE *dptr;
cout<<"Please enter the number of vehicle: ";
cin>>vnum;
vehiptr = new VEHICLE[vnum];
dptr = vehiptr;
for(int a=1;a<=vnum;a++)
{
vehiptr->get_input();
if(a<vnum)
{
vehiptr++;
}
}
for(int i =1;i<=vnum;i++)
{
dptr->display();
if(i<vnum)
{
dptr++;
}


}
delete [] vehiptr;

[Peter87]

vehiptr is no longer pointing to the first element of the array. The pointer value that you pass to delete has to be the same pointer value that was returned from new.

[Sarmadas]

ok please give me a correct code please

[Sarmadas]

this code is working but can i do better then that
int main()
{
int vnum = 0;
VEHICLE* vehiptr;
VEHICLE *dptr;
VEHICLE * zptr;
cout<<"Please enter the number of vehicle: ";
cin>>vnum;
vehiptr = new VEHICLE[vnum];
dptr = vehiptr;
zptr = dptr;
for(int a=1;a<=vnum;a++)
{
dptr->get_input();
if(a<vnum)
{
dptr++;
}
}
for(int i =1;i<=vnum;i++)
{
zptr->display();
if(i<vnum)
{
zptr++;
}


}

delete [] vehiptr;
system("pause");

}

[Peter87]

Instead of having a lot of pointers you could use the subscript operator.

for(int a=0;a<vnum;a++)
{
	vehiptr[a].get_input();
}

[Sarmadas]

but what about the increment of the pointer i think that is casing the problem when i increment vehiptr++

[Peter87]

If you do it like this you don't need to increment the pointer.

[Sarmadas]

you mean like this by doing that i got heap corruption error

int main()
{
int vnum = 0;
	VEHICLE* vehiptr;
	cout<<"Please enter the number of vehicle: ";
	cin>>vnum;
	vehiptr = new VEHICLE[vnum];
	for(int a=1;a<=vnum;a++)
	{
	vehiptr[a].get_input();

	}
	for(int i =1;i<=vnum;i++)
	{
		vehiptr[i].display();
	}

	delete [] vehiptr;
system("pause");

}

[Peter87]

Array indices starts at 0 so vehiptr[0] is the first element in the array and vehiptr[vnum - 1] is the last element in the array.

[Sarmadas]

Thanks a lot