Need to figure out what is wrong with this code

[kg88]

Hi I need a little help with this code that I've been writing for an assignment. This is what I have:

 
#include <stdio.h>
#include <iostream>
#include <cmath> 
using namespace std; 

class personalComputer {
private:
    string manufacturer;
    string model;
    string serialNumber;
    string cpu;
    int memory;
    double speed;
    string operatingSystem;
    double diskSize;
    string graphicsCard;
    int usbPortcount;
    int bootState;
public:
    personalComputer(string manufacturer, string model, string serialNumber, string cpu, int memory, double speed, string operatingSystem, double diskSize, string graphicsCard, int usbPortcount, int bootState);
    ~personalComputer();
   
string getManufacturer() const{
    return manufacturer;
    };
string getModel() {
    return model;
};
string getSerial()const {
    return serialNumber;
};
string getCpu()const {
    return cpu;
};
double getSpeed() const{
    return speed;
    };
int getMemory() const{
    return memory;
    };
double getDisksize()const {
    return diskSize;
    };
string getGraphicscard()const {
    return graphicsCard;
    };
int getUsbports() const {
    return usbPortcount;
};
int getBootstate() const {
    return bootState;
};
string getOperating() const {
    return operatingSystem;
};
   
    
    void setManufacturer(string manu) {
        };
    void setModel(string mode) {
    };
    void setSerial(string seri) {
    };
    void setCpu(string cp) {
    };
    void setSpeed(double spee) {
        if (spee >= 0) {
            speed = speed;
        }
        else {
            cout << "Please enter a valid input ( a positive number)." << endl;
            cin >> spee;
        }
    };
    void setMemory(int mem) {
        if (mem >= 1) {
            mem = memory;
        }
        else {
            cout << "Please enter a valid input." << endl;
            cin >> mem;
        }
    };
    void setDisksize(double disk) {
        if (disk >= 1) {
            disk =  diskSize;
        }
        else {
            cout << "Please enter a valid input." << endl;
            cin >> disk;
        }
    };
    void setGraphicscard(string graphics) {
    };
    void setOperating(string op_sy) {
    };
    void setUsbports(int usb) {
        if (usb >=0) {
            usb = usbPortcount;
        }
        else {
            cout << "Please enter a valid input." << endl;
            cin >> usb;
        }
    };
    void setBootstate(int boot) {
        if (boot ) {
            boot = bootState;
        }
        else {
            cout << "Please enter a valid input ( 0 for shut off, 1 for turn on." << endl;
            cin >> boot;
        }
    };


    int main()
    {

        personalComputer comp;
        string manu;
        string mode;
        string seri;
        string cp;
        int mem;
        double spee;
        string op_sy;
        double disk;
        string graphics;
        int usb;
        int boot;
        int spec1;
        int spec2;
        int spec3;


        cout << "This program displays the attributes of a personal computer based on the data you provide.  Please enter the specifications of your computer when prompted. " << endl;
        cout << "Please enter the manufacturer of your computer.";
        cin >> manu;
        cout << endl;
        comp.setManufacturer(manu);

        cout << "Please enter the serial number of your computer.";
        cin >> seri;
        cout << endl;
        comp.setSerial(seri);

        cout << "Please enter the CPU name of your computer.";
        cin >> cp;
        cout << endl;
        comp.setCpu(cp);

        cout << "Please enter the speed of your computer.";
        cin >> spee;
        cout << endl;
        comp.setSpeed(spee);

        cout << "Please enter the memory of your computer.";
        cin >> mem;
        cout << endl;
        comp.setMemory(mem);

        cout << "Please enter the disk size of your computer.";
        cin >> disk;
        cout << endl;
        comp.setDisksize(disk);

        cout << "Please enter the operating system of your computer.";
        cin >> op_sy;
        cout << endl;
        comp.setOperating(op_sy);

        cout << "Please enter the number of USB ports on your computer.";
        cin >> usb;
        cout << endl;
        comp.setUsbports(usb);

        cout << "Please enter the graphics card of your computer.";
        cin >> graphics;
        cout << endl;
        comp.setGraphicscard(graphics);




 
  
    return 0;}};

I have a couple more sections to add on this, but I keep on getting error messages for part of it. I'm not really sure what I'm not really sure what I'm doing wrong when I try to fix it, because the error code keeps changing.

Here is the error log for this from c++ shell
In member function 'int personalComputer::main()':
125:26: error: no matching function for call to 'personalComputer::personalComputer()'
125:26: note: candidates are:
25:5: note: personalComputer::personalComputer(std::string, std::string, std::string, std::string, int, double, std::string, double, std::string, int, int)
25:5: note: candidate expects 11 arguments, 0 provided
11:7: note: personalComputer::personalComputer(const personalComputer&)
11:7: note: candidate expects 1 argument, 0 provided
206:24: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
136:13: warning: unused variable 'boot' [-Wunused-variable]
139:13: warning: unused variable 'spec3' [-Wunused-variable]

I'm not sure what I"m doing wrong on the personalComputer section.

[Ganado]

Please edit your code and add [code] and [/code] around your code to format your code.

The problem is that you only have 1 constructor defined for your personalComputer class.

personalComputer(string manufacturer, string model, string serialNumber,
    string cpu, int memory, double speed, string operatingSystem,
    double diskSize, string graphicsCard, int usbPortcount, int bootState);

When you define a custom constructor instead of using the default constructor, it is automatically removed unless you explicitly make another, 0-arg constructor yourself.

You don't use this multi-arg constructor that you defined, so the easiest thing would be to remove it.

______________________________

if (spee >= 0) {
speed = speed;
}

What is the purpose of this? speed = speed is essentially a no-op.

[kg88]

Also, for the coding pros out there, I'm sorry if this is something super easy that I overlooked. I'm still not the most comfortable programming and I'm not understanding where I'm messing things up at. I tried to switch the personalComputer ( with variables) to

personalComputer::personalComputer(with variables)
but an error for it still pops up.

[Ganado]

I assumed at first that you simply left it out, but if that's your full code, the issue is that you declare your constructor, but don't define it. However, the code you posted now does not match the line numbers that the compiler is printing.

Still, the solution is the same. You are not using that multi-arg constructor, so just delete line 21 (and 22).

[kg88]

Sorry about not formatting it properly. Thanks for letting me know.
Also oops that a type-o on the speed sections it should've been spee=speed, so that it can change the private members of the class.
Thanks for you help! I really appreciate it.

[Ganado]

You also should adopt more consistent indentation.

Part of your issue is that you are defining main within your class. Your main function should be outside of the class.

class MyClass {
private:
    // ...

public:
    void some_functions()
    {
        // ...
    }
};

int main()
{
    MyClass myclass;
}

[kg88]

Thank you for the knowledge Ganado! I definitely need to work on indenting more consistently. Sorry that I made if so difficult to read. Also thank you so much once again! I would've spent a long time trying to figure out what I was doing wrong and you figure it out in a minute.