Error with Infile.

[Aneiron]

So when reading the Grades.txt file I have the first number is 4. When the program runs it reads the file fine, but requires me to hit "Enter" 4 times before It displays the rest of the grades and the average. If I change that number to 12 for example, it then requires me to hit "Enter" 14 times before giving me the rest of the grades and the average. The first number of the file is just supposed to tell the program how many grades are in the file. How do I change this so once the input file is read it just does the calculations?

//Driver.cpp

#include <iostream>

#include <fstream>

#include <string>

#include <iomanip>

#include "Scores.h"

using namespace std;

int main() {

// Define local variables

int score, num;

string inputFile;

// uses inData for input file stream

ifstream inData;

cout << "Enter the input file :";

// getline is used for if user enters a space for a file name

getline(cin, inputFile);

inData.open(inputFile.c_str());

// checks to see if the file is valid

if (inData.fail()) {

cout << "File Not Found";

return 1;

}

inData >> num;

if (num < 0) {

cout << "Invalid Score Entered: " << num<<endl;

return 0;

}

Scores scoreslist;

for (int i = 0; i < num; i++) {

inData >> score;

bool value = scoreslist.addScore(score);

if (!value)

cout << "Invalid score entered :" << num << endl;

}

cout<<setprecision(2)<<fixed;

scoreslist.sortScore();

cout << "Displaying Scores After Sorting :" << endl;

scoreslist.displayScores();

cout << "Average Score :" << scoreslist.averageScores() << endl;

// system("pause");

return 0;

}

 
//Scores.cpp

#include "Scores.h"

Scores::Scores(int val) {

size = 0;

for (int i = 0; i < 100; i++) {

scoresList[i] = val;

}

}

Scores::Scores() {

size = 0;

for (int i = 0; i < 100; i++) {

scoresList[i] = 0;

}

}

bool Scores::addScore(int val) {

if (val < 0) {

return false;

} else {

scoresList[size] = val;

size++;

return true;

}

}

void Scores::sortScore() {

// This Logic will Sort the Array of elements in Ascending order

int temp;

for (int i = 0; i < size; i++) {

for (int j = i + 1; j < size; j++) {

if (scoresList[i] > scoresList[j]) {

temp = scoresList[i];

scoresList[i] = scoresList[j];

scoresList[j] = temp;

}

}

}

}

double Scores::averageScores() {

double total = 0;

for (int i = 0; i < size; i++) {

total = total + scoresList[i];

}

return ((double)total) / size;

}

void Scores::displayScores() {

for (int i = 0; i < size; i++) {

cout << scoresList[i] << endl;

}

}

//Scores.h

#pragma once

#include<iostream>

using namespace std;

class Scores {

private:

int scoresList[100];

int size;

public:

Scores();

Scores(int list);

bool addScore(int val);

void sortScore();

double averageScores();

void displayScores();

};

[salem c]

First of all, indent your code.

//Driver.cpp
#include <iostream>
#include <fstream>
#include <string>
#include <iomanip>

using namespace std;

class Scores {
private:
  int scoresList[100];
  int size;

public:
   Scores();
   Scores(int list);
   bool addScore(int val);
   void sortScore();
   double averageScores();
   void displayScores();
};

Scores::Scores(int val)
{
  size = 0;
  for (int i = 0; i < 100; i++) {
    scoresList[i] = val;
  }
}

Scores::Scores()
{
  size = 0;
  for (int i = 0; i < 100; i++) {
    scoresList[i] = 0;
  }
}

bool Scores::addScore(int val)
{
  if (val < 0) {
    return false;
  } else {
    scoresList[size] = val;
    size++;
    return true;
  }
}

void Scores::sortScore()
{
  // This Logic will Sort the Array of elements in Ascending order
  int temp;
  for (int i = 0; i < size; i++) {
    for (int j = i + 1; j < size; j++) {
      if (scoresList[i] > scoresList[j]) {
        temp = scoresList[i];
        scoresList[i] = scoresList[j];
        scoresList[j] = temp;
      }
    }
  }
}

double Scores::averageScores()
{
  double total = 0;
  for (int i = 0; i < size; i++) {
    total = total + scoresList[i];
  }
  return ((double) total) / size;
}

void Scores::displayScores()
{
  for (int i = 0; i < size; i++) {
    cout << scoresList[i] << endl;
  }
}

int main()
{
  // Define local variables
  int score, num;
  string inputFile;

  // uses inData for input file stream
  ifstream inData;

  cout << "Enter the input file :";

  // getline is used for if user enters a space for a file name
  getline(cin, inputFile);

  inData.open(inputFile.c_str());

  // checks to see if the file is valid
  if (inData.fail()) {
    cout << "File Not Found";
    return 1;
  }

  inData >> num;
  if (num < 0) {
    cout << "Invalid Score Entered: " << num << endl;
    return 0;
  }

  Scores scoreslist;
  for (int i = 0; i < num; i++) {
    inData >> score;
    bool value = scoreslist.addScore(score);
    if (!value)
      cout << "Invalid score entered :" << num << endl;
  }

  cout << setprecision(2) << fixed;
  scoreslist.sortScore();
  cout << "Displaying Scores After Sorting :" << endl;
  scoreslist.displayScores();
  cout << "Average Score :" << scoreslist.averageScores() << endl;

  return 0;
}

The wording and the variables in your error messages need a bit of work as well.


Plus, it works here without any extra newline pressing required.

$ cat foo.txt
4
22
44
33
11
$ g++ -std=c++11 foo.cpp
$ ./a.out 
Enter the input file :foo.txt
Displaying Scores After Sorting :
11
22
33
44
Average Score :27.50

[Aneiron]

Here is updated main and it works great. The only thing is I need to add error checking so the program stops if it reads in a negative number or a letter input. Right now if it reads either of those in it just ignores it and continues with the calculations normally. In my in line 103 to 107 would I just add a error display message and a system pause/ return 0?

#include <iostream>
#include <fstream>
#include <string>
#include <iomanip>
#include "Scores.h"

using namespace std;

int main() 
{
	// Define local variables
	int score, num;
	string inputFile;
	// uses inData for input file stream
	ifstream inData;
	cout << "Enter the input file :";
	// getline is used for if user enters a space for a file name
	getline(cin, inputFile);
	inData.open(inputFile.c_str());
	// checks to see if the file is valid
	if (inData.fail()) 
	{
		cout << "File Not Found \n";
		cout << "Enter correct input file :";
		getline(cin, inputFile);
		inData.open(inputFile.c_str());
	}

	Scores scoreslist;
	inData >> num;
	for (int i = 0; i < num; i++) 
	{
		inData >> score;
		bool value = scoreslist.addScore(score);
		if (!value)
		cout << "Invalid score entered: " << score << endl;
	}

	cout << setprecision(2) << fixed;
	scoreslist.sortScore();
	cout << "Displaying Scores After Sorting Correct Scores:" << endl;
	scoreslist.displayScores();
	cout << "Average Score :" << scoreslist.averageScores() << endl;
	system("pause");
	return 0;
}