TicTacToe vs computer

[NAYR453]

Im trying to code a Tictactoe game against the computer, my game works perfectly expect I can't get the computer to automatically place the 'O' marker. However it will generate and output the number on the computers turn. Any help would be much appreciated, I have attached the code below.

#include <iostream>
#include <cstdlib>
#include <iostream>
#include <ctime>

using namespace std;

class tictactoe {

public:

    int playerWins;
    int Draw;

    void draw_board(char board[])
    {

    cout << "\n\n\tTic Tac Toe\n\n";

    cout << "Player (X)  -  Computer (O)" << endl << endl;
    cout << endl;

    cout << "     |     |     " << endl;
    cout << "  " << board[1] << "  |  " << board[2] << "  |  " << board[3] << endl;

    cout << "_____|_____|_____" << endl;
    cout << "     |     |     " << endl;

    cout << "  " << board[4] << "  |  " << board[5] << "  |  " << board[6] << endl;

    cout << "_____|_____|_____" << endl;
    cout << "     |     |     " << endl;

    cout << "  " << board[7] << "  |  " << board[8] << "  |  " << board[9] << endl;

    cout << "     |     |     " << endl << endl;
    }
    void clearScreen(){
                for (int i = 0; i < 50; i++)
                        cout << endl;
        }

    bool isGameOver(char board[])
    {
        if (board[1] == board[2] && board[2] == board [3] )
        {
            if (board[1] == 'X')
            {
            this->playerWins = 1;
                        return true;
            }
            else
            {
            this->playerWins = 2;
                        return true;
            }
        }
    else if (board[4] == board[5] && board[5] == board [6] )
        {
            if (board[4] == 'X')
            {
            this->playerWins = 1;
                        return true;
            }
            else
            {
            this->playerWins = 2;
                        return true;
            }
        }
        else if (board[7] == board[8] && board[8] == board [9] )
        {
            if (board[7] == 'X')
            {
            this->playerWins = 1;
                        return true;
            }
            else
            {
            this->playerWins = 2;
                        return true;
            }
        }
        else if (board[1] == board[5] && board[5] == board [9] )
        {
            if (board[1] == 'X')
           {
            this->playerWins = 1;
                        return true;
            }
            else
            {
            this->playerWins = 2;
                        return true;
            }
        }
        else if (board[3] == board[5] && board[5] == board [7] )
        {
            if (board[3] == 'X')
            {
            this->playerWins = 1;
                        return true;
            }
            else
            {
            this->playerWins = 2;
                        return true;
            }
        }
        else if (board[1] == board[4] && board[4] == board [7] )
        {
            if (board[1] == 'X')
            {
            this->playerWins = 1;
                        return true;
            }
            else
            {
            this->playerWins = 2;
                        return true;
            }
        }
        else if (board[2] == board[5] && board[5] == board [8] )
        {
            if (board[2] == 'X')
            {
            this->playerWins = 1;
                        return true;
            }
            else
            {
            this->playerWins = 2;
                        return true;
            }
        }
        else if (board[3] == board[6] && board[6] == board [9] )
        {
            if (board[3] == 'X')
            {
            this->playerWins = 1;
                        return true;
            }
            else
            {
            this->playerWins = 2;
                        return true;
            }
        }
                else if (board[1] != '1' && board[2] != '2' && board[3] != '3'
                    && board[4] != '4' && board[5] != '5' && board[6] != '6'
                  && board[7] != '7' && board[8] != '8' && board[9] != '9')
            {
            this->Draw = 3;
                        return true;
            }

                return false;
        }

};

int main() {

    tictactoe game;
    int playerTurn = 1;
    char playerMark, choice;
    int Move;
    char board[] = { '0','1', '2', '3', '4', '5', '6', '7', '8', '9' };
    do {
            	game.clearScreen();
		game.draw_board(board);

		cout << "TicTacToe" << endl;

		if (playerTurn == 1)
		{
			playerMark = 'X';
		}
		else
		{
			playerMark = 'O';
			{
                srand(time(0));
                Move = rand() % 9 + 1;
                cout << "Computer Move : "<< Move <<endl;
			}
		}
		  cout << "Player enter a number: " ;
     cin >> choice ;

    switch (choice)
		{
		case '1':
			if (playerTurn == 1)
			{
				board[1] = playerMark;
				playerTurn = 2;
			}
			else if (playerTurn == 2)
			{
				board[1] = playerMark;
				playerTurn = 1;
			}
			break;
		case '2':
			if (playerTurn == 1)
			{
				board[2] = playerMark;
				playerTurn = 2;
			}
			else if (playerTurn == 2)
			{
				board[2] = playerMark;
				playerTurn = 1;
			}
			break;
		case '3':
			if (playerTurn == 1)
			{
				board[3] = playerMark;
				playerTurn = 2;
			}
			else if (playerTurn == 2)
			{
				board[3] = playerMark;
				playerTurn = 1;
			}
			break;
		case '4':
			if (playerTurn == 1)
			{
				board[4] = playerMark;
				playerTurn = 2;
			}
			else if (playerTurn == 2)
			{
				board[4] = playerMark;
				playerTurn = 1;
			}
			break;
		case '5':
			if (playerTurn == 1)
			{
				board[5] = playerMark;
				playerTurn = 2;
			}
			else if (playerTurn == 2)
			{
				board[5] = playerMark;
				playerTurn = 1;
			}
			break;
		case '6':
			if (playerTurn == 1)
			{
				board[6] = playerMark;
				playerTurn = 2;
			}
			else if (playerTurn == 2)
			{
				board[6] = playerMark;
				playerTurn = 1;
			}
			break;
		case '7':
			if (playerTurn == 1)
			{
				board[7] = playerMark;
				playerTurn = 2;
			}
			else if (playerTurn == 2)
			{
				board[7] = playerMark;
				playerTurn = 1;
			}
			break;
		case '8':
			if (playerTurn == 1)
			{
				board[8] = playerMark;
				playerTurn = 2;
			}
			else if (playerTurn == 2)
			{
				board[8] = playerMark;
				playerTurn = 1;
			}
			break;
		case '9':
			if (playerTurn == 1)
			{
				board[9] = playerMark;
				playerTurn = 2;
			}
			else if (playerTurn == 2)
			{
				board[9] = playerMark;
				playerTurn = 1;
			}
			break;
		default:
			break;

        }


	} while (!game.isGameOver(board));
	game.clearScreen();
	game.draw_board(board);
	if (game.playerWins == 1)
	{
		cout << "Game Over! Player Wins!" << endl;
	}
	else if (game.playerWins == 2)
	{
		cout << "Game Over! Computer Wins!" << endl;
	}
	else if (game.Draw == 3)
    {
		cout << "Game Over! Draw!" << endl;
	}

	return 0;
}

[jonnin]

it looks like it needs
board[Move] = 'O'; //or playermark
where you do move= rand stuff for the computer...

or, choice = move and if its computer turn, do not cin choice? Something like that?

basically, you compute move but never used it.

[AbstractionAnon]

Line 13: Draw is never initialized. You should have a constructor to initialize your class.

Line 168: Why is board not an attribute of your game class?

Line 183: Do not call srand() multiple times (inside a loop). srand() sets the RNG to a particular starting point. Calling srand() repeatedly can cause the RNG to return the same random numbers. srand() should be called ONCE at the beginning of main().
http://www.cplusplus.com/reference/cstdlib/srand/

Lines 193-299: All your cases are nearly identical except for the index to the board. This is a good indication you need a function. BTW, choice should be an int, then you can use it directly as an index.

void do_turn(int indx)
    {
        if (playerTurn == 1)
        {
            board[indx] = playerMark;
            playerTurn = 2;
        }
        else if (playerTurn == 2)
        {
            board[indx] = playerMark;
            playerTurn = 1;
        }
    }

PLEASE ALWAYS USE CODE TAGS (the <> formatting button) when posting code.
It makes it easier to read your code and also easier to respond to your post.
http://www.cplusplus.com/articles/jEywvCM9/
Hint: You can edit your post, highlight your code and press the <> formatting button.

[NAYR453]

Thanks for the help I have edited and used the formatting button, however I still can't seem to get the random move to actually display on the board.

[dhayden]

It looks like you still haven't taken jonnin's advice. Reread his comment.

Also, see my code and AbstractAnon's bug fix in this post:
http://www.cplusplus.com/forum/beginner/247384/