i want to compare two file and find the same strings

[odardes]

hello guys,
I just want to compare two files. Then i want to display the same strings on the screen. I have strings in these files. Each strings are on the different lines. I wrote that code but it didnt work true. Where is my wrong can you help me?

int main()
{

	string myArray1[1000];
	int loop1 = 0;
	string line1;
	ifstream myfile1("davetlilistesi.txt");
	if (myfile1.is_open())
	{
		while (!myfile1.eof()) {
			getline(myfile1, line1);
			myArray1[loop1] = line1;
			loop1++;
		}
		myfile1.close();
	}
	else
		cout << "Unable to open file"<<endl;


	string myArray2[1000];
	int loop2 = 0;
	string line2;
	ifstream myfile2("davetlierkek.txt");
	if (myfile2.is_open())
	{
		while (!myfile2.eof()) {
			getline(myfile2, line2);
			myArray2[loop2] = line2;
			loop2++;
		}
		myfile2.close();
	}
	else
		cout << "Unable to open file" << endl;


	string myArray3[1000];
	int matches = 0;
	for (int i = 0; i < 1000; i++) {
		for (int j = 0; j < 1000; j++) {
			if (myArray1[i] == myArray2[j]) {
				cout << "Match " << ++matches << ": " << myArray1[i] << endl;
				myArray3[i] = myArray1[i];
			}
		}

	}

	
	string line3;
	ofstream myfile3("ortaklar.txt");
	if (myfile3.is_open())
	{
		for (int count = 0; count < 1000; count++) {
			myfile3 << myArray3[count] << " ";
		}
		myfile3.close();
	}
	else
		cout << "file is not open" << endl;


	cin.get();
	return 0;
}

[jonnin]

what did not work?
you did not do anything about case, is the case in both files identical for all words? Remember cat and Cat won't match...!

why not use vectors of strings instead of fixed sized array?

there are far better ways to do this than brute force, but we can skip that for now.

[salem c]

Please edit your post to add [code][/code] tags (the <> format on the right) around your code.

[dhayden]

At line 43 you're using myArray1's index to insert into myArray3. So if lines 1,4 and 544 of the first file match, then you'll put the match strings in positions 1, 4, and 544 of myArray3. I suspect that isn't what you want. To fix this, use a separate variable for the index into myArray3.