Unexpected result, Cant find the error

[chris213]

int main()
{
double rainfall[12];
double total = 0;
double avg = 0;
double maxRain = 0;
double minRain = 0;
double tempRain = 0;


for (int i = 0; i < 12; i++) {
cout << "Please enter rainfall for month " << i + 1 << ": " << endl;
cin >> rainfall[i];
total += rainfall[i];

}


avg = total / 12;

maxRain = rainfall[0];
minRain = rainfall[0];

for (int i = 1; i <= 12; i++) {
tempRain = rainfall[i];
if (tempRain < minRain)
minRain = tempRain;
if (tempRain > maxRain)
maxRain = tempRain;
}
cout << total << endl;
cout << avg << endl;

cout << maxRain << endl;
cout << minRain << endl;
}





The total prints fine, the average prints fine, the maximum prints fine, what am I missing for the minimum to not be printing properly?

[JLBorges]

The second for loop:

// for (int i = 1; i <= 12; i++) {
for (int i = 1; i < 12; i++) {

#include <iostream>

int main()
{
    const int NMONTHS = 12 ;
    double rainfall[NMONTHS] {} ;
    double total = 0;

    for( int i = 0; i < NMONTHS ; ++i )
    {
        std::cout << "Please enter rainfall for month " << i+1 << ": " ;
        std::cin >> rainfall[i];
        total += rainfall[i];
    }

    const double avg = total / 12;

    double maxRain = rainfall[0];
    double minRain = rainfall[0];

    for( int i = 0; i < NMONTHS ; ++i )
    {
        if( rainfall[i] < minRain ) minRain = rainfall[i] ;
        if( rainfall[i] > maxRain ) maxRain = rainfall[i] ;
    }

    std::cout << "  total: " << total << '\n'
              << "average: " << avg << '\n'
              << "minimum: " << minRain << '\n'
              << "maximum: " << maxRain << '\n' ;
}

[TheIdeasMan]

Make your second for loop just like the first one:

for (int i = 0; i < 12; i++) {
tempRain = rainfall[i];

Arrays start at 0.

Please always use code tags: http://www.cplusplus.com/articles/z13hAqkS/ and post code that we can compile.

l like to always put digits before and after the decimal point for doubles:

double total = 0.0;
double avg = 0.0;
double maxRain = 0.0;
double minRain = 0.0;
double tempRain = 0.0;
// ...
avg = total / 12.0;

It sounds pedantic, but it will save you trouble one day.

Instead of the magic value of 12 everywhere make it a const variable, and use that:

constexpr unsigned int Size =12; // could use const instead of constexpr
double rainfall[Size];

but then be sure to do this:

avg = total / static_cast<double>(Size);

I made Size an unsigned int because it shouldn't be negative, but it is technically better to make it std::size_t, as this is what is used for the size of containers in C++.

Good Luck !!

[chris213]

Thank you guys!