C++

[Coast1997]

Ive got this code but it won't run and i can't find any more errors

int main(){
int *p, i, a[10];
p=a;
for (i=0; i<10; i++)
scanf("%d", p++);
printf("\n");
for (i=0; i<10; i++)
printf("a[%d]=%d\n", i, *p++);
return 0;
}

[N8RzwA7f]

the formatting is terrible, but my best guess is the line with *p++ .
but i consider myself a beginner still in c++ so don't take my word for it.
maybe add parenthesis around it like so: (*p)++;

[mbozzi]

int main(){
  int *p, i, a[10];
  p=a;
  for (i=0; i<10; i++)
    scanf("%d", p++);
  printf("\n");

  p = a; // make p point to the beginning of the array
  for (i=0; i<10; i++)
    printf("a[%d]=%d\n", i, *(p++));
  return 0;
}

Note:
The topic of this thread is "C++", but this is merely C.

[Thomas1965]

...but this is merely C.

If a C++ compiler compiles it, it is also a C++ program.

[Peter87]

Pointers are error prone. You might want to consider using the subscript operator instead.

#include <stdio.h>

int main(){
	int i, a[10];
	for (i=0; i<10; i++)
		scanf("%d", &a[i]);
	printf("\n");
	for (i=0; i<10; i++)
		printf("a[%d]=%d\n", i, a[i]);
	return 0;
}

[Thomas1965]

You need to reset your pointer to the beginning of the array.
Also it's better to use constants instead of magic numbers.

int main()
{
  const int NUM_ELEMS = 10 // #define NUM_ELEMS 10

  int *p, i, a[NUM_ELEMS];
  p = a; // same as p = &a[0]

  for (i=0; i < NUM_ELEMS; i++)
    scanf("%d", p++);

  printf("\n");
  
  // Reset p to the beginning
  p = a;
   
  for (i=0; i < NUM_ELEMS; i++)
    printf("a[%d]=%d\n", i, *p++);


  getch();
  return EXIT_SUCCESS;
}