- Forum
- General C++ Programming
- Vector Inventory problem
Vector Inventory problem
i have a vector based inventory implemented pretty well; however i keep running into a pretty large problem. when i click an item depending on where it is in the vector i get an access violation in the vector range and the game crashes. here is how my inventory works and the basic code for it;
|
|
Last edited on
Line 20,54,59: You can't compare char arrays that way. You're comparing addresses, not strings. Use std::string or if you insist on using C rather than C++, use strcmp.
Line 27: You can't copy char arrays that way. Use std::string or if you insist on using C rather than C++, use strcpy.
Line 59: I don't see where you've initialized items[i]->type. Reference to an uninitialized pointer is going to cause an access violation. Ditto remarks regarding std::string vs. char *.
Line 27: You can't copy char arrays that way. Use std::string or if you insist on using C rather than C++, use strcpy.
Line 59: I don't see where you've initialized items[i]->type. Reference to an uninitialized pointer is going to cause an access violation. Ditto remarks regarding std::string vs. char *.
Oh okay I didn't know that thank you that's probably part of the problem. Also in my actual class the addItem() initializes all of the data members in Item. I keep getting out of range errors would that be from comparing char arrays to strings?
Im going to go ahead and post all of the code from the inventory class. I changed the comparison to strcmp and used strcpy() instead of assigning a string to a char array. i am still getting the error. can someone please help me idk what i am doing wrong.
its very strange almost all of the items work, but sometimes i get this error...
from the vector class
usually its when i click the last item in the inventory though but not always.
|
|
its very strange almost all of the items work, but sometimes i get this error...
from the vector class
|
|
usually its when i click the last item in the inventory though but not always.
Line 60,126,133: You're still comparing pointers, not the contents of the char array.
If you're going to be writing C++, use the C++ idiom for strings (std::string) rather than C strings. They're easier and safer.
If you're going to be writing C++, use the C++ idiom for strings (std::string) rather than C strings. They're easier and safer.
On a related note why does your class have a vector<Item*> instead of a vector<Item>.
I see where you allocate memory with new for this vector, but I don't see where you're deallocating the memory with delete. Looks like a fairly big memory leak.
I see where you allocate memory with new for this vector, but I don't see where you're deallocating the memory with delete. Looks like a fairly big memory leak.
On line 293 you erase an item in the vector. You then continue on to use the same index. If that item is the last item in the array, this is undefined behavior.
If it isn't, you still have a pretty large hole in your logic. It is possible to erase 3 items from your inventory for each iteration of the loop if the order of the items is amenable. If you erase an item, decrement i and continue. Also, use if/else where appropriate.
If it isn't, you still have a pretty large hole in your logic. It is possible to erase 3 items from your inventory for each iteration of the loop if the order of the items is amenable. If you erase an item, decrement i and continue. Also, use if/else where appropriate.
Last edited on
Thank you cire. Now that you pointed that out it makes complete since for why its behaving the way it is. I am changing the struct Item to a class to gain more control over the items in the inventory. I will post the working code to see if you guys have any suggestions. This is such a great community for programmers. I appreciate all of your guys help.
Topic archived. No new replies allowed.