Count Rows and Columns from file

[darklord1]

So I made a text file which goes like this
word word word word
word word word word word word word
word word word word word
word word word word

(word is actually word I just didnt type them)

Now i figured out how to get the rows to work

#include <iostream>
#include <fstream>
#include <istream>
#include <stdio.h>

int main()
{
    FILE* fp;
    int countLines = 1;
    int i;


    fp = fopen("filename.txt", "r");
    if (fp == NULL)
    {
        printf("We can't open the file.");
        fclose(fp);
        return 1;
    }
    else
    {
        while((i=fgetc(fp))!=EOF)
        {
            if (i == '\n')
                countLines++;
        }

        printf(">Numrows filename.txt: %d\n",countLines);
    }
        return 0;
}

I cant figure out column to work...
Any help?? Is it the same method cause im getting confused a lot!

[dhayden]

If the column are separated by single spaces then something like this will count the columns in each line.

        int columns = 0;
        while((i=fgetc(fp))!=EOF)
        {
            if (i == ' ') {
                ++columns;
            } else if (i == '\n') {
                countLines++;
                cout << "line " << countLines " has " << columns << " columns.\n";
                columns = 0;  // reset for next line.
        }

[darklord1]

When I add it to my code and try to compile it gives me error...

	#include <iostream>
	#include <fstream>
	#include <istream>
	#include <stdio.h>
	int main()
	{
		FILE* fp;
		int countLines = 1;
		int i;
		int columns = 0;
		 fp = fopen("filename.txt", "r");
		if (fp == NULL)
		{
			printf("We can't open the file.");
			fclose(fp);
			return 1;
		}
		else
		{
			while((i=fgetc(fp))!=EOF)
			{
				if (i == '\n')
					countLines++;
			}
			printf(">Numrows filename.txt: %d\n", countLines);
		}
			
			while((i=fgetc(fp))!=EOF)
			{
				if (i == ' ')
					++columns;
		    }
				else if (i == '\n')
				{
					countLines++;
					cout << "line " << countLines <<" has " << columns << " columns.\n";
					columns = 0;  // reset for next line.
				}
		
			return 0;
	}

[dhayden]

You need a { on line 30. There may be other errors, that was off the top of my head. You should be able to figure it out from my example though.

[darklord1]

So I added your code in a new file to fix error....


now I get this

work.cpp:24:4: error: ‘cout’ was not declared in this scope
    cout << "line " << countLines << " has " << columns << " columns.\n";
    ^

This was the code

#include <iostream>
#include <fstream>
#include <istream>
#include <stdio.h>

int main() 
{
FILE* fp;
int countLines = 1;
int i;
int columns = 0;			
fp = fopen("filename.txt", "r");	
		if (i == ' ')
		{
			++columns;
			fclose(fp);
	    }
		else if (i == '\n')
		{	
		while((i=fgetc(fp))!=EOF)
	{
			countLines++;
			cout << "line " << countLines << " has " << columns << " columns.\n";
			columns = 0;  // reset for next line.		
	}
	    }		return 0;
}

[jasonwynn10]

The cpp.sh shell says that this works just fine.

	#include <iostream>
	#include <fstream>
	#include <istream>
	#include <stdio.h>
	using namespace std;
	int main()
	{
		FILE* fp;
		int countLines = 1;
		int i;
		int columns = 0;
		 fp = fopen("filename.txt", "r");
		if (fp == NULL)
		{
			printf("We can't open the file.");
			fclose(fp);
			return 1;
		}
		else
		{
			while((i=fgetc(fp))!=EOF)
			{
				if (i == '\n')
					countLines++;
			}
			printf(">Numrows filename.txt: %d\n", countLines);
		}
while((i=fgetc(fp))!=EOF){
if (i == ' '){
	++columns;
}else if (i == '\n')
{
	countLines++;
	cout << "line " << countLines <<" has " << columns << " columns.\n";
	columns = 0;  // reset for next line.
}
		
			return 0;
	}}

[darklord1]

This is just showing me number of rows..which is 4

[keskiverto]

Why do you include fstream and istream, when you don't use them at all?
Alternatively, why do you use stdio, when you could use streams?


The using namespace std; is not recommended. The library writers have worked hard to get the library within namespace, for a good reason.

If you refer to cout only once, you can easily write std::cout.
If you refer multiple times, you can add using std::cout;

[darklord1]

Isnt fstream used for adding to the text file??
Sry not sure bout istream tho

[keskiverto]

http://www.cplusplus.com/doc/tutorial/files/

[giblit]

darklord1 wrote:

Isnt fstream used for adding to the text file??
Sry not sure bout istream tho

fstream is for input and output. fstream = File Stream. ifstream = Input File Stream and is well for input only. ofstream = Output File Stream and is for output only.

[darklord1]

Hmmm I see

[keskiverto]

Some more hmmm for you:

#include <iostream>
#include <fstream>
#include <string>
#include <iomanip>
#include <algorithm>

int main( int argc, char *argv[] ) 
{
  if ( 1 < argc ) {
    std::size_t n {0};
    std::string line;
    std::ifstream fin( argv[1] );
    while ( std::getline( fin, line ) )
    {
      std::cout << std::setw(8) << ++n
        << std::setw(8) << std::count( std::begin(line), std::end(line), ' ' )
        << '\n';
    }
  }
  return 0;
}