expected primary-expression before ‘)’ token

[p33n kenan]

Hi,

I have a lot of trobble with this peace of code, what did I do wrong?
The function is ment to write an array of 100 structures to a file called" data.txt"
code:

template<class It>
int safe(It begin, It end){
	fstream out;
	out.open("data.txt", ios::out);
	for (It = begin; It != end; ++It){
		out << (*It).name << " \n";         
		out << (*It).surname << " \n";
		out << (*It).games << " " << (*It).won << " " << (*It).same << " " << 
		(*It).lost << " "<< (*It).money << "\n";
		
	}
	out.close();
	return 0;

it gives errors like this:

structure.cpp:180: error: expected unqualified-id before ‘=’ token

structure.cpp:180: error: expected primary-expression before ‘!=’ token

structure.cpp:183: error: expected primary-expression before ‘)’ token

Here is the total code:

#include <iostream>
#include <cstdlib>
#include <string.h>
#include <fstream>
#include <limits>
#include <string>
#include <array>

using namespace std;

struct RecAbbo{
		std::string name;
		std::string surname; 
		int games;
		int won;
		int same;
		int lost;
		int money;
	}Abbo[100];
	
template<class It>
	
void addp();
void sort();
void sear();
void stat();
void game();
void play(int pl1,int pl2);
void menu();

template<class It>
int safe(It begin, It end);
template<class It>
int writetostruct(It begin, It end);

int main(){
	fstream in,out;
	in.open("data.txt", ios::in);
	out.open("data.txt", ios::out);
	menu();
	in.close();
	out.close();
	}

void menu(){
	bool exit=false;
	int choise;
	cout<<"welcome \n";
	while (exit == false){
		cout<<"==================================================== \n";
		cout<<"please choose \n";
		cout<<"1. add person \n";
		cout<<"2. sort all accounts\n";
		cout<<"3. search a certain person \n";
		cout<<"4. see the avarage games and statics \n";
		cout<<"5. create random game \n";
		cout<<"0. exit program \n";
		cout<<"==================================================== \n";
		cin>>choise;
		cout<<"==================================================== \n";
		switch (choise){
			case 1:
				addp();
				break;
			case 2: 
				sort();
				break;
			case 3: 
				sear();
				break;
			case 4: 
				stat();
				break;
			case 5: 
				game();
				break;
			case 0: 
				exit=true;
				break;
			default: 
				cout<<"please choose one of the numbers given \n";
				break;
			}
		}
	}
void addp(){
	
	int i,s;
	while(Abbo[i].name.empty() != 0 )
		i++;
	cout<<"name: ";
	cin>>Abbo[i].name;
	cout<<"surname: ";
	cin>>Abbo[i].surname;
	Abbo[i].games = 0;
	Abbo[i].won = 0;
	Abbo[i].same = 0;
	Abbo[i].lost = 0;
	Abbo[i].money = 0;
	s = safe(Abbo[0],Abbo[100]);
}
	
void sort(){
	
}

void sear(){
	
}

void stat(){
	int avaragew,avarages,avaragel,avarageg,i=0;
	while (i < 0){
		avaragew = avaragew + Abbo[i].won;
		i++;
	}
	i = 0;
	while (i < 0){
		avarages = avarages + Abbo[i].same;
		i++;
	}
	i = 0;
	while (i < 0){
		avaragel = avaragel + Abbo[i].lost;
		i++;
	}
	i = 0;
	while (i < 0){
		avarageg = avarageg + Abbo[i].games;
		i++;
	}
	avaragew = avaragew/100;
	avarages = avarages/100;
	avaragel = avaragel/100;

	i = 0;
	cout<<"avarage games won				:"<<avaragew<<"%\n";
	cout<<"avarage games with same points			:"<<avarages<<"%\n";
	cout<<"avarage games lost				:"<<avaragel<<"%\n";;
	cout<<"total games played				:"<<avarageg<<" games \n";
}

void game(){
	char name1[20],name2[20],surname1[20],surname2[20];
	int i1, i2, i = 0;
	bool check = false, check2 = false ;
	while (check == false){	
		i1 = rand() % 100;
		i2 = rand() % 100;
		while (check2 == false) 
			if (i1 == i2){
				i2 = (i2 + rand() % 100) - 100;
			} else {
				if (Abbo[i1].name.empty() == 0 || Abbo[i2].name.empty() == 0){
					check2 = false;
				} else {
					check2 = true;
					check = true;
				}
			}
		}
	while (i < 20){
			name1[i] = Abbo[i1].name[i];
			name2[i] = Abbo[i2].name[i];
			surname1[i] = Abbo[i1].surname[i];
			surname2[i] = Abbo[i2].surname[i];
			
			i++;
	}
	Abbo[i1].games++;
	Abbo[i2].games++;
	cout<<"       player 1:     player 2: \n";
	cout<<"game: "<<name1<<surname1<<" VS :"<<name2<<surname2<<endl;
	play(i1,i2);
}
template<class It>
int safe(It begin, It end){
	fstream out;
	out.open("data.txt", ios::out);
	for (It = begin; It != end; ++It){
		out << (*It).name << " \n";         
		out << (*It).surname << " \n";
		out << (*It).games << " " << (*It).won << " " << (*It).same << " " << 
		(*It).lost << " "<< (*It).money << "\n";
		
	}
	out.close();
	return 0;
}
template<class It>
int writetostruct(It begin, It end){
	fstream in;
	in.open("data.txt", ios::in);
	for (int i=0;i<100; i++){
		in >> std::skipws;  
		getline( in, Abbo[i].surname); 
		getline( in, Abbo[i].name);
		in >> Abbo[i].games >> Abbo[i].won >> Abbo[i].same >> 
        Abbo[i].lost >> Abbo[i].money;
    }
    in.close();
    return 0;
}

void play(int pl1, int pl2){
int i, p1,p2,mode,p1money = 50, p2money = 50;
	bool x = true,z = true;
	while (x){
	cout<<"for easy mode press 1 "<<endl;
	cout<<"for normal mode press 2 "<<endl;
	cout<<"for hard mode press 3 "<<endl;
	cout<<"for beast mode press 4 "<<endl;
	cout<<"choise: ";
	cin>>mode;
	switch (mode)
	{
		case 1:
			i = rand() %100;
			cout<<"number between 1 and 100"<<endl;
			x=false;
			break;
		case 2:
			i = rand() %500;
			cout<<"number between 1 and 500"<<endl;
			x=false;
			break;
		case 3:
			i = rand() %2500;
			cout<<"number between 1 and 2500"<<endl;
			x=false;
			break;
		case 4:
			i = rand() %10000;
			cout<<"number between 1 and 10000"<<endl;
			x=false;
			break;
		default:
			cout<<"please choose again"<<endl;
			break;
	}
	while(z){
		cout<<"player 1: ";
		cin>>p1;
		if(p1 < i)
		cout<<"number is higher"<<endl;
		if(p1 > i)
		cout<<"number is lower"<<endl;
		cout<<"player 2: ";
		cin>>p2;
		if(p2 < i)
		cout<<"number is higher"<<endl;
		if(p2 > i)
		cout<<"number is lower"<<endl;
		if (p1 == i){
			cout<<"player 1 has won!!"<<endl;
			Abbo[pl1].won++;
			Abbo[pl2].lost++;
			Abbo[pl1].money = Abbo[pl1].money + p1money;
			z = false;
			} else {
			p1money=p1money-5;
		}
		if (p2 == i){
			cout<<"player 2 has won!!"<<endl;
			Abbo[pl2].won++;
			Abbo[pl1].lost++;
			Abbo[pl2].money = Abbo[pl2].money + p2money;
			z = false;
			} else {
			p2money=p2money-5;
		}
		if (p1money == 0 || p2money == 0){
			Abbo[pl1].same++;
			Abbo[pl2].same++;	
			}
		}
	}
}	

[keskiverto]

Lets start to write a non-template overload, where double replaces the class It:

int safe(double begin, double end){
	fstream out;
	out.open("data.txt", ios::out);
	for (double = begin; double != end; ++double){

error: expected unqualified-id before ‘=’ token

Does this illustrate the problem?

[p33n kenan]

i changed it as you said but:

structure.cpp:171: error: expected unqualified-id before ‘=’ token
structure.cpp:171: error: expected primary-expression before ‘double’
structure.cpp:171: error: expected ‘;’ before ‘double’

these are the errors I get

[MiiNiPaa]

p33n kenan wrote:

i changed it as you said but:

He did not said you to change anything. He merely provided a boiled-down sample of your code making it easy to notice the mistake.

How do you think would double = begin work?

[p33n kenan]

I'm sorry this stuff is out of my reach in c++ ,how does it work?

[MiiNiPaa]

how does it work?

It does not work. But this is essentually what you are trying to do in your functions.
int safe(It begin, It end){ Here we can see that It is a type.
for (It = begin; It != end; ++It){ Here you trying to assign a value to type.
Example: double is a type, 5 is a value. You a trying to do double = 5; instead of double var = 5;

[p33n kenan]

But it does not work, how can I make it work (compile)

[MiiNiPaa]

how can I make it work

Do not assign value to type. Create a variable of type It and then work with it.

int x; //←That is how you declare a variable
//So you need to do:
It iterator; 

[p33n kenan]

I don't have my linux machine right now so have to do with online compiling :(

Is this what you mean:
http://coliru.stacked-crooked.com/a/1a7d784e0538bedf
If so, I still get a lot of errors as you can see in the link above

[MiiNiPaa]

int safe(double begin, double end){ Why you did that? It was an example of what happens after template substitution. Nobody told you to make those changes

And you still use type where variable is expected.

No offence, but I think you should start learning again before you start writing code. At least wait untill you will know basics such as difference between type and variable.