Simple tic tac toe

[danielmccarthy]

Hey, I got bored so wrote a simple tic tac toe game, feedback will be appreciated

#include <iostream>
#include <stdio.h>
#include <windows.h>

using namespace std;

enum TILE_OWNERS
{
    NO_OWNER = 0,
    X = 1,
    O = 2
};

class Tile
{
 public:
     Tile()
     {
         owner = NO_OWNER;
     }
     char getOwner()
     {
         return owner;
     }

     void setOwner(char _owner)
     {
         owner = _owner;
     }
 private:
        char owner;
};
class Board
{
private:
    Tile tile[9];
public:
    void Display()
    {
        for (int y = 0; y < 3; y++)
        {
            for (int x = 0; x < 3; x++)
            {
                if (getTileOwner(x, y) == NO_OWNER)
                    printf("#");
                else if(getTileOwner(x, y) == X)
                    printf("X");
                else if(getTileOwner(x, y) == O)
                    printf("O");
            }
            printf("\n");
        }
    }

    void setTile(char tileID, char owner)
    {
        tile[tileID-1].setOwner(owner);
    }

    char getTileOwner(char x, char y)
    {
        return tile[(y*3)+x].getOwner();
    }

    char getTileOwner(int tileID)
    {
        return tile[tileID].getOwner();
    }

    bool tileTaken(int tileID)
    {
        if (tile[tileID-1].getOwner() != NO_OWNER)
            return true;
        return false;
    }
};

class Game
{
 public:
    Board* board;
    bool isPlaying;

    Game()
    {
        isPlaying = false;
        curTurn = X;
    }

    virtual ~Game()
    {
        stop();
    }
    void start()
    {
        board = new Board();
        isPlaying = true;
    }

    void stop()
    {
        if (board != 0)
            delete board;
        board = 0;
        isPlaying = false;
    }

    char getPlayerFromCurTurn()
    {
        return curTurn;
    }

    bool hasBeenWon()
    {
        if (
           (board->getTileOwner(0) == curTurn && board->getTileOwner(1) == curTurn
            && board->getTileOwner(2) == curTurn) ||
            (board->getTileOwner(3) == curTurn && board->getTileOwner(4) == curTurn
            && board->getTileOwner(5) == curTurn) ||
            (board->getTileOwner(6) == curTurn && board->getTileOwner(7) == curTurn
            && board->getTileOwner(8) == curTurn) ||
            (board->getTileOwner(0) == curTurn && board->getTileOwner(3) == curTurn
            && board->getTileOwner(6) == curTurn) ||
            (board->getTileOwner(1) == curTurn && board->getTileOwner(4) == curTurn
            && board->getTileOwner(7) == curTurn) ||
            (board->getTileOwner(2) == curTurn && board->getTileOwner(5) == curTurn
            && board->getTileOwner(8) == curTurn) ||
            (board->getTileOwner(1) == curTurn && board->getTileOwner(4) == curTurn
            && board->getTileOwner(7) == curTurn) ||
            (board->getTileOwner(0) == curTurn && board->getTileOwner(4) == curTurn
            && board->getTileOwner(8) == curTurn) ||
            (board->getTileOwner(2) == curTurn && board->getTileOwner(4) == curTurn
            && board->getTileOwner(6) == curTurn)
           )
            return true;
        return false;
    }

    void endTurn()
    {
        if (curTurn == X)
            curTurn = O;
            else
                curTurn = X;
    }
 private:
    char curTurn;

};

Game game;

void checkWon()
{
    if (game.hasBeenWon())
    {
        cout << "Player: " << (int)game.getPlayerFromCurTurn() << " has won!" << endl;
        game.board->Display();
        game.isPlaying = false;
    }
}
int main()
{
    game.start();
    while(game.isPlaying)
    {
        int input;
        char curPlayer = game.getPlayerFromCurTurn();

        system("cls");
        cout << "Welcome to tic tac toe!" << endl;
        cout << "Player: " << (int)curPlayer << "s turn" << endl;
        game.board->Display();

        bool stillPlayersTurn;
        do
        {
            stillPlayersTurn = false;
            cout << "Enter a position [1-9]: ";
            scanf("%i", &input);
            if (input < 1 || input > 9)
            {
                cout << "Their are only tiles between [1-9] in tic tac toe..." << endl;
                stillPlayersTurn = true;
                continue;
            }
            if (!game.board->tileTaken(input))
            {
                game.board->setTile(input, curPlayer);
                checkWon();
                game.endTurn();
            }
            else
            {
                cout << "This tile is already taken try another.." << endl;
                stillPlayersTurn = true;
            }
        } while(stillPlayersTurn);
    }
    game.stop();
    system("PAUSE");
    return 0;
}

[AbstractionAnon]

1) In several places you mix the TILE_OWNERS type with char variables (owner, cur_turn). X, O and NO_OWNER are binary values, but you assign and use these as char values. I would suggest changing the type of owner and cur_turn to TILE_OWNERS.

2) The logic at lines 44-49 should be moved to a Tile->Display method. Board should not know or care how Tiles are represented.

3) Why is Board allocated dynamically? There is no need to do this.

4) In Board, consider replacing getTileOwner by overloading the [] operator. This will make your code much cleaner by allowing you to refer to board[i].

5) line 157, 172: Why are you casting to an int?

6) Line 180: Whay are you using scanf instead of cin >> input;

7) You're mixing printf and cout. That will work, but if you're going to be writing in C++, then you should use cout and not printf.

8) Line 153: Why is checkWon not a method of Game?

9) Why are board and isplaying public inside Game?