can't enter phrases in loop

[RLC]

getline is not readable after first time through loop. It skips that line and goes to Do you want stop entry? line.

I would appreciate any help that I can get

#include<iostream>
#include<string>
#include<cstring>
#include<cctype>

using namespace std;

void upr(const string& str);

int main()
{
	string strinpt;
	char quit = 'Q';
	char ch = ' ';
	while (quit != 'q')
	{
		cout << "Enter phrase in lower case to be turned into upper case: " << "\n";
		getline(cin,strinpt);
		upr(strinpt);
		cout << "Do you want stop entry? " << "\n";
		cin >> quit;
	}
	return 0;
}
void upr(const string& str)
{
	for (const char* ptr = str.c_str(); *ptr; ++ptr)
		cout << (char) toupper(*ptr);

	cout << endl;
}

[Dy7SLyTq]

try writing cin.flush() at the beginning of the loop

[RLC]

It says:Error 1 error C2039: 'flush' : is not a member of 'std::basic_istream<char,std::char_traits<char>>' 19 1

[andywestken]

Use

cin.ignore(1024, '\n');

just after the cin >> quit; to eat up the rest of the line, including the '\n'.

When you mix cin with getline, you've got to make sure you don't leave '\n's sitting in the stream. Otherwise getline will just get the end of the line cin nibbled at rather than waiting for a fresh, new one.

Andy

[JLBorges]

// ...               
cout << "Enter phrase in lower case to be turned into upper case: " << "\n";
// getline(cin,strinpt);
getline( std::cin >> std::ws, strinpt ) ; // http://en.cppreference.com/w/cpp/io/manip/ws
// ... 

[RLC]

Andy,
Sounds logical, but still doesn't work. It causes a wait in the program for more input.

Bob

[andywestken]

Well, it works for me with GCC and VC++

???

Andy

Enter phrase in lower case to be turned into upper case:
hello
HELLO
Do you want stop entry?
n
Enter phrase in lower case to be turned into upper case:
goodbye
GOODBYE
Do you want stop entry?
n
Enter phrase in lower case to be turned into upper case:
again
AGAIN
Do you want stop entry?
q

#include<iostream>
#include<string>
#include<cstring>
#include<cctype>

using namespace std;

void upr(const string& str);

int main()
{
	string strinpt;
	char quit = 'Q';
	char ch = ' ';
	while (quit != 'q')
	{
		cout << "Enter phrase in lower case to be turned into upper case: " << "\n";
		getline(cin,strinpt);
		upr(strinpt);
		cout << "Do you want stop entry? " << "\n";
		cin >> quit;
		cin.ignore(1024, '\n');
	}
	return 0;
}

void upr(const string& str)
{
	for (const char* ptr = str.c_str(); *ptr; ++ptr)
		cout << (char) toupper(*ptr);

	cout << endl;
}

[Veltas]

Weird, according to http://www.cplusplus.com/reference/string/string/getline/ you will just append the characters to the end of a string with getline, although it looks like it also clears the string first from the above output.

Maybe use numeric_limits<streamsize>::max() rather than 1024 in the above code?

[RLC]

Hi Jl,
That did it. Thanks for the help.
Bob

[RLC]

Hi Andy,
I modified the program again and it now works. The placement of the line of code is different than were I had it. It was after the cin >> read. I placed it at to top of the code before the getline. That may have made a difference. Thanks for the help.

Bob