Template overloading

[noisycoder]

Hi!
I'm trying to overload my constructor and it's showing an error saying cannot overload.

this is my header file and the code was working fine before i tried overloading the constructor

#ifndef CXMLString_H
#define CXMLString_H

#include <iostream>
#include <sstream>

using namespace std;

namespace CXML
{

enum XMLParseResult_t
{
	XMLFULLLINE,
	XMLOPENTAG,
	XMLCLOSETAG,
	XMLERRORSYNTAX,
	XMLERRORTAGMISMATCH,
	_XMLMAX
};

template<class T>
class CXMLString: public string
{
private:

	bool extractTag(CXMLString& tag, CXMLString& remainder);
	void trim(string const& temp_compare);
	bool contains(string const sub);
	static string m_error[_XMLMAX];

	/** @link dependency */
	/*# XMLParseResult_t lnkXMLParseResult_t; */
public:
	CXMLString(bool content, string tag = "")
	{
		stringstream mystream;
		if (content == true)
			mystream << "<" << tag << ">" << "true" << "</" << tag << ">";
		else
			mystream << "<" << tag << ">" << "true" << "</" << tag << ">";
		this->assign(mystream.str());
	}

	CXMLString(T content, string tag = "")
	{
		stringstream mystream;
		if (tag.length())
			mystream << "<" << tag << ">" << content << "</" << tag << ">";
		else
			mystream << content;
		//str() is used for get/set with the associated string
		string temp = mystream.str();
		this->assign(mystream.str());
		//*this = "<" + tag + ">" + temp + "</" + tag + ">";
	}

	static string error(XMLParseResult_t);
	XMLParseResult_t parse(string& tag, string& content);
};
}

#endif

any help or suggestions :(

[JLBorges]

If you use std::boolalpha in CXMLString(T content, string tag = "")

mystream << "<" << tag << ">" << std::boolalpha << content

the bool overload would not be required at all, would it?

[noisycoder]

wasn't aware of something as boolalpha. Tried it out and it works! Thanks.

[JLBorges]

This is not a good idea: class CXMLString: public std::string

Either use containment or if you must inherit, inherit privately.

With public inheritance:

#include <string>
#include <iostream>
#include <sstream>

void foo( std::string& xml_str ) { xml_str = "this is not an xml string" ; }

template<class T> class CXMLString : public std::string
{
    public: CXMLString( T content, std::string tag = "" )
    {
        std::ostringstream stm ;
        stm << "<" << tag << ">" << content << "</" << tag << ">" ;
        assign( stm.str() ) ;
    }
};

int main()
{
    CXMLString<int> xml_str( 23, "value" ) ;
    std::cout << xml_str << '\n' ;
    foo( xml_str ) ;
    std::cout << xml_str << '\n' ;
}