Array that automatically gets size?

[Ch1156]

Ok so i keep adding stuff to my array but i want to know is there a way that the array can automatically get its size without me having to change the number in the brackets? in a catch statement you can put (...) to get any type of data type, is something like that possible for an array?

[MrHutch]

Not sure I understand your question fully.

If you want a dynamically sized array, why don't you use a STL vector?

[vlad from moscow]

Such array is called std::vector.:)

[Ch1156]

What i was saying is, is there a way i can add elements to the array without having to put a number of how many elements ther is.

[Ch1156]

ogh a vector can do that?

[Ch1156]

I forget, do i need to put something on the end of my array? something like '0\' or something like that to specify its the end or something?

[MrHutch]

No, you're thinking of old C strings which were, in essence, null-terminated character arrays.

You can add to a vector by pushing to it and return the size using the size() member function.

[Ch1156]

Ah i see, ok well i'll stick with arrays. But i have a problem with my code:

I have a while loop that is supposed to read the contents of a text file and load it itno the game so it can be read later (its a list of prisoners) but when i pick option 2 the program just stops and doesnt do anything else. If i comment out the while loop:

 while(!v.names.eof())
        {
            getline(names, v.fileStr);
        }

Then pick option 2 it loads everything else just fine so its that part thats causing problems, what is doing that?

#include <iostream>
#include <string>
#include <fstream>
#include <ctime>
#include <cstdlib>
#include <vector>

using namespace std;

struct Vars
{
    void Game();
    string randNames();
    string randCrimes();

    long int money;
    int prisoners;
    string playerName;
    string prisonName;
    ofstream names; // Saves the prisoners list
    ofstream file; // Saves the player info
    string fileStr;
};

int main()
{
    int choice;
    srand(time(0x0));

    Vars v;

    cout << "1) New" << endl;
    cout << "2) Load\n" << endl;
    cin >> choice;

    if(choice == 1)
    {
        v.file.open("prison.txt");

        cin.ignore(1000, '\n');

        cout << "Hello please enter your name" << endl;
        getline(cin, v.playerName);
        v.file << v.playerName << endl;

        cout << "\n";

        cout << "Thank you " << v.playerName << " now please enter the name of your prison" << endl;
        getline(cin, v.prisonName);
        v.file << v.prisonName << endl;

        cout << "\n";

        cout << "Ok thank you lets start the game" << endl;
        cin.get();

        v.money = 50000;
        v.prisoners = 0;

        v.file << v.money << endl;
        v.file << v.prisoners << endl;

        v.file.close();

        v.Game();
    }
    else if(choice == 2)
    {
        ifstream file;
        ifstream names;

        file.open("prison.txt");
        names.open("prisonersList.txt");

        getline(file, v.playerName);
        getline(file, v.prisonName);
        file >> v.money;
        file >> v.prisoners;
        
        while(!v.names.eof())
        {
            getline(names, v.fileStr);
        }

        file.close();

        v.Game();
    }
}

[MrHutch]

As I said in your other post, it's because you're getting a little mixed up with streams.

If you're reading from a file, you want an ifstream object, not an ofstream.

[Ch1156]

Ah ok i see it now. Now i have another problem. When i pick option 2, it clears the prisoners text file of all text, why is that?

#include <iostream>
#include <string>
#include <fstream>
#include <ctime>
#include <cstdlib>
#include <vector>

using namespace std;

struct Vars
{
    void Game();
    string randNames();
    string randCrimes();

    long int money;
    int prisoners;
    string playerName;
    string prisonName;
    ofstream names; // Saves the prisoners list
    ofstream file; // Saves the player info
    string fileStr;
};

int main()
{
    int choice;
    srand(time(0x0));

    Vars v;

    cout << "1) New" << endl;
    cout << "2) Load\n" << endl;
    cin >> choice;

    if(choice == 1)
    {
        v.file.open("prison.txt");

        cin.ignore(1000, '\n');

        cout << "Hello please enter your name" << endl;
        getline(cin, v.playerName);
        v.file << v.playerName << endl;

        cout << "\n";

        cout << "Thank you " << v.playerName << " now please enter the name of your prison" << endl;
        getline(cin, v.prisonName);
        v.file << v.prisonName << endl;

        cout << "\n";

        cout << "Ok thank you lets start the game" << endl;
        cin.get();

        v.money = 50000;
        v.prisoners = 0;

        v.file << v.money << endl;
        v.file << v.prisoners << endl;

        v.file.close();

        v.Game();
    }
    else if(choice == 2)
    {
        ifstream file;
        ifstream names;

        file.open("prison.txt");

        getline(file, v.playerName);
        getline(file, v.prisonName);
        file >> v.money;
        file >> v.prisoners;

        file.close();

        names.open("prisonersList.txt");

        while(!names.eof())
        {
            getline(names, v.fileStr);
        }

        names.close();

        v.Game();
    }
}

[MrHutch]

Not sure. Can't see any reason why it would be doing that. Nothing in the code seems to suggest that it would be doing that for option two.

One thing I will say, though, is that you're constantly overwriting the fileStr string of the Vars class. It's only ever going to store the last line of text from the prisonersList.txt file.

[Ch1156]

How is it being constantly overwritten? because its in the while loop?

[Ch1156]

Oh and i still cant figure out whats wrong with the file being overwritten i tried a few things but nothing. :(

[Peter87]

When you use getline, the string will get a new value so the old value is lost.

[Ch1156]

I tried not using getline and the contents of my text file were still deleted.

[Peter87]

Do you write to the file that is being deleted somewhere in the program?

[Ch1156]

I think but im not sure. Maybe lines 51 and 52?

void Vars::Game()
{
    int choice;
    int random;
    int inMnum;
    bool endLoop = true;
    names.open("prisonersList.txt");

    cout << "Main Menu\n" << endl;

    cout << "What do you want to do?\n" << endl;

    cout << "1) Add prisoners" << endl;
    cout << "2) View list of executed prisoners" << endl;
    cout << "3) View prison statistics" << endl;
    cout << "4) Execute Prisoner(s)" << endl;
    cout << "5) List of current inmates" << endl;

    while(endLoop != false)
    {
        cin >> choice;

        switch(choice)
        {
            case 1:
                {
                    cout << "INMATE LIST" << endl;

                    vector<string> nameVect;
                    vector<string> crimeVect;

                    cout << "Enter how many inmates you would like to take in." << endl;
                    cout << "Your current prisoner count is: " << prisoners << endl;
                    cout << "You may not exceed 25 prisoners at this time" << endl;
                    cin >> inMnum;

                    if((inMnum > 0) && (inMnum < 26))
                    {
                        for(int i = 0; i < inMnum; i++)
                        {
                            nameVect.push_back(randNames());
                            crimeVect.push_back(randCrimes());
                        }

                        cout << "Name " << "Crime\n" << endl;

                        for(int i = 0; i < inMnum; i++)
                        {
                            cout << nameVect[i] << " ";
                            cout << crimeVect[i] << endl;
                            names << nameVect[i] << " ";
                            names << crimeVect[i] << endl;
                        }
                    }
                    else
                    {
                        cout << "Error" << endl;
                        endLoop = false;
                    }
                }
                break;
            case 2:
                cout << "Executed Prisoners\n" << endl;
                break;
            case 3:
                cout << "Prison Statistics\n" << endl;
                cout << "Warden Name: " << playerName << endl;
                cout << "Prison Name: " << prisonName << endl;
                cout << "Current Money: " << money << endl;
                cout << "Prisoners: " << prisoners << endl;
                break;
            case 4:
                cout << "EXECUTE A PRISONER\n" << endl;
                break;
            case 5:
                cout << "CURRENT INMATES\n" << endl;

                cout << fileStr;
                break;
        }
    }

}

[Ch1156]

Ik i think i fixed it finally.

[Ch1156]

Now i need to know how i output it?

EDIT: Ok i modified the program so that if and of stream are in the struct, the code works now, i just cant outpur whats in my text file.

#include <iostream>
#include <string>
#include <fstream>
#include <ctime>
#include <cstdlib>
#include <vector>

using namespace std;

struct Vars
{
    void Game();
    string randNames();
    string randCrimes();

    long int money;
    int prisoners;
    string playerName;
    string prisonName;
    ofstream namesOut; // Saves the prisoners list
    ofstream fileOut; // Saves the player info
    ifstream fileIn;
    ifstream namesIn;
    string fileStr;
};

int main()
{
    int choice;
    srand(time(0x0));

    Vars v;

    cout << "1) New" << endl;
    cout << "2) Load\n" << endl;
    cin >> choice;

    if(choice == 1)
    {
        v.fileOut.open("prison.txt");

        cin.ignore(1000, '\n');

        cout << "Hello please enter your name" << endl;
        getline(cin, v.playerName);
        v.fileOut << v.playerName << endl;

        cout << "\n";

        cout << "Thank you " << v.playerName << " now please enter the name of your prison" << endl;
        getline(cin, v.prisonName);
        v.fileOut << v.prisonName << endl;

        cout << "\n";

        cout << "Ok thank you lets start the game" << endl;
        cin.get();

        v.money = 50000;
        v.prisoners = 0;

        v.fileOut << v.money << endl;
        v.fileOut << v.prisoners << endl;

        v.fileOut.close();

        v.Game();
    }
    else if(choice == 2)
    {
        v.fileIn.open("prison.txt");

        getline(v.fileIn, v.playerName);
        getline(v.fileIn, v.prisonName);
        v.fileIn >> v.money;
        v.fileIn >> v.prisoners;

        v.fileIn.close();

        v.namesIn.open("prisonersList.txt");

        while(!v.namesIn.eof())
        {
            getline(v.namesIn, v.fileStr);
        }

        v.namesIn.close();

        v.Game();
    }
}

void Vars::Game()
{
    int choice;
    int random;
    int inMnum;
    bool endLoop = true;

    cout << "Main Menu\n" << endl;

    cout << "What do you want to do?\n" << endl;

    cout << "1) Add prisoners" << endl;
    cout << "2) View list of executed prisoners" << endl;
    cout << "3) View prison statistics" << endl;
    cout << "4) Execute Prisoner(s)" << endl;
    cout << "5) List of current inmates" << endl;

    while(endLoop != false)
    {
        cin >> choice;

        switch(choice)
        {
            case 1:
                {
                    namesOut.open("prisonersList.txt");

                    cout << "INMATE LIST" << endl;

                    vector<string> nameVect;
                    vector<string> crimeVect;

                    cout << "Enter how many inmates you would like to take in." << endl;
                    cout << "Your current prisoner count is: " << prisoners << endl;
                    cout << "You may not exceed 25 prisoners at this time" << endl;
                    cin >> inMnum;

                    if((inMnum > 0) && (inMnum < 26))
                    {
                        for(int i = 0; i < inMnum; i++)
                        {
                            nameVect.push_back(randNames());
                            crimeVect.push_back(randCrimes());
                        }

                        cout << "Name " << "Crime\n" << endl;

                        for(int i = 0; i < inMnum; i++)
                        {
                            cout << nameVect[i] << " ";
                            cout << crimeVect[i] << endl;
                            namesOut << nameVect[i] << " ";
                            namesOut << crimeVect[i] << endl;
                        }
                    }
                    else
                    {
                        cout << "Error" << endl;
                        endLoop = false;
                    }
                    namesOut.close();
                }
                break;
            case 2:
                cout << "Executed Prisoners\n" << endl;
                break;
            case 3:
                cout << "Prison Statistics\n" << endl;
                cout << "Warden Name: " << playerName << endl;
                cout << "Prison Name: " << prisonName << endl;
                cout << "Current Money: " << money << endl;
                cout << "Prisoners: " << prisoners << endl;
                break;
            case 4:
                cout << "EXECUTE A PRISONER\n" << endl;
                break;
            case 5:
                cout << "CURRENT INMATES\n" << endl;

                while(!namesIn.eof())
                {
                    getline(namesIn, fileStr);
                }
                break;
        }
    }

}

string Vars::randNames()
{
    string names[20] =
    {
        "Jerry",
        "Mike",
        "Phill",
        "Robert",
        "Allen",
        "Alex",
        "Tim",
        "Steven",
        "Ronald",
        "David",
        "Harold",
        "Thomas",
        "Andrew",
        "Carlito",
        "Frank",
        "Dale",
        "John",
        "Mark",
        "Josh",
        "Martin"
    };

    return names[rand() % 20];
}

string Vars::randCrimes()
{
    string crimes[20] =
    {
        " - Sexual Assault",
        " - Child Abuse",
        " - Murder",
        " - Assault",
        " - Breaking and Entering",
        " - Domestic Violence",
        " - Unlawful Posession of a Firearm",
        " - Destruction of private property",
        " - Kidnapping",
        " - Armed Robbery",
        " - Petty Theft",
        " - Disorderly Conduct",
        " - Indecent Exposure",
        " - Stalking",
        " - Shoplifting",
        " - Trespassing",
        " - Battery on and Officer",
        " - Forgery",
        " - Grand Theft Auto",
        " - Probation Violation"
    };

    return crimes[rand() % 20];
}

Line 173 is where im trying to output the contents of the text file.

[Ch1156]

bump.