can someone help me finish this code.

[freak04]

well im having a hard time with this code. mainly because of the pointers. i know what i need to do but its hard for me to translate it to codes. so i hope someone could help me.

#include<iostream>
using namespace std;
#include<vector>; 


class CardDeck
{
  public:
        CardDeck();   // default constructor
	~CardDeck();  // destructor

/*The constructor should create 52 cards individually (no loops) 
using the new operator (dynamic memory) and add them to the deck vector*/
	CardDeck::CardDeck(){

		//HEART suit
		deck.push_back(new Card(ACE, HEARTS));
		deck.push_back(new Card(TWO, HEARTS));
		deck.push_back(new Card(THREE, HEARTS));
		deck.push_back(new Card(FOUR, HEARTS));
		deck.push_back(new Card(FIVE, HEARTS));
		deck.push_back(new Card(SIX, HEARTS));
		deck.push_back(new Card(SEVEN, HEARTS));	
		deck.push_back(new Card(EIGHT, HEARTS));
		deck.push_back(new Card(NINE, HEARTS));
		deck.push_back(new Card(TEN, HEARTS));
		deck.push_back(new Card(JACK, HEARTS));
		deck.push_back(new Card(QUEEN, HEARTS));
		deck.push_back(new Card(KING, HEARTS));
		
		//CLUBS suit
		deck.push_back(new Card(ACE, CLUBS));
		deck.push_back(new Card(TWO, CLUBS));
		deck.push_back(new Card(THREE, CLUBS));
		deck.push_back(new Card(FOUR, CLUBS));
		deck.push_back(new Card(FIVE, CLUBS));
		deck.push_back(new Card(SIX, CLUBS));
		deck.push_back(new Card(SEVEN, CLUBS));		
		deck.push_back(new Card(EIGHT, CLUBS));
		deck.push_back(new Card(NINE, CLUBS));
		deck.push_back(new Card(TEN, CLUBS));
		deck.push_back(new Card(JACK, CLUBS));
		deck.push_back(new Card(QUEEN, CLUBS));
		deck.push_back(new Card(KING, CLUBS));
		
		//SPADES suit
		deck.push_back(new Card(ACE, SPADES));
		deck.push_back(new Card(TWO, SPADES));
		deck.push_back(new Card(THREE, SPADES));
		deck.push_back(new Card(FOUR, SPADES));
		deck.push_back(new Card(FIVE, SPADES));
		deck.push_back(new Card(SIX, SPADES));
		deck.push_back(new Card(SEVEN, SPADES));		
		deck.push_back(new Card(EIGHT, SPADES));
		deck.push_back(new Card(NINE, SPADES));
		deck.push_back(new Card(TEN, SPADES));
		deck.push_back(new Card(JACK, SPADES));
		deck.push_back(new Card(QUEEN, SPADES));
		deck.push_back(new Card(KING, SPADES));

		//DIAMONDS suit
		deck.push_back(new Card(ACE, DIAMONDS));
		deck.push_back(new Card(TWO, DIAMONDS));
		deck.push_back(new Card(THREE, DIAMONDS));
		deck.push_back(new Card(FOUR, DIAMONDS));
		deck.push_back(new Card(FIVE, DIAMONDS));
		deck.push_back(new Card(SIX, DIAMONDS));
		deck.push_back(new Card(SEVEN, DIAMONDS));		
		deck.push_back(new Card(EIGHT, DIAMONDS));
		deck.push_back(new Card(NINE, DIAMONDS));
		deck.push_back(new Card(TEN, DIAMONDS));
		deck.push_back(new Card(JACK, DIAMONDS));
		deck.push_back(new Card(QUEEN, DIAMONDS));
		deck.push_back(new Card(KING, DIAMONDS));
	}

	CardDeck::~CardDeck(){
	//while deck is not empty
		while(deck.back > 0)
		{ delete Card;
		}
		//call delete on the last pointer in the deck to free the card
		//remove that pointer from the deck vector

	}

	/* Returns the Card pointer at the back of the vector or NULL if the deck is empty. */
	Card* getTopCard();
	Card*CardDeck::getTopCard();
	
	//need a local card* variable to hold the pointer to the top of the deck call it top
	//set it to null
	//if deck is not empty
	//store last card* in deck into top
	//remove that pointer from deck vector
	//return top
	 int * top = deck.front;


        /* Prints each card, one per line, using the Card's toString() member function. */
	void print()const;

	void CardDeck::print()const
	{
		/*loop through the deck
		for each element of deck
		dereference card pointer
		print out ots tostring()
		*/
		//loop to dereference card pointer.
	}

        /* Shuffles the deck of cards by swapping two random elements of the deck. */
	void shuffle();
	void CardDeck::shuffle()
	{
	/*1000 times
	swap 2 random elements of vector
	
	*/
	}



  private:
        vector<Card*> deck;

        /* Swaps the contents of the elements of deck at the given indices. */
        void swapCards(int index1, int index2);
};


//The Card class has already been defined for you:

enum Suit {HEARTS, CLUBS, SPADES, DIAMONDS};
enum Rank {ACE, TWO, THREE, FOUR, FIVE, SIX, SEVEN, EIGHT, NINE, TEN, JACK, QUEEN, KING};

class Card{

  public:
          Card(Rank r, Suit s);
          Rank getRank()const;
          Suit getSuit()const;
          string toString()const;

  private:
	  Suit suit;
	  Rank rank;
};

Card::Card(Rank r, Suit s){
   suit = s;
   rank = r;
}

Rank Card::getRank()const{
   return rank;
}

Suit Card::getSuit()const{
   return suit;
}

string Card::toString()const{
  
  string description = "";
  
  switch(rank) {
	case ACE:
		description += "Ace";
		break;
	case TWO:
		description += "Two";
		break;
        case THREE:
		description += "Three";
		break;
	case FOUR:
		description += "Four";
		break;
        case FIVE:
		description += "Five";
		break;
	case SIX:
		description += "Six";
		break;
        case SEVEN:
		description += "Seven";
		break;
	case EIGHT:
		description += "Eight";
		break;
	case NINE:
		description += "Nine";
		break;
        case TEN:
		description += "Ten";
		break;
	case JACK:
		description += "Jack";
		break;
	case QUEEN:
		description += "Queen";
		break;
	case KING:
		description += "King";
		break;
  }

  description += " of ";

  switch(suit) { 
	case HEARTS:
		description += "Hearts";
		break;
	case CLUBS:
                description += "Clubs";
		break;
	case SPADES:
		description += "Spades";
		break;
	case DIAMONDS:
                description += "Diamonds";
		break;
  }
  return description;
}


int main(){

	CardDeck d;
	d.print();

	cout << "Shuffling..." << endl << endl;

	d.shuffle();
    
	d.print();

	cout << endl << endl;
 
        return 0;
}

[Peter87]

You don't have to store the cards as pointers. Actually I don't see much point in doing so to be honest. Try to avoid pointers if you don't have to use them.

For shuffle you can use std::random_shuffle in <algorithm>.

[freak04]

thanks for taking the time to look at the code, but i have to use pointer and vectors since is the topic/section we are reviewing in class. i have read the tutorial on vector and pointer but i dont really know how to apply it to this problem.

i know it is a assigment so im not really asking for the answer. i just want some tips or examples on how to do it.

[slider57]

first of all I like how organized your code is, sometimes reading other people's code is the biggest problem. Second... try not to build your functions in the classes. What I want to see is a class that shows only what I need to know so I can use it. I am not so concerned with the implementation (which you can put below main). Is this code just unfinished because is see deck.push_back (information) but i dont see the declaration of the vector deck. What is it? A queue, a deque, a stack? Also what is the main purpose of this program?

[freak04]

its under private.

private:
        vector<Card*> deck;

the purpose is to get some practice with vector, pointers and classes. as for the program the only purpose is to shuffle the cards and print them on the screen one by one.

[slider57]

what that is basically saying is make an array that can only store pointers that point to the object card and name it deck. If you look at this site here you can get some of the methods for a vector: http://www.cplusplus.com/reference/stl/vector/vector/

I help you with one method in your class and see how you do from there.
-line 89 the getTop() method. On line 97 you have:
int * top = deck.top();
What you are saying there is create a pointer to an integer and make it point to whatever the pointer of the Deck is pointing to. This wont work because you have a type mismatch.
int != Deck. So you will want to do something like this:
Deck* top = this->back();
This code initializes a Deck pointer and sets it equal to the back of the vector (which is your top since a vector can only remove from the back).
The 'this' pointer just references the calling object so if in main you say:

 Deck d;
d.getTop();

The 'this' pointer will reference (or point to) the object 'd' that called the function. The arrow operator ("->") is a easy way to dereference the 'this' pointer (or any pointer) but you can do it two ways "this->pop_back()" or "(*this).pop_back();"
Next, you'll want to get rid of the 'top' element. You do this by:
this->pop_back();
This calls your Deck destructor to destroy the object and changes the value of top to the next element in line. So when you get all done you should have something like this (I just filled in the easy parts):

Deck* top = NULL;
if (!this->empty())
{
top = this->back();
this->pop_back();
}
return top;

this returns top pointer, you can do this because of the declaration of the class: Deck* Deck :: getTop()
the first Deck denotes the return type and with the astrisk, it means it will return a Deck pointer. Then the second deck is just the class with the scope reesolution operator and the function name. Anyway, hope that helps... im going to go grab some grub. Let me know if you need more help.

[freak04]

Thanks ill work ont the codes as soon as i get home.. ill try to work from there

[freak04]

im kindda confussed with "this" pointer. but i guess i will read about it. one more thing how do u use tostring();?

 /* Prints each card, one per line, using the Card's toString() member function. */
	void print()const;

	void CardDeck::print()const
	{
		/*loop through the deck
		for each element of deck
		dereference card pointer
		print out ots tostring()
		*/
		//loop to dereference card pointer.
	}

and what is the best way to shuffle random elements of a vector?

[slider57]

No worries. The 'this' pointer is a pointer that is automatically generated when an object calls one of its member function. So it is always available to you in that sense. I use it just to help differentiate the calling objects variables from other variables in the method.

Whats really nice is that toString() is already written for you. Notice this line of code on line 125 and 126:

private:
        vector<Card*> deck;

This private member variable creates a vector that can only hold card objects and it is named deck. So in each element of the vector (or array if you prefer) you have a pointer to a card object. Well if you take a look at the card objects methods you see a toString() method. So this tells you that each card object has a toString() method. The toString() method generally formats text into a way that is meaningful to you (because you write it). There are many different ways to do what the toString() method does though (I.E. overloading the extraction operator (<<), or just accessing each of the objects member variables individually and cout << them. The reason why a toString() method or overloaded extraction operator is preferred is because the member variables of your class is private, so they are not directly accessible from non-member functions (such as main). Another reason is because of modulation. Modulation is just basically grouping code that is similar into a function so it can be easily called, easily manageable, and you don't have to keep writing the same code over and over again. Whats nice about object oriented programming is abstraction. All you need to know about toString() is how to call it, what arguments does it take, and what does it return. You are not concerned with how it does it.

toStrings() can be accessed via the dot operator (.) or if you are trying to access it through a pointer you will first have to dereference the pointer. The two ways to do this is the arrow operator (->) like I used with the 'this' pointer or like this (*pointer to object) then using the dot operator after that.

As for your question about vectors. The STL (Standard Template Library) contains three things, 1) containers (such as a queue or vector), 2) iterators (your instructor will probably explain that to you), and 3) generic algorithms. In the generic algorithms section of the STL you can find a nice little method that will shuffle your vector. The link to that is:

http://www.cplusplus.com/reference/algorithm/

if you googled that last question you have you could have found that out.

[freak04]

thanks for your help i was able to finish the program. i mean is kindda useless since it only display the deck and suffles it. but it was good for practice. and thanks again.

[slider57]

Not entirely useless. A few more codes and you could turn it into a blackjack game or something. Your welcome.