Question 3

[prestige]

Write a user-defined function in C++ to find and display the sum of both the diagonal
elements of a two-dimensional array MATRIX [6] [6] containing integers.
I did this....

#include<iostream.h>
#include<conio.h>

void main()

{ clrscr();
int i,j,a[6][6], sum=0;
cout<<" Enter values in the matrix";

for(i=0;i<6;i++)
{ for(j=0;j<6;j++)
{ cout<<" Enter value for a["<<i<<"]["<<j<<"]";
cin>>a[i][j];
if(i==j||(i+j)==6)
sum+=a[i][j];
}

cout<<"Sum is: "<<sum;

getch();

}


Is it correct?
I know it is ..
Any better way doing that?

[LB]

Any better way doing that?

Yes. Don't include <conio.h>, make sure you include <iostream> and NOT <iostream.h>, don't use clrscr() (it's not even needed here), use cin.ignore(unsigned(-1), '\n') instead of getch(), and use proper code indenting.

[prestige]

I have TurboC++ 3.0 which requires .h extension. MY course books are based on turbo .. So I have to code it for that compiler...

About Indentation. I am practicing for my exams And I am in a hurry. So should I indent..
Humble thanks

[Albatross]

Turbo C++ is a pre-standard compiler and thus it's really really bad nowadays. Could you perhaps switch to something newer? :/

Also, void main() should be int main(). Just a heads-up. :)

-Albatross

[JLBorges]

if(i==j||(i+j)==6)
Shouldn't this be if(i==j||(i+j)==5) ?


>Write a user-defined function in C++ to find and display the sum of both the diagonal
>elements of a two-dimensional array MATRIX [6] [6] containing integers.

If you are actually going to write a function, write it with just one loop.

enum { N = 6 } ;
typedef int array_type[N][N] ;

int sum_diagonals( const array_type& array )
{
    int sum = 0 ;
    for( int i = 0 ; i<N ; ++i ) sum += array[i][i] + array[i][N-i-1] ;
    return sum ;
}

[prestige]

Awesome...
Now got it.
@Albatross: I cant at this moment but will do after two months when my Course completes and will be learning a lot from all of you here when in vacations...
Thank you to all of you.