I need an advice for a problem

[Cecill]

Hello there! I encountered a little problem that I cannot explain. If someone help me with solving it I will be highly appreciated.
Here's the source code:

#include <iostream>
#include <cstring>
#include <cctype>
#include <conio.h>
using namespace std;

class ElectricalComponent {
   char *part_number;
   char *name;
   long value;
   char *unit;
public:
   ElectricalComponent( char *pn= '\0', char *n= '\0', long v= 0, char *u= '\0') {
      cout<<"\nCreated electrical component\n";
      int l;

      l= strlen( pn)+ 1;
      part_number= new char [ l];
      if(!part_number) {
         cout<< "Allocation error.\n";
         exit( 1);
      }
      strcpy( part_number, pn);

      l= strlen( n)+ 1;
      name= new char [ l];
      if(!name) {
         cout<< "Allocation error.\n";
         exit( 1);
      }
      strcpy( name, n);
      
      value= v;

      l= strlen( u)+ 1;
      unit= new char [ l];
      if(!unit) {
         cout<< "Allocation error.\n";
         exit( 1);
      }
      strcpy( unit, u);
   }

   ~ElectricalComponent() {
      delete [] part_number;
      delete [] name;
      delete [] unit;
   cout<< "deleted electrical component\n";
   }

   char *get_pn() {
      return part_number;
   }
   char *get_name() {
      return name;
   }
   long get_value() {
      return value;
   }
   char *get_unit() {
      return unit;
   }
};

class Element: public ElectricalComponent {
   char *country;
   long prize;
public:
   Element( char *pn= '\0', char *n= '\0', long v= 0, char *u= '\0', char *c= '\0', long p= 0 ): ElectricalComponent( pn, n, v, u) {
      cout<<"created element\n";
      
      int l;
      l= strlen( c)+ 1;
      country= new char [ l];
      if(!country) {
         cout<< "Allocation error.\n";
         exit( 1);
      }
      strcpy( country, c);

      prize= p;
   }

   ~Element() {
      delete [] country;
      cout<<"deleted element\n";
   }

   char *get_country() {
      return country;
   }
   long get_prize() {
      return prize;
   }
};

Element **input( Element **ptr, int &s) {
   int i;
   char part_number[20], name[ 30], unit[ 10], country[ 30];
   long value, prize;

   cout <<"\nEnter number of the electrical components: ";
   cin >>s;
   ptr= new Element *[ s];

   cout <<"\nEnter data for electrical components:\n";
   for( i= 0 ; i< s; i++) {
      cout <<"\n   Electrical Component <" <<i+1 <<">";
      cout <<"\nEnter Part Number: ";
      cin >>part_number;
      cout <<"Enter Name: ";
      cin >>name;
      cout <<"Enter Value: ";
      cin >>value;
      cout <<"Enter Unit: ";
      cin >>unit;
      cout <<"Enter Country: ";
      cin >>country;
      cout <<"Enter Prize: ";
      cin >>prize;
      ptr[ i]= new Element( part_number, name, value, unit, country, prize); 
   }
   return ptr;
}

void show( Element **ptr, int s) {
   int i;

   cout<< "\n   Information about current electrical components:\n";
   for( i= 0; i< s; i++) {
      cout <<"\nElectrical Component <" <<i+1 <<">";
      cout <<"\nPart Number: " <<ptr[ i]->get_pn() <<"\nName: " <<ptr[ i]->get_name() <<"\nValue: " <<ptr[ i]->get_value() 
          <<"\nUnit: " <<ptr[ i]->get_unit() <<"\nCountry: " <<ptr[ i]->get_country() <<"\nPrize: " <<ptr[ i]->get_prize() <<"\n";
   }
}

Element **delete_element( Element **ptr, int &s) {
   char i, j, part_number[ 20];
   char *temp;
   int status= 0;

   show( ptr, s);
   cout <<"\nEnter the part number of the element which you want to delete: ";
   cin >>part_number;
   for( i= 0; i< s; i++) {
      temp= new char[ strlen( ptr[ i]->get_pn())+ 1];
      strcpy( temp, ptr[ i]->get_pn());
      for( j= 0; j< strlen( temp); j++)
         temp[ j]= tolower( temp[ j]);
      if( strcmp( part_number, temp)== NULL) {
         for( j= i; j< s-1; j++)
            ptr[ j]= ptr[ j+1];
         ptr[ j+1]= '\0';
         s--;
         status= 1;
         cout <<"Electrical component with part number " <<part_number <<" has been deleted.";
         if( j== 0)
            ptr= '\0';
      }
      delete [] temp;
   }
   if( status== 0)
      cout <<"There is no such electrical component.\n";
   status= 0;
   return ptr;
}

void search( Element **ptr, int s) {
   int i, j, status= 0;
   char *temp;
   long up, down;

   cout<< "\nEnter a floor of the value: ";
   cin>> down;
   cout<< "Enter a limit of the value: ";
   cin>> up;
   for( i= 0; i< s; i++) {
      temp= new char[ strlen( ptr[ i]->get_name())+ 1];
      strcpy( temp, ptr[ i]->get_name());
      for( j= 0; j< strlen( temp); j++)
         temp[ j]= tolower( temp[ j]);
      if( strstr( temp, "condensator") != NULL)
         if( ( ptr[ i]->get_value() >= down) && ( ptr[ i]->get_value() <= up) ) {
            cout <<"\nPart Number: " <<ptr[ i]->get_pn() <<"\nName: " <<ptr[ i]->get_name()
<<"\nValue: " <<ptr[ i]->get_value() <<"\nUnit: " <<ptr[ i]->get_unit() 
<<"\nCountry: " <<ptr[ i]->get_country() <<"\nPrize: " <<ptr[ i]->get_prize() <<"\n";
            status= 1;
         }
      delete [] temp;
   }
   if( status== 0)
      cout <<"\nThere are no such condensators.\n";
   status= 0;
}

char *menu[]= {
   "\n<1> Input data for electrical components.",
   "<2> Output the data for the electrical components.",
   "<3> Delete electrical component.",
   "<4> Search for an condensator.",
   "<5> Exit."
};

void main() {

   int i, mode, size;

   Element **p= '\0';

   do {
      for(i= 0; i<5; i++)
         cout<< menu[ i]<< "\n";
      cout<< "\nChoose an option: ";
      cin>> mode;
      switch( mode) {
         case 1:
            p= input( p, size);
            cout <<"\nPress any key to continue.\n";
            getch();
            break;

         case 2:
            if( p)
               show( p, size);
            else 
               cout<< "\nYou haven't entered any information yet.";
            cout <<"\nPress any key to continue.\n";
            getch();
            break;

         case 3:
            if( p)
               p= delete_element( p, size);
            else 
               cout<< "\nYou haven't entered any information yet.";
            cout <<"\nPress any key to continue.\n";
            getch();
            break;

         case 4:
            if( p)
            search( p, size);
            else 
               cout<< "\nYou haven't entered any information yet.";
            cout <<"\nPress any key to continue.\n";
            getch();
            break;
      }
   } while( mode!= 5);
                  cout<< "\n CURRENT SIZE IS " <<size <<"// <-- Everything's looking OK?!? \n";   
for ( i= 0; i< size; i++) 
      delete p[ i]; 
   delete p;
}

So the problem is when performing the actions in this order: 1) Creating objects; 2) Delete an object (or more than one); 5) Exit;. When I Exit the program I recieve this: "Debug Error! DAMAGE: after Normal block (#70).......", but it still looks to work fine. Any ideas?

P.S. I have an aditional question. Can anybody help me with overloading the operator "<<", so when the user of the program Outputs the information on the screen about the objects, to save this information in a text file too?

Regards.

[Cecill]

Ideas anyone :?

[Peter87]

If you put code tags, [code] [/code] around the code the formatting will be kept intact.

[Cecill]

BUMP

[mobat]

I tried the code and it's working fine for me.

[Peter87]

If you create new objects you throw away any old objects (which are not deleted).

If you exit before having created any objects size will be uninitialized so the loop at the end can go wrong.

You have delete p; when it should be delete[] p;

In delete_element you are trying to write to the array out of bounds ptr[ j+1]= '\0';