For loops within for loops, within for loops..

[Thyde]

I've started working on a simple text based game, not even with any intention to finish it, just to see how far I can get.
I have the player choose their Gender, Name and Race, then show their choices and ask them to confirm it or choose something to change (Name, Race, Gender, or all)

I keep all of the choices within separate for loops, incase of an invalid entry, but it's not going quite as planned.

The problem I have is that the code always stays in the "What would you like the change?" section after I've chosen something new to change.


I literally started last tuesday, no laughing!

I'm not even sure what state this will copy/paste in.
Thanks in advance, I'm just trying to understand it better haha
Josh
(Code on next post, if it lets me add it soon enough)

[Danny Toledo]

Before posting the code, please use code tags (see the "format" panel at the side of the "reply" box).

[Thyde]

Shifted everything to the left to save characters from spaces, might be harder to read though
:)

#include<iostream>
#include<string>
using namespace std;

struct character {
int age;
string gender;
string name;
string race;
string clss;
};

void invalidEntry(void) {
cout << "Invalid entry, try again.\n";
}



int main() {
//initialize variables
string getRace;
character player;
player.race="none";
player.gender="none";
string charName = "null";
string charCorrect;
string charGender="none";
string change="none"; 

cout << "Welcome to Akalon." << endl;
cout << "What is your gender? Male, or Female.\n";
for(;player.race=="none"&&charGender=="none";) {
cin >> charGender;

if (charGender=="Male"||charGender=="male"||charGender=="m"||charGender=="M"||charGender=="MALE") {
player.gender="Male";

cout << player.gender << " selected." << endl;
}
else if (charGender=="Female"||charGender=="female"||charGender=="f"||charGender=="F"||charGender=="FEMALE") {
player.gender="Female";
cout << player.gender << endl;
}
else { 
invalidEntry();
cout << "Male, or Female?\n";
player.gender="none";
charGender="none";

}
}


cout << "What is your name, ";
if (player.gender=="Male") {cout << "boy?" << endl;}
if (player.gender=="Female") {cout << "girl?" << endl;}
cin >> player.name;
cout << "Hello, " << player.name;
cout << ". Which race are you then? " << endl;
cout << "Human\nOrc\n";

//fore loop that checks if the player has entered a correct value, if not, it loops.
for(;player.race=="none";){
//start of race for loop
//Race selection
cin >> getRace;    
if (getRace=="human" || getRace=="Human" || getRace=="h" ||getRace=="H") {

player.race="Human";
cout << "A noble choice, Human.\n";
}
else if (getRace=="orc" || getRace=="Orc" ||getRace== "o" || getRace=="O") {

player.race="Orc";
cout<< "For honor, Orc.\n";
}

else { 
invalidEntry();
cout << "Human, or Orc.\n";
}


} //end of race for loop

//check if the player is sure about the entered values
cout << "You have chosen the name " << player.name << " the gender " << player.gender << " and the race " << player.race << "." << endl;
cout << "Is this correct? y/n\n";
//another for loop to ensure correct entry
for(;charCorrect!="y"&& charCorrect!="n"&&charCorrect!="yes"&&charCorrect!="no";) {
cin >> charCorrect;


if (charCorrect=="n" || charCorrect=="no" || charCorrect=="NO" ||charCorrect=="N" && change!="changed") {

cout << "What would you like to change?\nName/Race/Gender/Everything\n";

for(;change!="name";) {
cin >> change; 
if (change=="name")
{ //start of name

for(;player.name!="null"&&change!="changed";) {   
player.name="null";                
cout << "What would you like to change your name to?" << endl;

cin >> player.name;
cout << "Very well, " << player.name << "."; 
change="changed";
charCorrect="yes";

}
} // end of name
else if (change=="race") { // start of race
player.race="none";
getRace="none";
cout << "What would you like your race to be, \nHuman, or Orc?" << endl;
for(;player.race=="none";){
//start of race for loop
//Race selection
cin >> getRace;    
if (getRace=="human" || getRace=="Human" || getRace=="h" ||getRace=="H") {

player.race="Human";
cout << "Okay, Human.\n";
charCorrect="yes";
break;
}
else if (getRace=="orc" || getRace=="Orc" ||getRace== "o" || getRace=="O") {

player.race="Orc";
cout<< "It is done, Orc.\n";
charCorrect="yes";
break;
}

else { 
invalidEntry();
cout << "Human, or Orc.\n";
}

//end of player.race=none for loop 
}


} // end of race 
else if (change=="gender") {//start of gender
player.gender="none";
charGender="none";
cout << "So what gender are you?" << endl;

for(;player.gender=="none"&&charGender=="none";) {
cin >> charGender;

if (charGender=="Male"||charGender=="male"||charGender=="m"||charGender=="M"||charGender=="MALE") {
player.gender="Male";

cout << player.gender << " selected." << endl;
charCorrect="yes";
change="changed";
break;
}
else if (charGender=="Female"||charGender=="female"||charGender=="f"||charGender=="F"||charGender=="FEMALE") {
player.gender="Female";
cout << player.gender << " selected." << endl;
charCorrect="yes";
change="changed";
break;
}
else { 
invalidEntry();
cout << "Male, or Female?";
player.gender="none";
charGender="none";
break;

}
} //end of gender for loop
} //end of gender
else if (change=="all"||change=="everything") {
player.name="null";
player.race="none";
player.gender="none";
charGender="none";
cout << "So gender would you like to be, Male or Female?";
for(;player.race=="none"&&charGender=="none";) {
cin >> charGender;

if (charGender=="Male"||charGender=="male"||charGender=="m"||charGender=="M"||charGender=="MALE") {
player.gender="Male";
cout << player.gender << " selected." << endl;


}
else if (charGender=="Female"||charGender=="female"||charGender=="f"||charGender=="F"||charGender=="FEMALE") {
player.gender="Female";
cout << player.gender << " selected." << endl;

}
else { 
invalidEntry();
cout << "Male, or Female?";
player.gender="none";
charGender="none";

}
}//end of all gender for loop


{//start of all name                  
cout << "What would you like to change your name to?" << endl;
cin >> player.name;
cout << "Very well, " << player.name << "."; 
//end of all name
}

//start of all race
cout << "What race would you like to be?";

for(;player.race=="none";){
//start of all race for loop
//Race selection
cin >> getRace;    
if (getRace=="human" || getRace=="Human" || getRace=="h" ||getRace=="H") {

player.race="Human";
cout << "A noble choice, Human.\n";
charCorrect="yes";
change="changed";
break;

}
else if (getRace=="orc" || getRace=="Orc" ||getRace== "o" || getRace=="O") {

player.race="Orc";
cout<< "For honor, Orc.\n";
charCorrect="yes";
change="changed";
break;

}

else { 
invalidEntry();
cout << "Human, or Orc.\n";
}


}//end of race for loop





} //end of everything/all
/*    else if (change!="race"&&change!="Race"&&change!="gender"&&change!="Gender"&&change!="all"&&change!="All"&&change!="everything"&&change!="Everything"&&change!="changed") {
change="none";
invalidEntry();                    
cout << "WHY ARE YOU HERE";
cout << change;
}*/


//end of y/n for loop
}
cout << "Your name is now " << player.name << ". Your Race is " << player.race << " and you are a " << player.gender << "." << endl;
break;


} //charcorrect=n close brace


else if (charCorrect=="y" || charCorrect=="yes" || charCorrect=="Y" || charCorrect=="Yes"|| charCorrect=="YES") {
cout << "Very Well." << endl;
break;
}//charcorrect=y close brace       
else {
invalidEntry();
cout << "Please choose Yes or No";
} // correct = yes close brace

}// correct = yes/no question close brace



cout << "Continuation message, you are in a forest, or something similar.";

return 0;  
} // end main brace  

[MottMan]

EDIT:

You're just missing some break; points.

            for(; change!="name";)
            {
                cin >> change;
                if (change=="name")
                {
                    //start of name

                    for(; player.name!="null"&&change!="changed";)
                    {
                        player.name="null";
                        cout << "What would you like to change your name to?" << endl;

                        cin >> player.name;
                        cout << "Very well, " << player.name << ".";
                        change="changed";
                        charCorrect="yes";
                        break; //YOU NEED THIS BREAK

                    }
                } // end of name


                //more code


            cout << "Your name is now " << player.name << ". Your Race is " << player.race << " and you are a " << player.gender << "." << endl;
            break; //YOU NEED THIS BREAK

            } 

It's formatting got completely screwed up here when I posted it but it should help. You'll need to add breaks in the other sections such as where you change race, gender, etc.

[Thyde]

Thanks I'll try and add a break on every result, I don't need breaks on else InvalidEntry()'s do I? because that's meant to loop anyway

edit: Score! thanks. I didn't even consider adding breaks at the end of parent scopes, or whatever they're called in C++ :)

[S6k9GNh0]

If that break is needed then the purpose of a for loop is gone. I didn't review the code completely but just saying..

[MottMan]

If that break is needed then the purpose of a for loop is gone. I didn't review the code completely but just saying..

He's right. The for loops you have setup aren't needed because by the look of the chunks they aren't designed to repeat anyway.

That's just pertaining to the code you have for changing attributes. The other for loops may or may not be necessary. I don't know what you intend.

[Thyde]

They're meant to loop if an input isn't a valid choice, like
"Choose Race. Male or Female"
if you enter "both" or something, I don't know any other way to make it so you have to enter it again

Like I said, I'm a newbie so if there's a better way to do that I'll be happy to know as for loops are a bit tedious

:)

edit: That's why I've only put the breaks when a valid answer's given, to get out of the loop

Josh

[MottMan]

for(; player.name!="null"&&change!="changed";)
                    {
                        player.name="null";
                        cout << "What would you like to change your name to?" << endl;

                        cin >> player.name;
                        cout << "Very well, " << player.name << ".";
                        change="changed";
                        charCorrect="yes";
                        break; //YOU NEED THIS BREAK

                    }

This will never repeat. That break the is required to make it work will get out of the loop regardless. Even if it wasn't there because the player is unlikely to type null (although it would make a decent character name) it will always except what they input and always make the string change turn to "changed". Even if you type null change will still be given the green flag and the for loop doesn't loop.

Here's pseudo code for what I think you are trying to accomplish:

while (player_happy_with_choice == false)
cout << "What do you want to change....?\n";
getline(cin, what_I_want_to_change); //I always use getline for strings
cout << "What do you want to change...to?\n";
getline(cin, name);
cout << "Are you happy with " << name << "? y/n" << endl;
cin >> y; 
cout << "Okay\n";
//loop ends 
//if user typed n it would repeat the query 

Is that more what you are looking for?