Ways to improve my code
Can you tell me ways to improve my code that I have written for my text based adventure game:
http://pastie.org/private/xnnu992cwloaxkbhwwgitw
http://pastie.org/private/xnnu992cwloaxkbhwwgitw
Don't use so many global variables.
mapwho seems to be a useless class (only one variable??)
Constructors
Don't use system()
Please generalize some of this stuff...you have too many functions doing really similar things IMO
^Like your map function definitely...make map a class instead
Some functions have side effects I wouldn't expect...why does findmap() print the map?
Why does mapping() play the game?
mapwho seems to be a useless class (only one variable??)
Constructors
Don't use system()
Please generalize some of this stuff...you have too many functions doing really similar things IMO
^Like your map function definitely...make map a class instead
Some functions have side effects I wouldn't expect...why does findmap() print the map?
Why does mapping() play the game?
I have lost the game (line 543)
Well, the code is long and I haven't read everything but I have noticed a few things:
1. In statswarrior() / statsmage() you use a use an infinite loop and break when you could just write
2. You used
3. The problem with your classes is that you didn't take advantage of their full potential. You only used member variables but not member functions which could be really powerful. Actually, all the member variables are public and you do not utilize encapsulation which is just pity.
Generally, your code is very nice. The work you put into this is noticeable and there are no real mistakes but only inefficient style. I believe you will improve that as you go on programming so there's nothing to worry about.
Well, the code is long and I haven't read everything but I have noticed a few things:
1. In statswarrior() / statsmage() you use a use an infinite loop and break when you could just write
while(response != "done") instead and move the inside of the if statement out of the loop.2. You used
system("CLS"); quite a lot. Beware that this won't work for some people and other forum members would probably advice against the use of this (I think there was a topic discussing this yesterday). Yet, since it's for aesthetic purposes I guess it's fine.3. The problem with your classes is that you didn't take advantage of their full potential. You only used member variables but not member functions which could be really powerful. Actually, all the member variables are public and you do not utilize encapsulation which is just pity.
Generally, your code is very nice. The work you put into this is noticeable and there are no real mistakes but only inefficient style. I believe you will improve that as you go on programming so there's nothing to worry about.
I can probably just combine mapwho with character.
I try not to use system but for now i wanted something quick to clear the screen. Ill make a function for it later.
I dont understand what you mean by constructors.
How would the map class work?
findmap() prints the map according to which map you are in. Theres 2 map areas and it finds out which one you are in and prints the map accordingly.
I try not to use system but for now i wanted something quick to clear the screen. Ill make a function for it later.
I dont understand what you mean by constructors.
How would the map class work?
findmap() prints the map according to which map you are in. Theres 2 map areas and it finds out which one you are in and prints the map accordingly.
I took your advice Zellinger about the while(response != "done") I dont know why I havent thought of that before. I would try to use classes to there full potential but I have read NUMEROUS tutorials about them and I still dont get how the process works or how I can utilize my code to work with it. It dosent click for me.
Topic archived. No new replies allowed.