Syntax error that I cannot find.

[vasncode]

This program prints the same question after the user selects to play again and sometimes it'll print "wrong" even when the user is correct. Im assuming its just a syntax error but Im not sure.

#include <iostream>
#include <iomanip>
#include <string>
#include <cctype>
#include <cstdlib>
#include <ctime>
using namespace std;


void convertToLower(string &tempString);




int main ()
{
const int SIZE = 10;
char choice;
unsigned int seed= (unsigned int) (time(0));
srand(seed);

string Questions[SIZE]= {" What fruit in 'The Godfather' appeared before every death? ", "Which country invented ice cream? ", "Which U.S state is known for peaches? ", 
"What is the common name for dried plums? ",  "What kind of alchohol is Russia known for? ", "What is the rarest M&M color? ", "Which is the only edible food that never goes bad? ",
 "Which country consumes the most chocolate per capita? ","What is the most consumed manufactured drink in the world? ", "Which state would you eat laulau in? "};

string Answers[SIZE]={"oranges", "china", "georgia", "prunes", "vodka", "brown", "honey", "switzerland", "tea", " hawaii"};

int generator = rand()%10 +1 ;

string answer1, answer2, answer3, answer4, answer5, answer6, answer7, answer8, answer9,answer10;




cout<<endl;
cout<< "~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n";
cout<< "          Welcome to Foood Trivia!!!"<<endl;
cout<<endl;
cout<<"Ready to Play? (Y/N) ";
cin>>choice;
cout<<endl;
cout<<"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n";

while ((choice == 'Y' ) || (choice=='y')) 
{
    cout << Questions[generator]; 
    
 if ((choice =='N') || (choice =='n'))
 {
     cout<<"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n"
     <<endl
     << "Maybe next time!\n "
     <<"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n"
     <<endl;
     exit(-1);
 }





if (Questions[generator] == Questions[0])
{
cin>>answer1;
convertToLower(answer1);

if (answer1==Answers[0])
{
    cout<<endl;
    cout<<"Correct!"<<endl;
    cout<<endl; 
}
  else{
    cout<<endl;
    cout<<"WRONG!\n";} 
    cout<<endl;
}




if (Questions[generator] == Questions[1])
{
cin>>answer2;
convertToLower(answer2);

if (answer1==Answers[1])
{
    cout<<endl;
    cout<<"Correct!"<<endl;
    cout<<endl; 
 }
  else{
    cout<<endl;
    cout<<"WRONG!\n";} 
    cout<<endl;
}




if (Questions[generator] == Questions[2])
{
cin>>answer3;
convertToLower(answer3);

if (answer3==Answers[2])
{
    cout<<endl;
    cout<<"Correct!"<<endl;
    cout<<endl; 
    
 }
  else{
    cout<<endl;
    cout<<"WRONG!\n";} 
    cout<<endl;
}



if (Questions[generator] == Questions[3])
{
cin>>answer4;
convertToLower(answer4);

if (answer4==Answers[3])
{
    cout<<endl;
    cout<<"Correct!"<<endl;
    cout<<endl; 
 }
 else{
    cout<<endl;
    cout<<"WRONG!\n";} 
    cout<<endl;
}




if (Questions[generator] == Questions[4])
{
cin>>answer5;
convertToLower(answer5);

if (answer5==Answers[4])
{
    cout<<endl;
    cout<<"Correct!"<<endl;
    cout<<endl; 
}
else{
    cout<<endl;
    cout<<"WRONG!\n";} 
    cout<<endl;
}


if (Questions[generator] == Questions[5])
{
cin>>answer6;
convertToLower(answer6);

if (answer6==Answers[5])
{
    cout<<endl;
    cout<<"Correct!"<<endl;
    cout<<endl; 
    
}else{
    cout<<endl;
    cout<<"WRONG!\n";} 
    cout<<endl;
}



if (Questions[generator] == Questions[6])
{
cin>>answer7;
convertToLower(answer7);

if (answer7==Answers[6])
{
    cout<<endl;
    cout<<"Correct!"<<endl;
    cout<<endl; 
}else{
    cout<<endl;
    cout<<"WRONG!\n";} 
    cout<<endl;
}





if (Questions[generator] == Questions[7])
{
cin>>answer8;
convertToLower(answer8);

if (answer8==Answers[7])
{
    cout<<endl;
    cout<<"Correct!"<<endl;
    cout<<endl; 
    
}else{
    cout<<endl;
    cout<<"WRONG!\n";} 
    cout<<endl;
}

  



if (Questions[generator] == Questions[8])
{
cin>>answer9;
convertToLower(answer9);


if (answer9==Answers[8])
{
    cout<<endl;
    cout<<"Correct!"<<endl;
    cout<<endl; 
    
}else{
    cout<<endl;
    cout<<"WRONG!\n";} 
    cout<<endl;
}




if (Questions[generator] == Questions[9])
{
cin>>answer10;
convertToLower(answer10);

if (answer10==Answers[9])
{
    cout<<endl;
    cout<<"Correct!"<<endl;
    cout<<endl; 
 }else{
    cout<<endl;
    cout<<"WRONG!\n";} 
    cout<<endl;
}



 
    cout<< "Play again? (Y/N)?   ";
    cin>>choice;


}




return 0;

}




void convertToLower(string &tempString)  
{

unsigned int i; 
for (i = 0; i < tempString.length(); i++) 
tempString[i] = tolower(tempString[i]); 
 
tempString[i] = '\0'; 
} 

[newbieg]

Your generator variable is being set outside of your main loop. Try putting generator = rand %10; after line 46. Don't add one, you want it to include 0 as an option for your array index.
Also you do have a copy-pasted syntax error, see lines 76, 96, 117, etc.

Your arrays are set up in a way that you could use a shortcut in your code:

#include <iostream>
#include <string>
#include <cstdlib>
#include <ctime>
using namespace std;

void convertToLower(string &tempString);

int main ()
{
	const int SIZE = 10;
	char choice;
	unsigned int seed= (unsigned int) (time(0));
	srand(seed);

	string Questions[SIZE]= {" What fruit in 'The Godfather' appeared before every death? ", "Which country invented ice cream? ", "Which U.S state is known for peaches? ",
	"What is the common name for dried plums? ",  "What kind of alchohol is Russia known for? ", "What is the rarest M&M color? ", "Which is the only edible food that never goes bad? ",
	 "Which country consumes the most chocolate per capita? ","What is the most consumed manufactured drink in the world? ", "Which state would you eat laulau in? "};

	string Answers[SIZE]={"oranges", "china", "georgia", "prunes", "vodka", "brown", "honey", "switzerland", "tea", "hawaii"};

	int generator; // this gets set at the top of the loop

	string userAnswer;

	cout<<endl;
	cout<< "~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n";
	cout<< "          Welcome to Foood Trivia!!!"<<endl;
	cout<<endl;
	cout<<"Ready to Play? (Y/N) ";
	cin>>choice;
	cout<<endl;
	cout<<"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n";

	while ((choice == 'Y' ) || (choice=='y')) 
	{
		generator = rand()%10;
		cout << Questions[generator]; 
	
		cin>>userAnswer;
		convertToLower(userAnswer);
		if (userAnswer==Answers[generator])
		{
			cout<<endl;
			cout<<"Correct!"<<endl;
			cout<<endl; 
		}
		else
		{
			cout<<endl;
			cout<<"WRONG!\n";
			cout<<endl;
		}
	
		cout<< "Play again? (Y/N)?   ";
		cin>>choice;
	}

	if ((choice =='N') || (choice =='n'))
	{
		cout<<"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n"
		<<endl
		<< "Maybe next time!\n "
		<<"~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n"
		<<endl;
	}


	return 0;
}

void convertToLower(string &tempString)  
{
	unsigned int i;
	for (i = 0; i < tempString.length(); i++) 
	tempString[i] = tolower(tempString[i]);
	tempString[i] = '\0'; 
} 

Your while loop condition says that choice must be y or Y in order for it to run again, so your exit statement would never run. I moved it to the end of the program, but it could also have been placed at the end of the loop just after choice is provided by the user...
The last thing I caught is that your final answer " hawaii" has a space in front which means answering "hawaii" will still be wrong. just remove that extra space.
Fun program, my suggestion for moving foreward is to set it up to read questions and answers from a file so that they can be changed without compiling the whole program.
Nice work.

[vasncode]

You've actually helped me so much, thank you.

[newbieg]

Glad I could help.

[Ganado]

vasncode, you should remove line 284 (77 in newbieg's post). It's entirely redundant (and before C++11 was possibly undefined behavior).

https://en.cppreference.com/w/cpp/string/basic_string/operator_at

If pos == size(), a reference to the character with value CharT() (the null character) is returned.
For the first (non-const) version, the behavior is undefined if this character is modified to any value other than CharT() .
(since C++11)

And indent the statement in the loop.