Loop not stopping when it's suppose to

[NeptuneK]

Hello. I'm trying to work on this code for a school project that calculates the earnings and streams of multiple songs. I can't get the loop to stop when it reaches the number of songs a user types in. How do I fix the problem?

// This program lets a user upload as many songs as they want or upload a single song.

#include <iostream>
#include <string>
#include <iomanip>
#include <cstdlib>
#include <ctime>

using namespace std;

int main()
{
int option;
int label;
int num;
double views;
int choice;
string artist;
string song;
int total;


//the program asks the user if they want to upload only one song or multiple songs

cout << " Wlecome to the CPCC uploading service!" << endl;

do
{

cout << "Please choose from the following menu options by entering a number 1-3." << endl;


cout << "1. Upload one song to a streaming service" << endl;
cout << "2. Upload multiple songs to a streaming service" << endl;
cout << "3. End program" << endl;

cin >> option;

if (option == 3)
{
cout << "Thank you for using the CPCC uploading service. Goodbye." << endl;
}

else if (option >= 4)
{
cout << "Error: number entered is not an option for options 1-3" << endl;
}


// TIDAl= 0.0125, Amazon= 0.00402, AM(Apple Music)= 0.00737, Spotify= 0.00437, Youtube= 0.00069
double Tidal= 0.0125, Amazon= 0.00402, AM= 0.00737, Spotify= 0.00437, Youtube= 0.00069;

// Option 1 is if a user wants to upload only one song.
if (option == 1)
{
cout << "which streaming service do you want to upload your song to?" << endl;
cout << "1: TIDAL" << endl;
cout << "2: Amazon" << endl;
cout << "3: Apple Music" << endl;
cout << "4: Spotify" << endl;
cout << "5: Youtube" << endl;

cout << "Please enter a number 1-5 to select which streaming service you want to upload your song to." << endl;

cin >> choice;

if (choice == 1)
{


cout << " How many views does the song have? " << endl;
cin >> views;
cin.ignore();

cout << " What is the Artist's name?" << endl;
getline(cin,artist);
cout << " What song from the artist do you want to upload? " << endl;
getline(cin,song);


cout << "Song Name: " << song << endl;
cout << "Artist's Name: " << artist << endl;
cout << "Streaming Service: " << "TIDAL" << endl;
cout << "Money Made $ " << (Tidal * views) << endl;


}

if (choice == 2)
{

cout << " How many views does the song have? " << endl;
cin >> views;
cin.ignore();

cout << " What is the Artist's name?" << endl;
getline(cin,artist);
cout << " What song from the artist do you want to upload?" << endl;
getline(cin,song);

cout << "Song Name: " << song << endl;
cout << "Artist's Name: " << artist << endl;
cout << "Streaming Service: " << "Amazon" << endl;
cout << "Money Made $ " << (Amazon * views) << endl;

}

if (choice == 3)
{

cout << " How many views does the song have? " << endl;
cin >> views;
cin.ignore();

cout << " What is the Artist's name? " << endl;
getline(cin,artist);
cout << " What song from the artist do you want to upload? " << endl;
getline(cin,song);

cout << "Song Name: " << song << endl;
cout << "Artist's Name: " << artist << endl;
cout << "Streaming Service: " << "Apple Music" << endl;
cout << "Money Made $ " << (AM * views) << endl;

}

if (choice == 4)
{

cout << " How many views does the song have? " << endl;
cin >> views;
cin.ignore();

cout << " What is the Artist's name" << endl;
getline(cin,artist);
cout << " What song from the artist do you want to upload?" << endl;
getline(cin,song);

cout << "Song Name: " << song << endl;
cout << "Artist's Name: " << artist << endl;
cout << "Streaming Service: " << "Spotify" << endl;
cout << "Money Made $ " << (Spotify * views);

}

if (choice == 5)
{

cout << " How many views does the song have? " << endl;
cin >> views;
cin.ignore();
cout << " What is the Artist's name? " << endl;
getline(cin,artist);
cout << " What song from the artist do you want to upload? " << endl;
getline(cin,song);

cout << "Song Name: " << song << endl;
cout << "Artist's Name: " << artist << endl;
cout << "Streaming Service: " << "Youtube" << endl;
cout << "Money Made $ " << (Youtube * views);
}


}

// option 2 is where the user can upload multiple songs. Another option is added where the user can end the program after they upload their songs.

else if (option == 2 )
{
cout << "which streaming service will you use to upload your songs?" << endl;

cout << "1: TIDAL" << endl;
cout << "2: Amazon" << endl;
cout << "3: Apple Music" << endl;
cout << "4: Spotify" << endl;
cout << "5: Youtube" << endl;

cin >> choice;

cout << "How many songs do you want to upload?" << endl;
cin >> num;

if (num <=0 )
{
cout << "Error: the number of songs you want to upload must be greater than 0." << endl;
}

cout << "Please enter 1 or 2 to select the type of distribution to use for your songs." << endl;

cout << "1: Major Label" << endl;
cout << "2: Independent Label" << endl;

cin >> label;



srand(num);


for(int song = 0; song < num; song++)
{
if(label == 1)
{
// major labels generate between 100,000 and 50,000,000 streams
num = 100000 + rand() % 49900000;
}
else
{
// indie labels generate between 10,000 and 1,000,000 streams
num = 10000 + rand() % 990000;
}

// add to the total streams
total += num;

// output the song number and the streams
cout << "\t Song #" << (song + 1) << ": \t" << num << " streams" << endl;
}
return 0;

}



}while (option !=3);






return 0;
}

[jonnin]

welcome!
You may have noticed other posts with code have it formatted and indented like in a code editor. To do that, select the code, and mash the <> button on the sidebar or type code and /code inside [] pairs. Once we can read it better, the problem should be easy to spot and fix.

edit: found it anyway. you modify num inside the loop, changing it from the # of songs to some gibberish big value. It probably ends eventually, but it would take months to get there typing all that crap in :) This would also break the 'total' variable

srand num is cute but probably not effective as the random numbers would be the same every time you did 3 songs or every time you did 10 songs etc. The same seed gives the same values, which is useful for some code, but not useful for randomized code. Use time(0) or better, the <random> header and high quality random tools of modern C++ (rand is from C and a low quality relic).

[NeptuneK]

What do you mean by that? just change num to something else?

[jonnin]

perhaps have a variable called numsongs that you use for the number of songs. num is not a descriptive name, and its difficult to guess what you want it to mean from its name. "number" of course, but what number, what does it represent? Its a mystery ... so I would rename num to something meaningful, whatever it should be, and add another one for num_songs or whatever words you want

then it looks roughly like
cout how many songs...
cin >> numsongs;

for(int i{}; i < numsongs; i++)
{
randonumber = something;
etc;
}

[NeptuneK]

I still have the infinite loop problem.

for(int i{}; i < numsongs; i++)
{
randomnumber = something;
etc;


if (label == 1)
{
// major labels generate between 100,000 and 50,000,000 streams
numsongs = 100000 + rand() % 49900000;
}
else if (label ==2 )
{
// indie labels generate between 10,000 and 1,000,000 streams
numsongs = 10000 + rand() % 990000;
}

// add to the total streams
total += numsongs;

// output the song number and the streams
cout << "\t Song #" << (amount + 1) << ": \t" << numsongs << " streams" << endl;


(amount <= numsongs);


}

[NeptuneK]

If I just have the new line, it won't generate any random number for the stream. Maybe should use time?

[NeptuneK]

nope, it didn't work.

[George P]

PLEASE learn to use code tags, they make reading and commenting on source code MUCH easier.

How to use code tags: http://www.cplusplus.com/articles/jEywvCM9/

There are other tags available.

How to use tags: http://www.cplusplus.com/articles/z13hAqkS/

HINT: you can edit your post and add code tags.

Some formatting & indentation would not hurt either

[seeplus]

As the original formatted:

#include <iostream>
#include <string>
#include <iomanip>
#include <cstdlib>
#include <ctime>

using namespace std;

int main() {
	int option;
	int label;
	int num;
	double views;
	int choice;
	string artist;
	string song;
	int total;

	//the program asks the user if they want to upload only one song or multiple songs

	cout << " Wlecome to the CPCC uploading service!" << endl;

	do {
		cout << "Please choose from the following menu options by entering a number 1-3." << endl;

		cout << "1. Upload one song to a streaming service" << endl;
		cout << "2. Upload multiple songs to a streaming service" << endl;
		cout << "3. End program" << endl;

		cin >> option;

		if (option == 3) {
			cout << "Thank you for using the CPCC uploading service. Goodbye." << endl;
		}
		else if (option >= 4) {
			cout << "Error: number entered is not an option for options 1-3" << endl;
		}

		// TIDAl= 0.0125, Amazon= 0.00402, AM(Apple Music)= 0.00737, Spotify= 0.00437, Youtube= 0.00069
		double Tidal = 0.0125, Amazon = 0.00402, AM = 0.00737, Spotify = 0.00437, Youtube = 0.00069;

		// Option 1 is if a user wants to upload only one song.
		if (option == 1) {
			cout << "which streaming service do you want to upload your song to?" << endl;
			cout << "1: TIDAL" << endl;
			cout << "2: Amazon" << endl;
			cout << "3: Apple Music" << endl;
			cout << "4: Spotify" << endl;
			cout << "5: Youtube" << endl;

			cout << "Please enter a number 1-5 to select which streaming service you want to upload your song to." << endl;

			cin >> choice;

			if (choice == 1) {
				cout << " How many views does the song have? " << endl;
				cin >> views;
				cin.ignore();

				cout << " What is the Artist's name?" << endl;
				getline(cin, artist);
				cout << " What song from the artist do you want to upload? " << endl;
				getline(cin, song);

				cout << "Song Name: " << song << endl;
				cout << "Artist's Name: " << artist << endl;
				cout << "Streaming Service: " << "TIDAL" << endl;
				cout << "Money Made $ " << (Tidal * views) << endl;
			}

			if (choice == 2) {
				cout << " How many views does the song have? " << endl;
				cin >> views;
				cin.ignore();

				cout << " What is the Artist's name?" << endl;
				getline(cin, artist);
				cout << " What song from the artist do you want to upload?" << endl;
				getline(cin, song);

				cout << "Song Name: " << song << endl;
				cout << "Artist's Name: " << artist << endl;
				cout << "Streaming Service: " << "Amazon" << endl;
				cout << "Money Made $ " << (Amazon * views) << endl;
			}

			if (choice == 3) {
				cout << " How many views does the song have? " << endl;
				cin >> views;
				cin.ignore();

				cout << " What is the Artist's name? " << endl;
				getline(cin, artist);
				cout << " What song from the artist do you want to upload? " << endl;
				getline(cin, song);

				cout << "Song Name: " << song << endl;
				cout << "Artist's Name: " << artist << endl;
				cout << "Streaming Service: " << "Apple Music" << endl;
				cout << "Money Made $ " << (AM * views) << endl;
			}

			if (choice == 4) {
				cout << " How many views does the song have? " << endl;
				cin >> views;
				cin.ignore();

				cout << " What is the Artist's name" << endl;
				getline(cin, artist);
				cout << " What song from the artist do you want to upload?" << endl;
				getline(cin, song);

				cout << "Song Name: " << song << endl;
				cout << "Artist's Name: " << artist << endl;
				cout << "Streaming Service: " << "Spotify" << endl;
				cout << "Money Made $ " << (Spotify * views);
			}

			if (choice == 5) {
				cout << " How many views does the song have? " << endl;
				cin >> views;
				cin.ignore();

				cout << " What is the Artist's name? " << endl;
				getline(cin, artist);

				cout << " What song from the artist do you want to upload? " << endl;
				getline(cin, song);

				cout << "Song Name: " << song << endl;
				cout << "Artist's Name: " << artist << endl;
				cout << "Streaming Service: " << "Youtube" << endl;
				cout << "Money Made $ " << (Youtube * views);
			}
		}

		// option 2 is where the user can upload multiple songs. Another option is added where the user can end the program after they upload their songs.

		else if (option == 2) {
			cout << "which streaming service will you use to upload your songs?" << endl;

			cout << "1: TIDAL" << endl;
			cout << "2: Amazon" << endl;
			cout << "3: Apple Music" << endl;
			cout << "4: Spotify" << endl;
			cout << "5: Youtube" << endl;

			cin >> choice;

			cout << "How many songs do you want to upload?" << endl;
			cin >> num;

			if (num <= 0) {
				cout << "Error: the number of songs you want to upload must be greater than 0." << endl;
			}

			cout << "Please enter 1 or 2 to select the type of distribution to use for your songs." << endl;

			cout << "1: Major Label" << endl;
			cout << "2: Independent Label" << endl;

			cin >> label;

			srand(num);

			for (int song = 0; song < num; song++) {
				if (label == 1) {
					// major labels generate between 100,000 and 50,000,000 streams
					num = 100000 + rand() % 49900000;
				} else {
					// indie labels generate between 10,000 and 1,000,000 streams
					num = 10000 + rand() % 990000;
				}

				// add to the total streams
				total += num;

				// output the song number and the streams
				cout << "\t Song #" << (song + 1) << ": \t" << num << " streams" << endl;
			}
			return 0;
		}

	} while (option != 3);

	return 0;
}

This program is begging to use switch statements and some functions. main() is way too long.

Perhaps for the stream income code:

			//srand(num);

			for (int song = 0; song < num; ++song) {
				const int generate {label == 1 ? 100000 + rand() % 49900000 : 10000 + rand() % 990000};

				// add to the total streams
				total += generate;

				// output the song number and the streams
				cout << "\t Song #" << (song + 1) << ": \t" << generate << " streams" << endl;
			}
			//return 0;