How to Implement Rule

[JohnIsNotAMayor]

I have this project where we have to take a rule off of this website https://uic.edu/apps/strong-password/ and calculate the number of points for each Column and we have to do the first 5 of each section. I was able to do the number of characters one pretty easily but I was wondering if somebody could give me advice on how to do the one for uppercase letters. The code I have done so far is done below.

  #include <iostream>
#include <string>
using namespace std;

class Validatestring 
{
    public:
    string password; 
    int rate;
    int count;
    int bonus;
    virtual int GetCount()=0;
    virtual void CalculateRate()=0
};

class NumberOfCharacters : public Validatestring
{
    public:
    int GetCount();
    void CalculateRate();
};

int NumberOfCharacters::GetCount()
{
    return password.length();
}

void NumberOfCharacters::CalculateRate()
{
bonus = GetCount()*4;
}

[thmm]

on how to do the one for uppercase letters

Do you want to count the number of uppercase letters?

If yes lust loop through all the characters in the string and check if the character is usppercase https://www.cplusplus.com/reference/cctype/isupper/
or if allowed you could use std::count_if
https://www.cplusplus.com/reference/algorithm/count_if/

[seeplus]

Well that website reference doesn't work - not found.

[JohnIsNotAMayor]

I will try the looping. Thank you for the suggestion.

[JohnIsNotAMayor]

Well that website reference doesn't work - not found.

The website link has been corrected and updated.

[George P]

The link is still 404. This site's link processor get confused easily when adding extra characters to the end of a link.

Either forget enclosing a link in parentheses, OR use an empty set of format tags between the end of the link and the closing ).

Like this: (https://uic.edu/apps/strong-password/). {I used the teletype tags, no visual indication used}.

[JohnIsNotAMayor]

The link is still 404. This site's link processor get confused easily when adding extra characters to the end of a link.

It should be fixed now.

[JohnIsNotAMayor]

I can't get the main to run, any suggestions?

#include <iostream>
#include <string>
using namespace std;

class Validatestring
{
public:
    string password;
    int rate;
    int count;
    int bonus;
    virtual int GetCount() = 0;
    virtual void CalculateRate() = 0;
};

class myabstractclass
{
public:
    string password;
    myabstractclass() {};
    void setpassword(string s) { password = s; };
};

class NumberOfCharacters : public Validatestring
{
public:
    int GetCount();
    void CalculateRate();
};

int NumberOfCharacters::GetCount()
{
    return password.length();
}

void NumberOfCharacters::CalculateRate()
{
    bonus = GetCount() * 4;
}


class UpperCase : public myabstractclass
{
public:
    int GetUpperCase()
    {
        int counter = 0;
        for (int i = 0; i < password.length(); i++)
            if (isupper(password[i]))
                counter++;
        return counter;
    }

    int GetBonus()
    {
        int x = GetUpperCase();
        return ((password.length() - x) * 2);
    }
};

void main()
{
    UpperCase U;
    U.password = "NickThompson";
    U.GetUpperCase();
    cout << U.GetBonus << endl;
}

[thmm]

L61: main must return int
L66: you forgot the ()

[JohnIsNotAMayor]

SMH. I've been trying to fix it for an hour.

[JohnIsNotAMayor]

Any ideas on how I could do letters only formula from this website https://uic.edu/apps/strong-password/

This is what I have so far:

#include <iostream>
#include <string>
using namespace std;

class Validatestring
{
public:
    string password;
    int rate;
    int count;
    int bonus;
    virtual int GetCount() = 0;
    virtual void CalculateRate() = 0;
};

class myabstractclass
{
public:
    string password;
    myabstractclass() {};
    void setpassword(string s) { password = s; };
};

class NumberOfCharacters : public Validatestring
{
public:
    int GetCount();
    void CalculateRate();
};

int NumberOfCharacters::GetCount()
{
    return password.length();
}

void NumberOfCharacters::CalculateRate()
{
    bonus = GetCount() * 4;
}


class UpperCase : public myabstractclass
{
public:
    int GetUpperCase()
    {
        int counter = 0;
        for (int i = 0; i < password.length(); i++)
            if (isupper(password[i]))
                counter++;
        return counter;
    }

    int GetUpperBonus()
    {
        int x = GetUpperCase();
        return ((password.length() - x) * 2);
    }
};

class LowerCase : public myabstractclass
{
public:
    int GetLowerCase()
    {
        int counter = 0;
        for (int i = 0; i < password.length(); i++)
            if (islower(password[i]))
                counter++;
        return counter;
    }

    int GetLowerBonus()
    {
        int x = GetLowerCase();
        return ((password.length() - x) * 2);
    }
};

class Numbers : public myabstractclass
{
public:
    int GetNumbers()
    {
        int counter = 0;
        for (int i = 0; i < password.length(); i++)
            if (isdigit(password[i]))
                counter++;
        return counter;
    }

    int GetNumberBonus()
    {
        int x = GetNumbers();
        return (x * 4);
    }
};

class Symbols : public myabstractclass
{
public:
    int GetSymbols()
    {
        int counter = 0;
        for (int i = 0; i < password.length(); i++)
            if (ispunct(password[i]))
                counter++;
        return counter;
    }

    int GetSymbolBonus()
    {
        int x = GetSymbols();
        return (x * 6);
    }
};

[seeplus]

I could do letters only formula

For info re the various isxxx(), see https://en.cppreference.com/w/cpp/string/byte

isalpha() seems to be what is required.

Note that you can use range-for. Instead of say:

int GetUpperCase()
    {
        int counter = 0;
        for (int i = 0; i < password.length(); i++)
            if (isupper(password[i]))
                counter++;
        return counter;
    }

You could have:

size_t GetUpperCase() {
	size_t counter {};

	for (const unsigned char ch : password)
		counter += isupper(ch);

	return counter;
}

Note that .length() returns a type size_t and not a type int.

[JohnIsNotAMayor]

I tried your recommendation by doing the code below, but it's still not quite coming out quite right. I got -2 instead of 0. Any recommendations or solutions? Do y'all think I need an if else statement?

class LettersOnly : public myabstractclass
{
public:
size_t GetLettersOnly() {
    size_t counter{};

    for (const unsigned char ch : password)
        counter += isupper(ch);

    return counter;
}

int GetLettersOnlyBonus()
    {
        int x = GetLettersOnly();
        return -(x);
    }
};

[mbozzi]

cppreference wrote:

isupper returns a nonzero value only for the uppercase letters (ABCDEFGHIJKLMNOPQRSTUVWXYZ).

https://en.cppreference.com/w/cpp/string/byte

"Nonzero" does not mean "one".

size_t GetLettersOnly() {
    size_t counter{};

    for (const unsigned char ch : password)
        counter += isupper(ch) == 0? 0: 1;

    return counter;
}

You may prefer to use the built-in operator! twice as follows

size_t GetLettersOnly() {
    size_t counter{};

    for (const unsigned char ch : password)
        counter += !!isupper(ch);

    return counter;
}

The effects are the same.

[JohnIsNotAMayor]

I am not quite sure what you mean. Would you be able to show me how I should put it into the code?

[mbozzi]

I am not quite sure what you mean. Would you be able to show me how I should put it into the code?

No. I have shown enough already.

[JohnIsNotAMayor]

Is this what you meant? I have it working but it is still bringing back a value of -2 instead of 0.

class LettersOnly : public myabstractclass
{
public:
    int GetLettersOnly()
    {
         size_t GetLettersOnly();
         {
            size_t counter{};

            for (const unsigned char ch : password)
                counter += isupper(ch) == 0 ? 0 : 1;

            return counter;
        }
    }

    int GetLettersOnlyBonus()
    {
        int x = GetLettersOnly();
        return (- (x));
    }
};

[JohnIsNotAMayor]

Thanks for the help guys! I didn't figure it out but I appreciate the help anyways!

[seeplus]

For VS2022:

#include <iostream>
#include <cctype>
#include <string>

size_t GetUpperOnly(const std::string& password) {
	size_t counter {};

	for (const unsigned char ch : password)
		counter += std::isupper(ch);

	return counter;
}

int main() {
	const std::string pass {"aBcDeF"};

	std::cout << GetUpperOnly(pass) << '\n';
}

Displays:

3

If your compiler doesn't return 1 or 0 for isxxx(), then generalised:

#include <iostream>
#include <cctype>
#include <string>

size_t GetUpperOnly(const std::string& password) {
	size_t counter {};

	for (const unsigned char ch : password)
		counter += std::isupper(ch) ? 1 : 0;

	return counter;
}

int main() {
	const std::string pass {"aBcDeF"};

	std::cout << GetUpperOnly(pass) << '\n';
}

For just alpha chars, then:

#include <iostream>
#include <cctype>
#include <string>

size_t GetLettersOnly(const std::string& password) {
	size_t counter {};

	for (const unsigned char ch : password)
		counter += std::isalpha(ch) ? 1 : 0;

	return counter;
}

int main() {
	const std::string pass {"(B!c$eF"};

	std::cout << GetLettersOnly(pass) << '\n';
}

Which displays:

4