functions

[MaxGreen]

Lads, need your help over here, beside all other tasks that works fine, it was given to write a code using a single function which has to sort in ascending order and descending order the elements of an array.

I've done something but my boolean variable won't work properly, it works just for ascending or descending order, but not both at the same time, please enlighten me how to correctly use both statements of bool in order to display ascending and descending order.s (line 82-107 and line 139-140 )
Many thanks!
btw I use IDE, DEV-C++ for now...

#include <iostream>
 #include <cstdlib>
 #include <ctime>
 #include <cstring>
 #include <conio.h>
 #include <iomanip>
 #include <windows.h>

 using namespace std;

int main()


void insertV(int z[], int n) //void insertV(int v[100], int n)

 {
 for(int i=0; i<n; i++)
 {
 z[i]=rand()%10;
 }
 }


 void showV(int z[], int n) //display (int v[100], int n)

 {
 for(int i=0; i<n; i++)
 {
 cout<<setw(3)<<z[i];
 }
 }


 int sumaV(int z[], int n) //array sum

 {
 int s=0;
 for(int i=0; i<n; i++)
 {
 s+=z[i];
 }
 return s;
 }
 
 

 int  maxV(int z[], int n) // maximum element in array 

 {
 int m=z[0];
 for(int i=0; i<n; i++)
 {
 if (m<z[i]) m=z[i];
 }
return m;
 }


int maxp(int z[],int n) //maximum odd value;
{
	int mp=z[0];
	for(int i=0; i<n; i++)
	{
		 if (z[i] %2==0 && mp < z[i]) mp=z[i];
	}
	return mp;
}


int mini(int z[],int n) //minimum even value;
{
	int mi=z[0];
	for(int i=0; i<n; i++)
	{
		 if (z[i] %2 !=0 && mi > z[i]) mi=z[i];
	}
	return mi;
}
	
	
	
void ad(int z[],int n, bool q)// ascending & descending order
{

bool x=true;
 while(x)
{  
  x=false;  
  
  
    for( int i=0,temp; i < n-1; i++)
    {
    	if(q){
		
     if(z[i] < z[i+1] )
       {
            x=true;
          temp = z[i];
          z[i] = z[i+1];
          z[i+1] = temp; }}
		  
		   if(z[i] > z[i+1] )
       {
            x=true;
          temp = z[i];
          z[i] = z[i+1];
          z[i+1] = temp;       
} 
}       
}
}

 {

 srand(time(0));


 int v[100],n=insertINT("\n Enter n=");


 insertV(v,n);

 showV(v,n);


 int sv=sumaV(v,n);

 cout<<" sv="<<sv<<endl;

 int m=maxV(v,n);
 cout<<" max="<<m<<endl;
 
 int pi=maxp(v,n);
 cout<<" maxeven="<<pi<<endl;
 
 int ci=mini(v,n);
 cout<<" minodd="<<ci<<endl;
 
  ad(v,n,true);      //I am trying to somehow force the app to check both true 
  ad(v,n,false);     //and false conditions 
  showV(v,n);

   return 0;

 }

[Repeater]

a single function which has to sort in ascending order and descending order the elements of an array.

What does this mean?

If the input is, for example, { 3 , 8, 2, 54 , -3}

and your function sorts this into ascending and descending order, what's the correct output?

{-3, 2, 3, 8, 54} is ascending.
{54, 8, 3, 2, -3} is descending.

What is "ascending and descending order"?

[MaxGreen]

@Reapeater.

It should display both orders using the same function, both algorithms should be included in 1 function.

[seeplus]

C++ doesn't allow local functions. So main() should be after all the other functions have been defined.

What is "ascending and descending order"?

ascending/descending order depending upon value of bool q in ad()

- for maxV(), i should start at 1 not 0 as m is already z[0]

- for maxp(), mini() your starting value is incorrect. for maxp() (max odd), if the first number is even and less than all the other odd numbers, then it will incorrectly return this even number. Similar for mini (minimum even)

Also z %2==0 is [i]true if z is [i]even, not odd! For maxp(), mini() the condition tests need to be reversed.

[MaxGreen]

thanks guys, I guess my English is too bad in order to briefly explain what I was meaning to do, the problem was that my function " void ad(int z[],int n, bool q)" line 82-107 had some code mistakes, now I've handled it, using it right now it will display ascending and descending order of array.

void ad(int z[],int n, bool q)
{

bool x=true;
 while(x)
{  
  x=false;  
  
  if(q){
    for( int i=0,temp; i < n-1; i++)
    {
	
     if(z[i] < z[i+1] )
       {
            x=true;
          temp = z[i];
          z[i] = z[i+1];
          z[i+1] = temp; }}}
		  
		   else {
		   
		   for( int i=0,temp; i < n-1; i++)
           {
		   if (z[i] > z[i+1] ){
            x=true;
          temp = z[i];
          z[i] = z[i+1];
          z[i+1] = temp;       
}       
}
}
}
}
.......

  ad(v,n,true);
  showV(v,n);
  cout<<endl;
  ad(v,n,false);
  showV(v,n);

[seeplus]

ad() can be simplified. Consider:

#include <iostream>
#include <cstdlib>
#include <ctime>
#include <iomanip>
#include <limits>

using namespace std;

int insertINT(const char* mes)
{
	int value;

	cout << mes;
	cin >> value;

	return value;
}

void insertV(int z[], int n)
{
	for (int i = 0; i < n; ++i)
		z[i] = rand() % 100;
}

void showV(int z[], int n)
{
	for (int i = 0; i < n; ++i)
		cout << setw(3) << z[i];

	cout << '\n';
}

int sumaV(int z[], int n) //array sum
{
	int s = 0;

	for (int i = 0; i < n; ++i)
		s += z[i];

	return s;
}

int maxV(int z[], int n) // maximum element in array
{
	int m = z[0];

	for (int i = 1; i < n; ++i)
		if (m < z[i])
			m = z[i];

	return m;
}

int maxp(int z[], int n) //maximum odd value;
{
	int mp = numeric_limits<int>::min();

	for (int i = 0; i < n; i++)
		if (z[i] % 2 != 0 && mp < z[i])
			mp = z[i];

	return mp;
}

int mini(int z[], int n) //minimum even value;
{
	int mi = numeric_limits<int>::max();

	for (int i = 0; i < n; i++)
		if (z[i] % 2 == 0 && mi > z[i])
			mi = z[i];

	return mi;
}

void ad(int z[], int n, bool q)
{
	bool x = true;

	while (x) {
		x = false;

		for (int i = 0, temp; i < n - 1; ++i)
			if (q ? z[i] < z[i + 1] : z[i] > z[i + 1]) {
				x = true;
				temp = z[i];
				z[i] = z[i + 1];
				z[i + 1] = temp;
			}
	}
}

int main()
{
	srand(time(0));

	int v[100], n = insertINT("\n Enter n=");

	insertV(v, n);
	showV(v, n);

	cout << " sv=" << sumaV(v, n) << endl;
	cout << " max=" << maxV(v, n) << endl;
	cout << " maxodd=" << maxp(v, n) << endl;
	cout << " mineven=" << mini(v, n) << endl;

	ad(v, n, true);
	showV(v, n);

	ad(v, n, false);
	showV(v, n);
}