multiplayer space shooter problems

[scourtheweb007]

Write your question here.
I found a space shooter program and decided to tweak it. I tried to make it multiplayer. I can't figure out how to make player 2 (the top space ship) bullets to shoot downward. Also, I want both player 1 and 2 to be hostile to each other, while the enemies go up and down. Any help would be appreciated. thanks in advance.

#include <iostream>
#include <conio.h>
#include <dos.h>
#include <windows.h>
#include <time.h>

#define SCREEN_WIDTH 90
#define SCREEN_HEIGHT 26
#define WIN_WIDTH 70
#define MENU_WIDTH 20
#define GAP_SIZE 7
#define Enemy_DIF 45

using namespace std;

HANDLE console = GetStdHandle(STD_OUTPUT_HANDLE);
COORD CursorPosition;

int enemyY[3];
int enemyX[3];
int enemyFlag[3];
char bird[3][5] = {' ',' ','±',' ',' ',
				   '|','±','±','±','|',
				   '±','±','±','±','±' };

char bird2[3][5] = { '±','±','±','±','±',
				     '|','±','±','±','|',
					 ' ',' ','±',' ',' ' };

int birdPos2 = WIN_WIDTH / 2;
int birdPos = WIN_WIDTH / 2;
int score = 0;
int bullets[20][4];
int bulletsLife[20];
int bIndex = 0;

void gotoxy(int x, int y) {
	CursorPosition.X = x;
	CursorPosition.Y = y;
	SetConsoleCursorPosition(console, CursorPosition);

}

void setcursor(bool visible, DWORD size) {
	if (size == 0)
		size = 20;

	CONSOLE_CURSOR_INFO lpCursor;
	lpCursor.bVisible = visible;
	lpCursor.dwSize = size;
	SetConsoleCursorInfo(console, &lpCursor);

}
void drawBorder() {
	for (int i = 0; i < SCREEN_HEIGHT+2; i++) {
		gotoxy(0, i); cout << "±±";
		gotoxy(SCREEN_WIDTH, i); cout << "±";
	}
	for (int i = 0; i < SCREEN_HEIGHT; i++) {
		gotoxy(WIN_WIDTH, i); cout << "±";
	}
	for (int i = 0; i < SCREEN_WIDTH; i++) {
		gotoxy(i, 0); cout << "±";
		gotoxy(i, SCREEN_HEIGHT); cout << "±";
		
	}	
}
void genEnemy(int ind) {
	enemyX[ind] = 3 + rand() % (WIN_WIDTH - 10);
}
void drawEnemy(int ind) {
	if (enemyFlag[ind] == true) {
		gotoxy(enemyX[ind], enemyY[ind]);	cout << ".**.";
		gotoxy(enemyX[ind], enemyY[ind]+1);	cout << "****";
		gotoxy(enemyX[ind], enemyY[ind]+2);	cout << "****";
		gotoxy(enemyX[ind], enemyY[ind]+3);	cout << ".**.";
	}
}
void eraseEnemy(int ind) {
	if (enemyFlag[ind] == true) {
		gotoxy(enemyX[ind], enemyY[ind]); cout << "    ";
		gotoxy(enemyX[ind], enemyY[ind] + 1);cout << "    ";
		gotoxy(enemyX[ind], enemyY[ind] + 2);cout << "    ";
		gotoxy(enemyX[ind], enemyY[ind] + 3);cout << "    ";
	}
}
void resetEnemy(int ind) {
	eraseEnemy(ind);
	enemyY[ind] = 4;
	genEnemy(ind);
}
void genBullet() {
	bullets[bIndex][0] = 22;
	bullets[bIndex][1] = birdPos;
	bullets[bIndex][2] = 22;
	bullets[bIndex][3] = birdPos+4;
	bIndex++;
	if (bIndex == 20)
		bIndex = 0;
}
void genBullet2() {
	bullets[bIndex][0] = 4;
	bullets[bIndex][1] = birdPos2;
	bullets[bIndex][2] = 4;
	bullets[bIndex][3] = birdPos2 + 4;
	bIndex++;
	if (bIndex == 20)
		bIndex = 0;
}

void moveBullet() {
	for (int i = 0; i < 20; i++) {
		if (bullets[i][0] > 2)
			bullets[i][0]--;
		else
			bullets[i][0] = 0;

		if (bullets[i][2] > 2)
			bullets[i][2]--;
		else
			bullets[i][2] = 0;


	}
}
void drawBullets() {
	for (int i = 0; i < 20; i++) {
		if (bullets[i][0] > 1) {
			gotoxy(bullets[i][1], bullets[i][0]); cout << ".";
			gotoxy(bullets[i][3], bullets[i][2]); cout << ".";
		}
	}
}
void eraseBullets() {
	for (int i = 0; i < 20; i++) {
		if (bullets[i][0] >= 1) {
			gotoxy(bullets[i][1], bullets[i][0]); cout << " ";
			gotoxy(bullets[i][3], bullets[i][2]); cout << " ";
		}
	}
}
void eraseBullet(int i) {
	gotoxy(bullets[i][1], bullets[i][0]); cout << " ";
	gotoxy(bullets[i][3], bullets[i][2]); cout << " ";
}
void drawBird() {
	for (int i = 0; i < 3; i++) {
		for (int j = 0; j < 5; j++) {
			gotoxy(j + birdPos, i + 22); cout << bird[i][j];
		}
	}
}
void drawBird2() {
	for (int i = 0; i < 3; i++) {
		for (int j = 0; j < 5; j++) {
			gotoxy(j + birdPos2, i + 2); cout << bird2[i][j];
		}
	}
}
void eraseBird() {
	for (int i = 0; i < 3; i++) {
		for (int j = 0; j < 5; j++) {
			gotoxy(j + birdPos, i + 22); cout << " ";
		}
	}
}
void eraseBird2() {
	for (int i = 0; i < 3; i++) {
		for (int j = 0; j < 5; j++) {
			gotoxy(j + birdPos2, i+2); cout << " ";
		}
	}
}

int collision() {
	if (enemyY[0] + 4 >= 23) {
		if (enemyX[0] + 4 - birdPos >= 0 && enemyX[0] + 4 - birdPos < 8) {
			return 1;
		}
	}
	return 0;
}
int bulletHit() {
	for (int i = 0; i < 20; i++) {
		for (int j = 0; j < 4; j += 2) {
			if (bullets[i][j] != 0) {
				if (bullets[i][j] >= enemyY[0] && bullets[i][j] <= enemyY[0] + 4) {
					if (bullets[i][j+1] >= enemyX[0] && bullets[i][j + 1] <= enemyX[0] + 4) {
						eraseBullet(i);
						bullets[i][j] = 0;
						resetEnemy(0);
						return 1;
					}
				}
				if (bullets[i][j] >= enemyY[1] && bullets[i][j] <= enemyY[1] + 4) {
					if (bullets[i][j+1] >= enemyX[1] && bullets[i][j + 1] <= enemyX[1] + 4) {
						eraseBullet(i);
						resetEnemy(1);
						bullets[i][j] = 0;
						return 1;
					}
				}
			}
		}
	}
	return 0;
}
void gameOver() {
	system("cls");
	cout << endl;
	cout << "\t\t---------------------------" << endl;
	cout << "\t\t--------GAME OVER----------" << endl;
	cout << "\t\t---------------------------" << endl << endl;
	cout << "\t\tPress any key to go back to menu.";
	_getch();
}
void updateScore() {
	gotoxy(WIN_WIDTH + 7, 5); cout << "Score: " << score << endl;
}
void instructions() {
	system("cls");
	cout << "Controls";
	cout << "\n---------------------";
	cout << "\n Player 1 controls are 'a','d', and spacebar";
	cout << "\n Plater 2 controls are 'j, 'l', and 'k'";
	cout << "\n Press spacebar or 'k to make the ships shoot";
	cout << "\n Press any key to go back to menu";
	_getch();
}
void play() {
	birdPos = -1 + WIN_WIDTH / 2;
	birdPos2 = -1 + WIN_WIDTH / 2;
	score = 0;
	enemyFlag[0] = 1;
	enemyFlag[1] = 1;
	enemyY[0] = enemyY[1] = 4;
	
	for (int i = 0; i < 20; i++) {
		bullets[i][0] = bullets[i][1] = 0;
	}

	system("cls");
	drawBorder();
	genEnemy(0);
	genEnemy(1);
	updateScore();

	gotoxy(WIN_WIDTH + 5, 2); cout << "MULTIPLAYER: ";
	gotoxy(WIN_WIDTH + 5, 3); cout << "SPACE SHOOTER ";
	gotoxy(WIN_WIDTH + 6, 4); cout << "-----------";
	gotoxy(WIN_WIDTH + 6, 6); cout << "-----------";
	gotoxy(WIN_WIDTH + 7, 12); cout << "CONTROL";
	gotoxy(WIN_WIDTH + 7, 13); cout << "Player 1: ";
	gotoxy(WIN_WIDTH + 2, 14); cout << "A Key - Left";
	gotoxy(WIN_WIDTH + 2, 15); cout << "D Key - Right";
	gotoxy(WIN_WIDTH + 2, 16); cout << "Spacebar = shoot";
	gotoxy(WIN_WIDTH + 7, 18); cout << "Player 2: ";
	gotoxy(WIN_WIDTH + 2, 19); cout << "J Key - Left";
	gotoxy(WIN_WIDTH + 2, 20); cout << "L Key - Right";
	gotoxy(WIN_WIDTH + 2, 21); cout << "K = shoot";

	gotoxy(WIN_WIDTH + 7, 8); cout << "Press any";
	gotoxy(WIN_WIDTH + 6, 9); cout << "key to start";
	_getch();
	gotoxy(WIN_WIDTH + 10, 8); cout << "                      ";

	while (1) {
		if (_kbhit()) {
			char ch = _getch();
			if (ch == 'a' || ch == 'A') {
				if (birdPos > 2)
					birdPos -= 2;
			}
			if (ch == 'd' || ch == 'D') {
				if (birdPos < WIN_WIDTH-7)
					birdPos += 2;
			}
			if (ch == 'j' || ch == 'J') {
				if (birdPos2 > 2)
					birdPos2 -= 2;
			}
			if (ch == 'l' || ch == 'L') {
				if (birdPos2 < WIN_WIDTH - 7)
					birdPos2 += 2;
			}
			if (ch == 32) {
				genBullet();
			}
			if (ch == 107 || ch == 75) {
				genBullet2();
			}	
			if (ch == 27) {
				break;
			}
		}

		drawBird();
		drawBird2();
		drawEnemy(0);
		drawEnemy(1);
		drawBullets();

		if (collision() == 1) {
			gameOver();
			return;
		}
		if (bulletHit() == 1) {
			score++;
			updateScore();
		}
		Sleep(200);
		eraseBird();
		eraseBird2();
		eraseEnemy(0);
		eraseEnemy(1);
		eraseBullets();
		moveBullet();

		if (enemyFlag[0] == 1)
			enemyY[0] += 1;
		
		if (enemyFlag[1] == 1)
			enemyY[1] += 1;

		if (enemyY[0] > SCREEN_HEIGHT - 5) {
			resetEnemy(0);
		}
		if (enemyY[1] > SCREEN_HEIGHT - 5) {
			resetEnemy(1);
		}
		if (enemyFlag[0] == 1)
			enemyY[0] += 1;

		if (enemyFlag[1] == 1)
			enemyY[1] += 1;

		if (enemyY[0] > SCREEN_HEIGHT - 5) {
			resetEnemy(0);
		}
		if (enemyY[1] > SCREEN_HEIGHT - 5) {
			resetEnemy(1);
		}
	}

}

int main() {
	setcursor(0, 0);
	srand((unsigned)time(NULL));

	do {
		system("cls");
		gotoxy(10, 5); cout << "-----------------------------";
		gotoxy(10, 6); cout << "|     SPACE SHOOTER         |";
		gotoxy(10, 7); cout << "-----------------------------";
		gotoxy(10, 9); cout << "1. Start Game";
		gotoxy(10, 10); cout << "2. Instructions";
		gotoxy(10, 11); cout << "3. Quit";
		gotoxy(10, 13); cout << "Select option: ";
		char op = _getch();

		if (op == '1') play();
		else if (op == '2') instructions();
		else if (op == '3') exit(0);


	}while (1);
	

	return 0;
}

[salem c]

> I found a space shooter program and decided to tweak it. I tried to make it multiplayer.
What you should have done first is tweak the obvious 'C' program into an actual C++ program with a class or three.

Copy/pasting a whole load of functions by just adding a '2' on the end of every symbol in sight is not how you do it.

class Player {
    Player(char left, char right, char shoot, directions direction);
};

So your initial refactor for one player would be

enum directions {
  UP,
  // to be added DOWN,
};
int main ( ) {
   Player one('A','D',' ',UP);
   Game game;
   game.addPlayer(one);
   game.play();
}

Two player could be as simple as this, if you'd got everything else right.

enum directions {
  UP,
  DOWN,
};
int main ( ) {
   Player one('A','D',' ',UP);
   Player two('J','L','L',DOWN);
   Game game;
   game.addPlayer(one);
   game.play();
}

[scourtheweb007]

Thank you I now have a better grasp at OOP and yeah lol you brought up a good point.