pls i want an answer today thank you

[mikedpj]

why this code is wrong and how i can fix it

please can you tell me why this is wrong

// 

#include <iostream>
#include <string>
#include <cstdlib>
using namespace std;

class Animal
    {
    private:
    string Animal ;
       int legs;
    string sound; 
    public:
      int getLegs()
       const {return legs;}
      string  getSound() 
      const {return sound;}
      string getClass()
      const {return Animal;}

    void printInfo() {
cout <<"This is a "<<getClass()<<". It has "<<legs<<" legs and sound: "<<sound<<"\n";
}
};
class Bird: public Animal
{
private:
int  legs = 2;
string sound = "chirp";

string Bird;

public:
string getClass()
      const {return Bird;}

};
class Dog: public Animal
{
private:
int legs = 4;
string sound = "bark";
string Dog ;

public:
string getClass()
      const {return Dog ;}

};
class Fish: public Animal
{
private:
int legs = 0;
string sound = "blop";
string fish;


public:
string getClass()
      const {return fish;}

};
 int main()
{
 Animal a;
 Dog d;
 Bird b;
 Fish f;
 cout<<a.getClass()<<endl;
 cout<<d.getClass()<<endl;
 cout<<b.getClass()<<endl;
 cout<<f.getClass()<<endl;
return 0;
}

[Ganado]

string getClass();
You never implement your getClass() member function in Animal.

Please edit your post and use code formatting

[code]

  // your code here

[/code]

[mikedpj]

where should i replace getClass function thanks for your respond

[malibor]

you forgot to edit your post

[mikedpj]

what do you mean

[mikedpj]

now i understand how this forum works i change the code and now is compiled properly but there is not any result thanks a lot

[malibor]

There is no result because your variables are not initialized with some values.

ex. class Dog has string Dog; member but it's value is nothing.
it should be string Dog = "Dog"; and so for all other variables, must be assigned some value so that getClass() returns a value instead of empty string.

[mikedpj]

like this

 //

#include <iostream>
#include <string>
#include <cstdlib>
using namespace std;

class Animal
    {
    private:
    string Animal ;
       int legs;
    string sound; 
    public:
      int getLegs()
       const {return legs;}
      string  getSound() 
      const {return sound;}
      string getClass()
      const {return Animal;}

    void printInfo() {
cout <<"This is a "<<getClass()<<". It has "<<legs<<" legs and sound: "<<sound<<"\n";
}
};
class Bird: public Animal
{
private:
int  legs = 2;
string sound = "chirp";

string Bird;

public:
string getClass()
      const {return Bird;}

};
class Dog: public Animal
{
private:
int legs = 4;
string sound = "bark";
string Dog="Dog" ;

public:
string getClass()
      const {return Dog ;}

};
class Fish: public Animal
{
private:
int legs = 0;
string sound = "blop";
string fish;


public:
string getClass()
      const {return fish;}

};
 int main()
{
 Animal a;
 Dog d;
 Bird b;
 Fish f;
 cout<<a.getClass()<<endl;
 cout<<d.getClass()<<endl;
 cout<<b.getClass()<<endl;
 cout<<f.getClass()<<endl;
return 0;
}

[malibor]

yes, but you updated only Dog, what about fish, bird and other animals?

you need to initialize all those variables if you want to see their values in console.

[Ganado]

Also, why do you have functions like "printInfo" if you never call them?
What are the actual requirements of the assignment? Does the assignment talk about 'polymorphism'? (It's possible that the answer to this is 'no', but just thought I'd ask)

[dhayden]

Animal is a generic class to represent an animal. For a bird or a cat or a Fish, you set the members accordingly:

#include <iostream>
#include <string>
#include <cstdlib>
using namespace std;

class Animal
{
private:
    string type;
    int legs;
    string sound;
public:
    // Constructor for an animal
    Animal(const string animalType, int numLegs, string theSound)
    {
	type = animalType;
	legs = numLegs;
	sound = theSound;
    }
    
    int getLegs() const
    {
	return legs;
    }
    string getSound() const
    {
	return sound;
    }
    string getClass() const
    {
	return type;
    }

    void printInfo()
    {
	cout << "This is a " << getClass() << ". It has " << legs << " legs and sound: "
	    << sound << "\n";
    }
};



class Bird:public Animal
{
public:
    Bird() : Animal("Bird", 2, "chirp")
    { }
};

int
main()
{
    Bird b;
    cout << b.getClass() << endl;
    b.printInfo();
    return 0;
}

Add to this to create the Fish and Dog classes.