Need help with a simple program!! rolls dice and adds the result

[ruffell]

Im doing an exercise and almost have it down bur I can't figure out how to get the total of the die rolls to add up. I am new to coding so I don't know anything too complex yet so the most basic way to do it is what I need help with. Thank you for helping!

This it the goal:

You are coding a simple game called Pig. Players take turns rolling
a die. The die determines how many points they get. You may get
points each turn your roll (turn points), you also have points for the
entire game (grand points). The first player with 100 grand points is
the winner. The rules are as follows:
Each turn, the active player faces a decision (roll or hold):
Roll the die. If it’s is a:
1: You lose your turn, no turn total points are added to your
grand total.
2-6: The number you rolled is added to your turn total.
Hold: Your turn total is added to your grand total. It’s now the
next player’s turn.

This is what I have so far:

#include <iostream>
#include <ctime>
#include <cstdlib>
#include <string>
using namespace std;

int PlayerOneTurn(int playerOneTotal);
int PlayerTwoTurn(int playerTwoTotal);

int main() 
{
  int playerOneScore;
  int playerTwoScore;
  int playerOneTotal;
  int playerTwoTotal;
  int turnScore;
  srand(time(NULL));

  do 
  {
    playerOneTotal=PlayerOneTurn(playerOneScore)+playerOneTotal;
    if(playerOneTotal >=100)
    {
      cout<<"Player 1 wins."<<endl;
    }
    playerTwoTotal=PlayerTwoTurn(playerTwoScore)+playerTwoTotal;
    if(playerTwoTotal>=100)
    {
      cout<<"Player 2 wins."<<endl;
    }

  }
  while (playerOneTotal<100 && playerTwoTotal<100);
  return 0;
}
  
int PlayerOneTurn(int playerOneTotal)
{
    int playerOneScore=0;
    int turnScore=0;
    int stayOrRoll;
    cout<<"Player 1 turn."<<endl;
    cout<<"Press 1 to roll or 2 to stay"<<endl;
    cin>>stayOrRoll;
    
    if (stayOrRoll==1)   
      {
        turnScore=rand()%6+1;
        if(turnScore==1)
        {
          cout<<"End of turn, next players turn."<<endl;
          playerOneScore=playerOneScore;
        }
        else
        {
          playerOneScore=playerOneScore + turnScore;
          cout<<"Player 1 score = "<<playerOneScore<<endl;
        }
      }
    return playerOneScore;
  }
int PlayerTwoTurn(int playerTwoTotal)
{
  int playerTwoScore=0;
  int turnScore=0;
  int stayOrRoll;
  cout<<"Player 2 turn."<<endl;
  cout<<"Press 1 to roll or 2 to stay"<<endl;
  cin>>stayOrRoll;
    
  if (stayOrRoll==1)   
  {
    turnScore=rand()%6+1;
    if(turnScore==1)
    {
      cout<<"End of turn, next players turn."<<endl;
      playerTwoScore=playerTwoScore;
    }
    else
    {
      playerTwoScore=playerTwoScore + turnScore;
      cout<<"Player 2 score = "<<playerTwoScore<<endl;
    }
  }
  return playerTwoScore;
}

I don't understand how to get the totals of the players to add up

[highwayman]

Quick suggestion: make PlayerTwoTurn and PlayerOneTurn just one function, they are doing the same things, yes? So you just pass in either player ones total or player twos instead of making over the same exact code. That’s what functions are for :).

[salem c]

You should initialise your variables.

  int playerOneScore = 0;
  int playerTwoScore = 0;
  int playerOneTotal = 0;
  int playerTwoTotal = 0;

> int PlayerOneTurn(int playerOneTotal);
> int PlayerTwoTurn(int playerTwoTotal);
Although you pass parameters to these functions, you don't actually use those parameters at all inside the functions.
If you decide you don't need the parameter, then it's best to just remove it and go with
int PlayerOneTurn(void);
int PlayerTwoTurn(void);


From just looking at the code, I think you should be able to do this in main.
playerOneTotal = PlayerOneTurn()+playerOneTotal;

Or more concisely
playerOneTotal += PlayerOneTurn();