Error No Acceptable Conversion

[stoneJax]

I am starting a new assignment on operator overloading. After performing a simple addition I get an error saying, " error C2679: binary '<<': no operator found which takes a right-hand operand of type 'cs_Fraction::Fraction' (or there is no acceptable conversion). Can someone please point out what the problem is?

The error is in the insertion operator with the cout statement in main.

 namespace cs_Fraction 
{
	class Fraction
	{
	private:
		int numerator;
		int denominator;

	public:
		Fraction(int inNumerator = 0, int indenominatoer = 1);
		friend Fraction operator + (const Fraction& left, const Fraction& right);
	};
}





#include <iostream>
#include "Fraction.h"
#include <cassert>
using namespace std;

namespace cs_Fraction {
Fraction operator + (const Fraction& left, const Fraction& right)
	{
		Fraction answer;
		answer.numerator = (left.numerator + right.numerator);
		answer.denominator = (left.denominator + right.denominator);

		return answer;
	}
}





#include <iostream>
#include "Fraction.h"
#include <fstream>
#include <cassert>
#include <string>
using namespace std;
using namespace cs_Fraction;

int main()
{
	Fraction f1;
	Fraction f2(1,2);
	Fraction f3(1,2);
	
	f1 = f2 + f3;
	cout << f1;

	system("pause");
	return 0;
}

[Peter87]

You get that error because you have not overloaded the << operator to work with your Fraction class.

[stoneJax]

Thank you for pointing that out. I tried creating a fix for that and now I am getting this error.
error C2248: 'Fraction::numerator': cannot access private member declared in class 'Fraction'

Updated code:

std::ostream& operator<<(std::ostream& out, const Fraction& right)
	{
			out << right.numerator << right.denominator;
			return out;
	}

[Peter87]

You either have to declare it as a friend (like you did for operator+) or provide another way to access the numerator and denominator from outside the class.

[stoneJax]

I should have posted my updated class too.

class Fraction
	{
	private:
		int numerator;
		int denominator;

	public:
		Fraction(int inNumerator = 0, int indenominatoer = 1);
		friend std::ostream& operator<<(std::ostream& out, const Fraction& right);
		friend Fraction operator + (const Fraction& left, const Fraction& right);

	};

[Peter87]

It seems to work fine.

[stoneJax]

You actually get it to work? Mine is still throwing that error.

[stoneJax]

Okay sorry, there is something going on with another with another function I started working on. I commented that out and now the cout << is working. Thank you.

[stoneJax]

Something is not making sense with a logic error though. I know the constructor initializes a fraction to 0/1 fine but when I send the argument (1,2) in a fraction object I cout it (no addition called) I get 12 and not not 1/2 like I'm expecting.

[Peter87]

Well, the way you have the defined the << operator the numerator and denominator will be outputted right next to each other without anything in between.

[stoneJax]

Ok I see what you mean. Thank you, I appreciate it.