char == char?

[Majeek]

std::vector <std::string> AskPlayer1(std::vector <std::string> &Vector, const char* Player1) {
	std::string Answer;

	while (true) {
		std::cout << "[Player] ";
		std::getline(std::cin, Answer);
		
		for (int i = 1; i < 10; i++) {
			char j = (char)i;
			if (Answer[0] == j) {
				Vector[i - 1] = Player1;
				std::cout << "Works";
				break;
			}
		}
	}
	return Vector;
}

Ex. If Answer[0] is '1' and j is '1' (I've debugged and this was an outcome) the if statement still doesn't become true. ?????

[salem c]

> char j = (char)i;
This doesn't turn 1 into '1'.

Try
char j = i + '0';

[jonnin]

or
for(int i = '0'; i <= '9'; i++) //or '1' .. unclear if you wanted zero?

[salem c]

More weirdness.

1. Vector[i = 1] = Player1;
Why the assignment (which you never use), why not Vector[1] = Player1;

2. break;
This only breaks out of your for loop, you're still stuck in your while loop.

3. return Vector;
You already passed it by reference anyway, so this is just a massive duplication of the data structure for no apparent good reason.

[Majeek]

Yes it's an unfinished function as I couldn't proceed clearly without that little loop to work, and the Vector[I =1] was a typo should be Vector[I- 1]

[jonnin]

you will want to watch assignment. Its one place where a lot of junk will compile and run while doing nothing like what you wanted.... like in this case. You get a warning, if you are lucky.