What's wrong with my code?

[avaldivia]

I'm trying to code a program that asks a student for class , year, unit, grade and then displays those on a table then asks again for the next class unless they quit the program. I can't seem to figure out how to fix the errors. Thanks in advance.

#include <iostream>
using std::cout;
using std::endl;
using std::cin;
#include <string>
using std::string;
#include <iomanip>
using std::setw;

struct Course
{
	string courseName;
	int year;
	double unit;
	char grade;
};

Course cinOneCourse(int seq);
void coutAllCourses(Course[] courses, int size);

int main()
{
	Course courses[100];

	courses[0] = cinOneCourse(1);

	int coursescount = 0;

	for (int i = 0; i < 100; i++)
	{
		string status;
		courses[i] = cinOneCourse(i + 1);
		coursescount++;

		cout << "Enter course #" << i + 2 << "[Q to exit]: " << endl;
		cin >> status;

		if (status == "Q" || status == "q")
		{
			break;
		}
	}

	coutAllCourses(courses);

	return 0;
}


Course cinOneCourse(int seq)
{
	Course newCourse;
	newCourse.courseName;
	newCourse.year;
	newCourse.unit;
	newCourse.grade;



	cout << "What year for ? [e.g., 2016]:" << endl;
	cin >> newCourse.year;

	cout << "How many units is ?" << endl;
	cin >> newCourse.unit;

	cout << "And what was your grade [? for in-progress or planned]: " << endl;
	cin >> newCourse.grade;


	return newCourse;
}

void coutAllCourses(Course[] courses, int size)
{
	cout << "Course" << setw(10) << "Year" << setw(10) << "Unit" << setw(10) << "Grade" << endl;
	cout << "------------" << setw(10) << "-------" << setw(10) << setw(10) << setw(10) << setw(10) << endl;
	
	for (int i = 0; i < size; i++)
	{
		cout << courses[i].courseName << setw(10) << courses[i].year << setw(10) << courses[i].unit << setw(10) << courses[i].grade << endl;
	}

}

[salem c]

#include <iostream>
using std::cout;
using std::endl;
using std::cin;
#include <string>
using std::string;
#include <iomanip>
using std::setw;

struct Course
{
	string courseName;
	int year;
	double unit;
	char grade;
};

Course cinOneCourse(int seq);
void coutAllCourses(Course courses[], int size);    //!! [] in the wrong place

int main()
{
	Course courses[100];

	// courses[0] = cinOneCourse(1); this is done inside the loop

	int coursescount = 0;

	for (int i = 0; i < 100; i++)
	{
		string status;
		courses[i] = cinOneCourse(i + 1);
		coursescount++;

		cout << "Enter course #" << i + 2 << "[Q to exit]: " << endl;
		cin >> status;

		if (status == "Q" || status == "q")
		{
			break;
		}
	}

	coutAllCourses(courses,coursescount);  //!! you promised to send a size

	return 0;
}


Course cinOneCourse(int seq)
{
	Course newCourse;
//!! 	bar.cpp:53:12: warning: statement has no effect [-Wunused-value]
//!! 	  newCourse.courseName;
//!! 	newCourse.courseName;
//!! 	newCourse.year;
//!! 	newCourse.unit;
//!! 	newCourse.grade;



	cout << "What year for ? [e.g., 2016]:" << endl;
	cin >> newCourse.year;

	cout << "How many units is ?" << endl;
	cin >> newCourse.unit;

	cout << "And what was your grade [? for in-progress or planned]: " << endl;
	cin >> newCourse.grade;


	return newCourse;
}

void coutAllCourses(Course courses[], int size)    //!! [] in the wrong place
{
	cout << "Course" << setw(10) << "Year" << setw(10) << "Unit" << setw(10) << "Grade" << endl;
	cout << "------------" << setw(10) << "-------" << setw(10) << setw(10) << setw(10) << setw(10) << endl;

	for (int i = 0; i < size; i++)
	{
		cout << courses[i].courseName << setw(10) << courses[i].year << setw(10) << courses[i].unit << setw(10) << courses[i].grade << endl;
	}

}

[avaldivia]

Thank you so much! It runs now and works. Except one thing. After I enter the first class and it's details, I get prompted to enter course #2, after I enter course #2 I get prompted to enter Course #1 then the program runs as it's supposed to.

#include <iostream>
using std::cout;
using std::endl;
using std::cin;
#include <string>
using std::string;
#include <iomanip>
using std::setw;

struct Course
{
	string courseName;
	int year;
	double unit;
	char grade;
};

Course cinOneCourse(int seq);
void coutAllCourses(Course courses[], int size);

int main()
{
	Course courses[100];

	int coursescount = 0;

	for (int i = 0; i < 100; i++)
	{
		string status;
		courses[i] = cinOneCourse(i + 1);
		coursescount++;
		
		cout << "Enter course #" << i + 2 << "[Q to exit]: " << endl;
		cin >> status;

		if (status == "Q" || status == "q")
		{
			break;
		}
	}


	coutAllCourses(courses, coursescount);

	return 0;
}


Course cinOneCourse(int seq)
{
	Course newCourse;

	cout << "Enter course #1 [Q to exit]: " << endl;
	cin >> newCourse.courseName;

	cout << "What year for " << newCourse.courseName <<  "? [e.g., 2016]:" << endl;
	cin >> newCourse.year;

	cout << "How many units is " << newCourse.courseName << "?" << endl;
	cin >> newCourse.unit;

	cout << "And what was your grade [? for in-progress or planned]: " << endl;
	cin >> newCourse.grade;


	return newCourse;
}

void coutAllCourses(Course courses[], int size)
{
	cout << "Course" << setw(10) << "Year" << setw(10) << "Unit" << setw(10) << "Grade" << endl;
	cout << "-------" << setw(10) << "-----" << setw(10) << "-----" << setw(10) << "------" << endl;
	
	for (int i = 0; i < size; i++)
	{
		cout << courses[i].courseName << setw(8) << courses[i].year << setw(8) << courses[i].unit << setw(8) << courses[i].grade << endl;
	}

}

[salem c]

> cout << "Enter course #1 [Q to exit]: " << endl;
Maybe change this to

cout << "Enter course #" << seq << endl;

There's no point asking about Q in cinOneCourse, because you don't handle Q in that function.

[avaldivia]

So I did that but now instead of asking for Course #1 it just duplicates the question each time except for the first time.