I got infinite loop

closed account (iN8poG1T)

Hello everyone, I try to read the text file which contains length and width for some area. I can read the file but i got infinite loop. may i know which part i did wrong?

my file contains

6 25

  #include <iostream>
#include <iomanip>
#include <string>
#include <fstream>
using namespace std;

class Shape
{
private :
    int x;
    int y;

public :
    Shape();
    Shape(int newx, int newy);
    int getX ();
    int getY();
    void setX(int newx);
    void setY (int newy);
    virtual void draw();


};

Shape :: Shape (){}
Shape :: Shape(int newx, int newy){}
int Shape :: getX(){return x;}
int Shape :: getY(){return y;}
void Shape :: setX(int newx){x= newx;}
void Shape :: setY(int newy){y= newy;}
void Shape :: draw(){
    {
        for(int i=0; i<x; i++)
        {
            for(int j=0; j<y; j++)
                cout << ".";
            cout<<endl;
        }
    }
}

int main()
{
   int height = 0;
    int length= 0;
    int count = 0;

    Shape temp(0,0);
    ifstream source("Shape.txt");

    if (source.is_open())
    {
       while (source >>height >> length)
        {
            temp.setX(height);
            temp.setY(length);
            Shape s;
            s.draw();
        }
    }
    else
      cout << "Source file failed to open.\n";
    source.close();

    return 0;
}

OUTPUT that i should get:

.........................
.........................
.........................
.........................
.........................
.........................

Last edited on

salem c (3700)

> Shape s;
> s.draw();
Perhaps you could try temp.draw() instead, which is what you just set up.

You should make your constructors actually initialise the object properly, so you don't see weird crap when you try to use a broken object.

dutch (2548)

It isn't an infinite loop, per se, but it could definitely be a very long loop (of arbitrary length). You aren't setting the x and y values of s. Presumably the while block should be

Shape s;
s.setX(height);
s.setY(length);
s.draw();

Last edited on

closed account (iN8poG1T)

Thank you so much!!! @salem c @ducth I just realized i didnt set the values of x and y

Topic archived. No new replies allowed.

C++

Forum

I got infinite loop