need help with fstream

[gmancow]

I written this entire code, however I can't figure out how this line is not working. fstream f("encoded.txt", f.out | f.app);. It tells me that f is undefined. Please help.

	case 'S':
	{

		cout << "Enter the encoding level <0, 1, 2, or 3>" << endl;
		cin >> level;
		cout << "Enter the file name" << endl;
		cin >> filename;
		fstream f("encoded.txt", f.out | f.app);
		switch (level) {

		case 1:

[Ganado]

Show a complete example that we can paste and attempt to compile.

Did you #include <fstream>?

[gmancow]

yes i did.

#include <iostream>
#include <fstream>
#include <string>
#include <sstream>
#include <ctype.h>
#include <algorithm>
#include <iterator>
#include <vector>
#include <cstring>
using namespace std;

// Define a constant for the number of lines to read
#define NUM_READ_LINES 11
char option;
int option2;
int decr = 3;
int incr = 5;
int inc2 = 4;
int inc3 = 3;
int temp;
int first_al, second_al;
string description, username, password, notes;
char thearray[NUM_READ_LINES][200];
string new_string = "";
char showOptions()
{

	cout << "\n" << endl;
	cout << "\t" << "AVAILABLE OPTIONS" << "\n" << endl;
	cout << "D - DISPLAY LINE DESCRIPTIONS\n";
	cout << "V - VIEW LINE DATA\n";
	cout << "E - EDIT LINE DATA\n";
	cout << "A - ADD LINE DATA\n";
	cout << "S - SAVE AND ENCODE FILE\n";
	cout << "X - EXIT PROGRAM\n";
	cin >> option;
}

int viewDetails(string opt)
{
	cout << "Enter line number you wish to " << opt << "\n";

	cin >> option2;

	std::ostringstream ss;
	ss << thearray[option2];
	//cout<<thearray[option2];
	int strpos = ss.str().find(";");

	std::string s = ss.str();
	std::string delimiter = ";";

	size_t pos = 0;
	int i = 1;
	std::string token;
	//here you display the token after getting a substring
	//after displaying the substring, it is erased from memory to form a new string wthout the first sustring

	while ((pos = s.find(delimiter)) != std::string::npos) {
		token = s.substr(0, pos);
		if (i == 1)
			std::cout << "Row Desc\t" << token << std::endl;
		if (i == 2)
			std::cout << "Username\t" << token << std::endl;
		if (i == 3)
			std::cout << "Password\t" << token << std::endl;
		if (i == 4)
			std::cout << "Notes\t" << token << std::endl;
		s.erase(0, pos + delimiter.length());
		i += 1;
	}

	return option2;

}

int main() {
	int level;


	// Array of line numbers each line being no more than 200 chars

	int counter = 0;
	std::string filename;
	cout << "Enter the name of the file\n";
	cin >> filename;

	// Open your file
	ifstream inFile("pwTest.txt", ifstream::in);

	// If we can read/write great
	if (inFile.good()) {

		// Read throuthe file and load into array
		while (!inFile.eof()) {
			inFile.getline(thearray[counter], 600);
			counter++;
		}



	}
	//here we convert the array elements to string and then display the description of each data
	for (int i = 0; i <= counter; i++) {
		std::ostringstream ss;
		ss << thearray[i];
		int strpos = ss.str().find(";");//this is to be used in splitting the array element
		if (i == 0)
			continue;
		cout << i << "\t" << ss.str().substr(0, strpos) << endl;//the array element is split and the description displayed

	}

	inFile.close();

	showOptions();
	//cin>>option;


	switch (toupper(option))
	{
	case 'D':
		for (int i = 0; i <= counter; i++) {
			std::ostringstream ss;
			ss << thearray[i];
			int strpos = ss.str().find(";");
			if (i == 0)
				continue;
			cout << i << "\t" << ss.str().substr(0, strpos) << endl;

		}
		showOptions();
		break;
	case 'V':
		viewDetails("view");
		break;
		//this is for editing the line data
	case 'E':
		viewDetails("edit");
		cout << "WARNING:  You cannot use semi-colons in these fields. Any semi-colons entered will be removed\n" << endl;
		cout << "Enter a line description:\n";
		cin >> description;
		description.append(";");
		cout << "Enter a username\n";
		cin >> username;
		description.append(username + ";");



		cout << "Enter a password\n";
		cin >> password;
		description.append(password + ";");


		cout << "Enter notes\n";
		cin >> notes;
		description.append(notes + ";");
		char cstr[sizeof(description) + 1];
		strcpy(cstr, description.c_str());
		cout << cstr;
		//thearray[option2]=cstr;
		cout << "Add security question";
		cin >> new_string;

		char choice;
		cout << "Are you sure you want to edit the data... Y/N";
		cin >> choice;


		showOptions();

		break;
	case 'X':
		cout << "Exiting system....\n";
		return 0;
		break;
		//savng and encoding file
	case 'S':
	{

		cout << "Enter the encoding level <0, 1, 2, or 3>" << endl;
		cin >> level;
		cout << "Enter the file name" << endl;
		cin >> filename;
		fstream f("encoded.txt", f.out | f.app);
		switch (level) {

		case 1:
		{
			f << "E1" << endl;
			std::ifstream file("pwTest.txt");

			if (file.is_open()) {
				std::string line;
				while (getline(file, line)) {
					cout << line.c_str();
					for (int i = 0; i < line.size(); i++) {
						if (int(line.c_str()[i]) != 59) {
							first_al = (int(line.c_str()[i])) - int(decr);
							//cout<<first_al<<endl;
							if (i % 2 != 0)
							{
								second_al = first_al + incr;
								f << second_al;
							}
							f << first_al;

						}
						else
						{
							f << ";";
							if (i == 4)
								f << endl;
						}


					}
				}
				file.close();
			}
			else
				cout << "Bad" << endl;
			return 0;
		}

		case 2:
		{
			f << "E2" << endl;
			std::ifstream file("pwTest.txt");

			if (file.is_open()) {
				std::string line;
				while (getline(file, line)) {
					cout << line.c_str();
					for (int i = 0; i < line.size(); i++) {
						if (int(line.c_str()[i]) != 59) {
							first_al = (int(line.c_str()[i])) - int(inc2);
							//cout<<first_al<<endl;
							if (i % 3 == 0)
							{
								second_al = first_al + inc3;
								f << second_al;
							}
							else
								f << first_al;
						}
						else
						{
							f << ";";
							if (i == 4)
								f << endl;
						}


					}
				}
				file.close();
			}
			return 0;
		}

		default:
			break;

		}
		return 0;

	}





	case 'A':
		fstream f("pwTest.txt", f.out | f.app);
		cout << "Enter a line description:\n";
		cin >> description;

		cout << "\n";
		cout << "Enter a username\n";
		cin >> username;

		cout << "\n";
		cout << "Enter a password\n";
		cin >> password;

		cout << "\n";
		cout << "Enter notes\n";
		cin >> notes;
		cout << "Are you sure you want to add the data...Y/n?\n";
		cin >> choice;
		switch (toupper(choice))
		{
		case 'Y':
			f << description << ";";
			f << username << ";";
			f << password << ";";
			f << notes << ";";
			break;

		default:
			break;

		}
		showOptions();
		break;




	}


	return 0;
}

[gmancow]

lines 185 and 275

[Ganado]

Your code compiles for me (but I didn't run it).

What is the exact error message you are getting?
It is a compiler error, link error, run-time error, or (if Visual Studio/Eclipse) an 'intellisense' error?

Your code does have some warnings, though. The first warning will probably crash your program at runtime

 In function 'char showOptions()':
37:1: warning: no return statement in function returning non-void [-Wreturn-type]
 In function 'int viewDetails(std::string)':
48:6: warning: unused variable 'strpos' [-Wunused-variable]
 In function 'int main()':
197:24: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
235:24: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
 

[gmancow]

I'm running visual studio, it says "error C2065: 'f': undeclared identifier".

[Ganado]

Okay I opened your code with visual studio. I see the issue. It was compiling for me with g++, but it might be an extension that allowed it to compile -- to treat non-static access to static members as legal.

Change
fstream f("encoded.txt", f.out | f.app);
to
fstream f("encoded.txt", fstream::out | fstream::app);

In hindsight, I should've realized this sooner...

[gmancow]

Thank you. Also the error in line 37 is not letting me run it. What should I be returning?

[Ganado]

You don't return anything from your function showOptions.

You're using global variables, which is bad practice. But the simplest "fix" would be to change the char showOptions to void showOptions.

Otherwise, you want to add return option;