Help with array output

[ohimaku]

Hello, I'm new to coding in c++ and I need to output the sound the mammal makes through void speak when I output the array at the end of code. So when the loop breaks at the end of pig it will go through the list listing the animal, the name of the animal, the weight of the animal, and the sound the animal makes.

#include "pch.h"
#include <iostream>
#include <stdlib.h>
#include <string>

using namespace std;

class Mammal {
protected:
	string Name;
	int Weight;

public:

	Mammal() {
		Name = "";
		Weight = 0;
		cout << "Invoking Mammal default constructor" << endl;
	}

	Mammal(string name, int weight) {
		Name = name;
		Weight = weight;
		cout << "Invoking Mammal parameterized constructor" << endl;
	}

	void speak() {
		cout << "Mammal sound" << endl;
	}

	string getName() const {
		return Name;
	}

	void setName(string Name) {
		this->Name = Name;
	}

	int getWeight() const {
		return Weight;
	}

	void setWeight(int Weight) {
		this->Weight = Weight;
	}

};

class Dog : public Mammal {
public:

	Dog(string Name, int Weight) : Mammal(Name, Weight) {
		cout << "Invoking Dog constructor" << endl;
	}

	~Dog() {
		cout << "Invoking Dog destructor" << endl;
	}

	void speak() {
		cout << "Woof Woof" << endl;
	}
};

class Cat : public Mammal {
public:

	Cat(string Name, int Weight) : Mammal(Name, Weight) {
		cout << "Invoking Cat constructor" << endl;
	}

	~Cat() {
		cout << "Invoking Cat destructor" << endl;
	}

	void speak() {
		cout << "Meow Meow" << endl;
	}
};

class Pig : public Mammal {
public:

	Pig(string Name, int Weight) : Mammal(Name, Weight) {
		cout << "Invoking Pig constructor" << endl;
	}

	~Pig() {
		cout << "Invoking Pig destructor" << endl;
	}

	void speak() {
		cout << "Oink Oink" << endl;
	}
};

class Horse : public Mammal {
public:

	Horse(string Name, int Weight) : Mammal(Name, Weight) {
		cout << "Invoking Horse constructor" << endl;
	}

	~Horse() {
		cout << "Invoking Horse destructor" << endl;
	}

	void speak() {
		cout << "I’m Mr. Ed" << endl;
	}
};



int main() {
	srand(100);
	string name;
	Mammal *m[4];
	int ch;
	int j = 0;
	while (j < 5) {
		int w = rand() % 150;
		cout << "Choose a Mammal\n1. Cat\n2. Dog\n3. Horse\n4. Pig\nEnter your choice by typing the number: ";
		cin >> ch;
		cout << "\nEnter a name: ";

		cin >> name;

		if (ch == 1) {
			Cat catto(name, w);
			m[j] = &catto;
			j++;
		}
		else if (ch == 2) {
			Dog doggo(name, w);
			m[j] = &doggo;
			j++;
		}
		else if (ch == 3) {
			Horse horsey(name, w);
			m[j] = &horsey;
			j++;
		}
		else if (ch == 4) {
			Pig piggo(name, w);
			m[j] = &piggo;
			j++;
			break;
		}
		else {
			cout << "invalid entry:" << endl;
		}

	}

	for (int i = 0; i < 5; i++) {
		m[i]->speak();                       
	}
	return 0;
}

[salem c]

Cat catto(name, w);
m[j] = &catto;

catto is a local variable which goes out of scope at the following }

You need more persistent objects.

Eg
m[j] = new Cat(name,w);

> while (j < 5)
You only have 4 choices, not 5.

You'll also need to do this to balance all the new calls you did earlier.

for (int i = 0; i < 5; i++) {
  delete m[i];
}