Tic Tac Toe Program not running

[johnb444]

So I need to code a tic tac toe game for my assignment. The program doesn't require any complex computer ai, I just seem to have a logical error that causes the program to end prematurely. Could someone please take a look? I've been trying to find the problem with no luck so far.

  #include<iostream>
#include<cstdlib>
#include<ctime>
using namespace std;

bool rowCrossedp(char game[3][3],char choice)
{
    int i;
    for(i=0;i<3;)
    {
        if(game[0][i]==choice)
        {
            i++;
        }
    }
    if(i==3)
    {
        return true;
    }
    for(i=0;i<3;)
    {
        if(game[1][i]==choice)
        {
            i++;
        }
    }
    if(i==3)
    {
        return true;
    }
    for(i=0;i<3;)
    {
        if(game[2][i]==choice)
        {
            i++;
        }
    }
    if(i==3)
    {
        return true;
    }
    return false;

}
bool rowCrossedc(char game[3][3],char computer)
{
    int i;
    for(i=0;i<3;)
    {
        if(game[0][i]==computer)
        {
            i++;
        }
    }
    if(i==3)
    {
        return true;
    }
    for(i=0;i<3;)
    {
        if(game[1][i]==computer)
        {
            i++;
        }
    }
    if(i==3)
    {
        return true;
    }
    for(i=0;i<3;)
    {
        if(game[2][i]==computer)
        {
            i++;
        }
    }
    if(i==3)
    {
        return true;
    }
    return false;
}
bool columnCrossedp(char game[3][3],char choice)
{
    int i;
    for(i=0;i<3;)
    {
        if(game[i][0]==choice)
        {
            i++;
        }
    }
    if(i==3)
    {
        return true;
    }
    for(i=0;i<3;)
    {
        if(game[i][1]==choice)
        {
            i++;
        }
    }
    if(i==3)
    {
        return true;
    }
    for(i=0;i<3;)
    {
        if(game[i][2]==choice)
        {
            i++;
        }
    }
    if(i==3)
    {
        return true;
    }
    return false;

}
bool columnCrossedc(char game[3][3],char computer)
{
    int i;
    for(i=0;i<3;)
    {
        if(game[i][0]==computer)
        {
            i++;
        }
    }
    if(i==3)
    {
        return true;
    }
    for(i=0;i<3;)
    {
        if(game[i][1]==computer)
        {
            i++;
        }
    }
    if(i==3)
    {
        return true;
    }
    for(i=0;i<3;)
    {
        if(game[i][2]==computer)
        {
            i++;
        }
    }
    if(i==3)
    {
        return true;
    }
    return false;

}
bool diagonalCrossedp(char game[3][3],char choice)
{
    int i,j;
    for(i=0;i<3;)
    {
        if(game[i][i]==choice)
        {
            i++;
        }
    }
    if(i==3)
    {
        return true;
    }
    for(i=0,j=2;i<3;)
    {
        if(game[i][j]==choice)
        {
            i++;
            j--;
        }
    }
    if(i==3)
    {
        return true;
    }
    return false;
}
bool diagonalCrossedc(char game[3][3],char computer)
{
    int i,j;
    for(i=0;i<3;)
    {
        if(game[i][i]==computer)
        {
            i++;
        }
    }
    if(i==3)
    {
        return true;
    }
    for(i=0,j=2;i<3;)
    {
        if(game[i][j]==computer)
        {
            i++;
            j--;
        }
    }
    if(i==3)
    {
        return true;
    }
    return false;
}
int main()
{
    srand(time(0));
    char game[3][3]={' ',' ',' ',' ',' ',' ',' ',' ',' '};
    char choice,computer;
    //Rows and Columns for player(p) computer(c)
    int rp, cp,rc,cc;
    
    cout<<"-Input character of choice ('x' or 'o'): ";
    cin>>choice;
    if(choice=='x')
    {
        computer='o';
    }
    else if(choice=='o')
    {
        computer='x';
    }
    else
    {
        goto no;
    }
    
        while (!(rowCrossedp(game,choice)&&rowCrossedc(game,computer)&&columnCrossedp(game,choice)&&columnCrossedc(game,computer)&&diagonalCrossedp(game,choice)&&diagonalCrossedc(game,computer)))
        {
            again1:
            cout<<"-Input row position: ";
            cin>>rp;
            cout<<"-Input column position: ";
            cin>>cp;
            
            if(game[rp-1][cp-1]!='x'||game[rp-1][cp-1]!='o')
            {
                game[rp-1][cp-1]=choice;
            }
            else
            {
                goto again1;
            }
            
            again2:
            rc=rand()%3;
            cc=rand()%3;
            
            if(game[rc][cc]!='x'||game[rc][cc]!='o')
            {
                game[rc][cc]=computer;
            }
            else
            {
                goto again2;
            }
            
            for(int i=0;i<3;i++)
            {
                for(int j=0;j<3;j++)
                {
                    cout<<game[i][j]<<"   |";
                }
                cout<<"\n__________________\n";
            }
            
        }
            
            
    no:
    cout<<"-Program end!!(error or game complete)\n";
    return 0;
}

[Ganado]

You should use a debugger to step through your code line-by-line. It's a great tool to use, and will save you hours of frustration in the future.

What environment do you set up? Windows with Visual Studio? Windows with MinGW and/or Code::Blocks? Linux with GCC/clang?

If you are working with any modern IDE, you should be able to go up to your menu bar and go to Debug --> Start Debugging. Put a breakpoint before your while statement on line 240.

[dhayden]

Your code to check for a winner is wrong. Consider this loop from rowCrossedp():

    for (i = 0; i < 3;) {
        if (game[0][i] == choice) {
            i++;
        }
    }
    if (i == 3) {
        return true;
    }

If game[0][0] != choice then i won't get incremented, which means the loop will never end.
I think you want this instead:

    for (i = 0; i < 3;) {
        if (game[0][i] != choice) {
            break;
        }
    }
    if (i == 3) {
        return true;
    }

The other 3 loops in rowCrossedp() can be combined into their own loop:

bool
rowCrossedp(char game[3][3], char choice)
{
    for (int row = 0; row < 3; ++row) {
        int col;
        for (col = 0; col < 3; ++col) {
            if (game[row][col] != choice) {
                break;
            }
        }
        if (col == 3) return true;
    }
    return false;
}

Why do you have rowCrossedc() that has the same code as rowCrossedp? You can just call rowCrossedp() with different values for choice.

I've found that tic-tac-toe is easier if you write a function called something like boardStatus():

// Examine the board and return it's current status:
'O' means that player O has won
'X' means that player X has won
'F' means the board is full
' ' means empty spaces remain< on the board.
char boardStatus(char game[3][3]);