y/n function

[Seyter]

My y/n function is not working. If you run it you would understand how it looks.

#include <iostream>
#include <cstdlib>
using namespace std;
int main()
{
    int a, b, c;
    double m1, m2, m3, total;
    cout<<"Enter viewers aged 2>5: "<<endl;
    cin>>a;
    cout<<"Enter viewers aged 7>17: "<<endl;
    cin>>b;
    cout<<"Enter adult viewers: "<<endl;
    cin>>c;
    cout<<endl;
    
    int viewer[]={a, b, c};
    cout<<"Numbers of viewers for each category: "<<endl;
    cout<<"-------------------------------------"<<endl;
    cout<<"Category 1: ";
    cout<<viewer[0]<<endl;
    cout<<"Category 2: ";
    cout<<viewer[1]<<endl;
    cout<<"Category 3: ";
    cout<<viewer[2]<<endl<<endl;
    
    m1 = viewer[0] * 2;
    m2 = viewer[1] * 3;
    m3 = viewer[2] * 5;
    total = m1 + m2 + m3;
    
    double money[]={m1, m2, m3};
    cout<<"Collection Obtained ($): "<<endl;
    cout<<"-------------------------------------"<<endl;
    cout<<"Category 1: ";
    cout<<money[0]<<endl;
    cout<<"Category 2: ";
    cout<<money[1]<<endl;
    cout<<"Category 3: ";
    cout<<money[2]<<endl;
    cout<<"*****Total= "<< total<<endl<<endl;
    
    char selection;
    cout<<"Calculate Again? (y/n)";
    cin>>selection;
    if (selection == 'y')
    if (selection == 'Y')
    {
    	 main();
    }
    if (selection == 'n')
    if (selection == 'N')
    {
	   exit(0);
    }
    
}

[Repeater]

 if (selection == 'y')
    if (selection == 'Y')
    {
    	 main();
    }
    if (selection == 'n')
    if (selection == 'N')
    {
	   exit(0);
    }

This is just plain all wrong. In many ways.


Here it is, less wrong:

if (selection == 'y' || selection == 'Y')
    {
    	 main();
    }

if (selection == 'n' || selection == 'N')
    {
	   exit(0);
    }

but this is still wrong.

You must NEVER EVER call main(). It's forbidden in C++. You are not allowed to call main().

You should not be calling exit(). You should be ending this program by returnfrom main().

[alonso12]

    if (selection == 'y')
    if (selection == 'Y')
try
   if (selection == 'Y' || selection == 'y')

and simillar for N and n.

[lastchance]

int main()
{
    while ( true )
    {
        int a, b, c;
        // etc.
        // etc.
       cin>>selection;
       if (selection == 'n' || selection == 'N' ) break;
    }
}