Boolean loop not working correctly

[zanzby0513]

I have written the program below and it runs successfully but when the menu choice is input, it just reruns the loop. How can I correct this?

 #include<iostream>
#include<iomanip>
using namespace std;

const char QUIT = '0';                  // constants for menu options
const char INPUT = '1';
const char PROCESS = '2';
const char OUTPUT = '3';

int main()
{
	char userSelection;                 // input for menu choice
	bool done;                          // flag for loop control



	// TODO: Begin loop here.  Test the loop control variable
	// Do NOT test the userSelection variable
	while (!done) {

		
		cout << endl
			<< setw(25) << "    Program Menu     " << endl
			<< setw(25) << "---------------------" << endl
			<< setw(25) << "1 ...... Input       " << endl
			<< setw(25) << "2 ...... Process     " << endl
			<< setw(25) << "3 ...... Output      " << endl
			<< setw(25) << "0 ...... Quit Program" << endl
			<< setw(25) << "---------------------" << endl;



		cout << setw(20) << "Enter option: ";
		cin >> userSelection;

        }
	if (userSelection == 0)
	{
		done = true;
		cout << "Invalid";

	}
	else if	(userSelection == 1)
	{
		cout << "Do INPUT stuff";
	}
	else if (userSelection == 2)
	{
		cout << "Do PROCESS stuff";
	}
	else if (userSelection == 3)
	{
		cout << "Do OUTPUT stuff";
	}
	else
	{
		cout << "Invalid choice, please try again.";
	}
		// TODO: End loop here.


		cout << "\nEnd Program - ";

} 

/* Sample Program Interaction and Output

Program Menu
---------------------
1 ...... Input
2 ...... Process
3 ...... Output
0 ...... Quit Program
---------------------
Enter option: 1

Do INPUT stuff

Program Menu
---------------------
1 ...... Input
2 ...... Process
3 ...... Output
0 ...... Quit Program
---------------------
Enter option: 2

Do PROCESS stuff

[keskiverto]

Please add code tags to your post. See http://www.cplusplus.com/articles/jEywvCM9/
Set systematic indentation. If you do, you should see your logical error.

[jonnin]

your while loop ends on line 36. this is one of the dangers of using book-brackets instead of having brackets on a line by themselves.

while(!done)
{
    if(cond)
     {
        code();
     }
}//aligns to while start bracket.


vs

while(!done){
    if(cond){
     code();
     } //what does this belong to?  Can't see it visually. 
}  //or this, where did it start? nothing in the same column

that said book-indent is a thing people use, but it has no merits apart from saving money when printing a physical book.

[zanzby0513]

Thanks, that helped. I also should have been using the declared constants in the if else statements instead of numbers. For example,

if (userSelection == INPUT)
{
     cout << "Do INPUT stuff";
}

[jonnin]

look up enum… you are re-creating the idea here.

[keskiverto]

char userSelection;
const char PROCESS = '2';

if (userSelection == INPUT) // OK, comparing char to char
if (userSelection == 2) // 2 != '2'. The 2 is ASCII code for one of the unprintable chars? 

Alternative to enums:

unsigned int userSelection;
std::string replies[] {"Invalid", "input", "process"};
std::cout << "Do " << replies[userSelection];

(That obviously requires sanity checks.)

One could put function pointers rather than strings into that array ...