Finding the average

[DdavidDLT]

For some reason I get 1.5 as a answer when it should be 2.5. I'm trying to find the number n for example 1234 number's sum average. 1 + 2 + 3 + 4 = 10 Average = 2.5

  #include <iostream>

using namespace std;

int main()

{
    int n, sk, kiek, sum;
    double vid;

    cout << "Iveskite skaiciu: \n";
    cin >> n;

    sum = 0;
    kiek = 0;

    while (n > 0) {

        n = n / 10;
        sk = n % 10;
        sum += sk;
        kiek++;




    }

    vid = (double) sum / kiek;
    cout << vid;


    return 0;
}

[Repeater]

Your code takes the number, and divides it by ten, and then you are looking at the last digit.

If you input 1234, when does your code add 4 to the sum? Never.

[DdavidDLT]

But sum = sum + sk than it adds. Doesn't it?

[DdavidDLT]

Never mind I found the problem. The % had to be first done and than / .

[Repeater]

Just for the fun of it, using some more advanced C++ features:

#include <iostream>
#include <string>
#include <algorithm>

using std::string;
using std::cin;

int main()
{
  std::string input;
  cin >> input;
  auto lambda = [count = 0](double a, int b) mutable { return a + (b-'0'-a)/++count; };
  std::cout << "\n Ave = " << std::accumulate (input.begin(), input.end(), 0.0, lambda);
}

[icy1]

well if input is suddenly a string rather than an int, one need not make things so complex

#include <iostream>
#include <string>

using namespace std;

int main()
{
    string s("1234");
    double sum=0, sz=s.size();
    for(auto& c : s)
        sum += c-'0';
    cout << sum/sz << endl;

    return 0;
}

2.5