How to decide when to end my while loop when it runs 1 too long

[jcthomas556]

My code is supposed to read a text doc and organize the string chunks, then run an error checker and print out everything in a specific way. Currently all works except for timestamp. Sometimes, in the .txt file, there will be no timestamp in a line (it will just be missing)


Previously, my variable would just remain the same as the prior value and it would cause errors so I reset my time stamp at the beginning of every string stream declaration for it.

This is what's causing the actual issue. Now that it's zero, it will pass the test again and my program ends up printing 1 additional "Error parsing" line.

I need some way to end the while loop earlier or maybe a way to clear a variable to a null value? I'm not sure.. any help would be appreciated.


Ps. This will not run on here, it needs a .txt file

  

************************************************************************/

#include <iostream>
#include <iomanip>
#include <string>
#include <sstream>
#include <fstream>
using namespace std;
#include <stdlib.h>
//#include <regex>



/**********************************************************************
* This is the struct skeleton
***********************************************************************/
struct AccessRecord
{
   string username;
   string filename;
   long timestamp;
};

/**********************************************************************
* 
***********************************************************************/
void getFileName(string &fileName)
{
   cout << "Enter the access record file: ";
   getline(cin, fileName);



}

void getTimeStamp(long &startTime, long &endTime)
{
   cout << "\nEnter the start time: ";
   cin >> startTime;
   cout << "Enter the end time: ";
   cin >> endTime;
}




bool isValidFilename(string fileName)
{

   if (fileName.find(".") == string::npos)
   {
      
      return false;
   }
   else
   {
     
      return true;
   }









}

bool isValidUsername(string username)
{
   //return true;
   return isalpha(username[0]);
}


bool isValidTimestamp(long timestamp )
{
   

  

   if (timestamp >= 1000000000 && timestamp <= 10000000000)
   {
         return true;
   }
   
   
   else 
   { 
      return false;
   }
}






/**********************************************************************
*
***********************************************************************/
void readFile(string &fileName, AccessRecord entry[])
{
   ifstream myFile(fileName.c_str());
   string testline;
   stringstream ss;
   int i = 0;
   string tempFileName;
   string tempUserName;
   long tempTimestamp;
   
   



   while (myFile.good())
   {
      
     
      getline(myFile, testline);

      ss.str(testline);
      
      
      ss >> tempFileName;

      
      if (isValidFilename(tempFileName))
      {
         
         ss >> tempUserName;


         if (isValidUsername(tempUserName))
         {
            tempTimestamp = 0;
            ss >> tempTimestamp;

            if (isValidTimestamp(tempTimestamp))
            {
               entry[i].filename = tempFileName;
               entry[i].username = tempUserName;
               entry[i].timestamp = tempTimestamp;

            }
            else
            {
               
               cout << "Error parsing line: " << testline << "\n";
               
             

            }
         }
         else
         {
            cout << "Error parsing line: " << testline << "\n";
            
         }
      }

      else
      {
         cout << "Error parsing line: " << testline << "\n";
         
      }

      
      i++;
      
      ss.clear();
     
    
   }
}




/**********************************************************************
*
***********************************************************************/
void printDisplay(AccessRecord entry[], long startTime, long endTime)
{
   cout << "\n      Timestamp                File                User\n";
   cout << "--------------- ------------------- -------------------";
   cout << endl;



   for (int p = 0; p < 15; p++)
   {
      if ((entry[p].timestamp < endTime) && (entry[p].timestamp >
         startTime))
      {
         cout << setw(15) << entry[p].timestamp << setw(20) <<
            entry[p].filename << setw(20) << entry[p].username << "\n";
      }
   }
}



/**********************************************************************
* 
***********************************************************************/
int main()
{



   string fileName = "null";


   long startTime;
   long endTime;



   AccessRecord entry[500];
   getFileName(fileName);

   readFile(fileName, entry);

   getTimeStamp(startTime, endTime);

   cout << "\nThe following records match your criteria:\n";



   printDisplay(entry, startTime, endTime);
   cout << "End of records";
   cout << endl;

   string wait;
   cin >> wait;
   return 0;
}


/*regex pattern(".*\\....");
return regex_match(fileName, pattern);*/
/*{
cout << fileName << " good";
return true;
}

cout << fileName << " bad ";

return false;*/

[tpb]

I don't see any advantage in using a weird indentation like 3. Is 4 really too much? It is FAR more common.

Anyway, are you saying that a missing time stamp IS an error, or ISN'T an error?

You aren't controlling your input loop properly. You should test the actual input function itself. I haven't tested this but I think your current code can be rewritten like this.

#include <iostream>
#include <iomanip>
#include <fstream>
#include <sstream>
#include <string>
//#include <regex>
#include <cstdlib>     // this is how you include C headers in C++
using namespace std;

struct AccessRecord {
    string username;
    string filename;
    long timestamp;
};

void getFileName(string &fileName) {
    cout << "Enter the access record file: ";
    getline(cin, fileName);
}

void getTimeStamp(long &startTime, long &endTime) {
    cout << "\nEnter the start time: ";
    cin >> startTime;
    cout << "Enter the end time: ";
    cin >> endTime;
}

bool isValidFilename(string fileName) {
    return fileName.find(".") != string::npos;
}

bool isValidUsername(string username) {
    return isalpha(username[0]);
}

bool isValidTimestamp(long timestamp) {
    return timestamp >= 1000000000 && timestamp <= 10000000000;
}

void readFile(string &fileName, AccessRecord entry[]) {
    ifstream myFile(fileName.c_str());
    string testline;
    for (int i = 0; getline(myFile, testline); i++) {
        istringstream ss(testline);
        string tempFileName;
        string tempUserName;
        long tempTimestamp = 0;
        ss >> tempFileName >> tempUserName >> tempTimestamp;
        if (isValidFilename(tempFileName) &&
             isValidUsername(tempUserName) &&
             isValidTimestamp(tempTimestamp)) {
             entry[i].filename = tempFileName;
             entry[i].username = tempUserName;
             entry[i].timestamp = tempTimestamp;
        }
        else
            cout << "Error parsing line: " << testline << '\n';
    }
}

void printDisplay(AccessRecord entry[], long startTime, long endTime) {
    cout << "\n      Timestamp                File                User\n";
    cout << "--------------- ------------------- -------------------\n";
    for (int p = 0; p < 15; p++)
        if (entry[p].timestamp < endTime && entry[p].timestamp > startTime)
            cout << setw(15) << entry[p].timestamp
                 << setw(20) << entry[p].filename
                 << setw(20) << entry[p].username << '\n';
}

int main() {
    AccessRecord entry[500];
    string fileName;
    long startTime;
    long endTime;

    getFileName(fileName);
    readFile(fileName, entry);
    getTimeStamp(startTime, endTime);
    cout << "\nThe following records match your criteria:\n";
    printDisplay(entry, startTime, endTime);
    cout << "End of records\n";

    return 0;
}

[jcthomas556]

Thanks for the help.. I fixed this problem a week or so ago and found that the notepad I was reading had an extra line in it causing the program to iterate 1 extra time.

Also, I prefer to indent 4 but my school has a testbed software that requires all indentation to be at 3.

Thanks for your help here. This still seems like it might be useful to someone so I will leave this here instead of deleting it.

[Ganado]

Also, I prefer to indent 4 but my school has a testbed software that requires all indentation to be at 3.

I am afraid of what that software's code looks like. Deeply afraid.

Thanks for your help here. This still seems like it might be useful to someone so I will leave this here instead of deleting it.

Thank you for being considerate! Good luck with your coding.