Pointer stepping loop points to number outside array.

[Jyggalag22]

The pointer loop that I made does not stay inside the loop when looking for the lowest number. The loop still points to the correct highest number though. The number I get for the lowest is usually something like 1.07374e+08.

 #include "stdafx.h"
#include "iostream"

using namespace std;


int main()
{
	const int MAXTEMPS = 10;
	float temp[MAXTEMPS];
	float sumt = 0.0;
	float avgt = 0.0;
	float * pCur = &temp[0];
	float * pHigh = &temp[0];
	float * pLow = &temp[0];

	cout << "Please enter the ten temperatures." << endl;

	for (int i = 0; i < MAXTEMPS; i++)
	{
		cin >> temp[i];
		sumt += temp[i];
	}

	pCur = temp;
	pLow = temp;
	pHigh = temp;

	for (int i = 0; i <= sizeof(temp); i++)
	{
		
		pCur++;

		if (*pCur > *pHigh)
		{
			pHigh = pCur;
		}

		if (*pCur < *pLow)
		{
			pLow = pCur;
		}


	}
	
	avgt = sumt / MAXTEMPS;
	cout << "The lowest temperature is: " << *pLow << endl;
	cout << "The highest temperature is: " << *pHigh << endl;
	cout << "The average temperature is: " << avgt << endl;

	system("pause");

    return 0;
}

[Peter87]

sizeof(temp) gives you the size of temp in bytes which is probably 40 (MAXTEMPS * sizeof(float)).

[Jyggalag22]

I changed sizeof(temp) to 10 instead and the same string of numbers came back up. I don't understand what is causing the problem.

for (int i = 0; i <= 10; i++)
	{
		pCur++;

		if (*pCur > *pHigh)
		{
			pHigh = pCur;
		}

		if (*pCur < *pLow)
		{
			pLow = pCur;
		}

	}

[jlb]

Look at this snippet:
for (int i = 0; i <= 10; i++)
Now remember that arrays start at zero and stop at size - 1, not size.

Also is there a reason you're using pointer notation instead of array notation?

[Jyggalag22]

The assignment calls for me to use pointers to find the highest and lowest values in the array.OH, I understand what you said about the array size and used that to fix the program. A million thanks.