Having trouble with getline

[Symphoneee]

I'm trying to program a really simple RPG with my friend from work based on this game we play there leveling him up. In my "main.cpp" I have the person enter their name and the std::getline handles it fine and outputs it correctly. However, when my program get's to the line where it asks for your inventory item, it doesn't give me an option to enter it and it just goes directly to the "calculating current stats" output. I don't understand what I'm doing wrong because I set it up the exact way as when the user enters their name earlier and that one works correctly. Any help would be greatly appreciated thanks!

#include <iostream>

#include "SIMON.HPP"

int main () {

    simon s1;    
    std::string name;
    double level;
    double hitpoints;
    double strength;
    double defense;
    double vitality;
    double abilitypoints;
    std::string inven;

    std::cout << "Enter your name:" << std::endl;
    std::getline(std::cin, name);
    std::cout << "Enter your level:" << std::endl;
    std::cin >> level;
    std::cout << "Enter your HP:" << std::endl;
    std::cin >> hitpoints;
    std::cout << "Enter your strength:" << std::endl;
    std::cin >> strength;
    std::cout << "Enter your defense:" << std::endl;
    std::cin >> defense;
    std::cout << "Enter your vitality:" << std::endl;
    std::cin >> vitality;
    std::cout << "Enter your AP:" << std::endl;
    std::cin >> abilitypoints;
    std::cout << "Enter your inventory item:" << std::endl;
    std::getline(std::cin, inven);

    std::cout << "Calculating Current Stats ..." << std::endl;
    std::cout << "---------------------------" << std::endl;
    std::cout << "-----------%%--------------" << std::endl;
    std::cout << "-----------%%--------------" << std::endl;
    std::cout << "---------------------------" << std::endl;

    s1.setName(name);
    s1.setLvl(level);
    s1.setHp(hitpoints);
    s1.setStr(strength);
    s1.setDef(defense);
    s1.setVit(vitality);
    s1.setAp(abilitypoints);
    s1.setinItem(inven, 5);
    s1.setWeapon("Olive Sword", 15);

    s1.displayStats();
    
    return 0;
};


#include "SIMON.HPP"


void simon::setName(std::string n) {
    name = n;    
}

void simon::setLvl(double l){
    lvl = l;
}

void simon::setHp(double h){
    hp = h;
}

void simon::setStr(double s){
    str = s;
}

void simon::setDef(double d){
    def = d;
}

void simon::setVit(double v){
    vit = v;
}

void simon::setAp(double a){
    ap = a;
}

void simon::setinItem(std::string s, int i){
    inItem = s;
    inb = i;
}

void simon::setWeapon(std::string w, int i){
    weapon = w;
    wnb = i;
}

void simon::displayStats(){


    std::cout << "                      " << std::endl;
    std::cout << "                      " << std::endl;
    std::cout << "-------||+~~+||-------" << std::endl;
    std::cout << name << "'s current stats:" << std::endl;
    std::cout << "---------****---------" << std::endl;
    std::cout << "     LVL: " << getLvl()  << std::endl;
    std::cout << "     HP:  " << getHp()  << std::endl;
    std::cout << "     STR: " << getStr() << std::endl;
    std::cout << "     DEF: " << getDef() << std::endl;
    std::cout << "     VIT: " << getVit() << std::endl;
    std::cout << "     AP:  " << getAp() << std::endl;
    std::cout << "     DMG: " << getDmg() << std::endl;
    std::cout << "     WPN: " << getWeapon() << std::endl;
    std::cout << "     INV: " << inItem << std::endl;
    std::cout << "---------****---------" << std::endl;
    std::cout << "     T.W.A.O.K.K.     " << std::endl;
    std::cout << "-------||+~~+||-------" << std::endl;
    std::cout << "                      " << std::endl;
    std::cout << "                      " << std::endl;
}


double simon::getLvl(){
    return lvl;
}

double simon::getHp(){
    return hp;
}

double simon::getStr(){
    return str;
}

double simon::getDef(){
    return (vit / 2) + def + inb;
}

double simon::getVit(){
    return vit;
}

double simon::getAp(){
    return ap;
}

double simon::getDmg(){
    return (str / 2) + wnb;
}

std::string simon::getinItem(){
    return inItem;
}

std::string simon::getWeapon(){
    return weapon;
}



#include <iostream>
#include <string>

class simon{

    public:
        
        void setName(std::string);
        void setLvl(double);
        void setHp(double);
        void setStr(double);
        void setDef(double);
        void setVit(double);
        void setAp(double);
        void setinItem(std::string, int);
        void setWeapon(std::string, int);
        void displayStats();

        double getLvl();
        double getHp();
        double getStr();
        double getDef();
        double getVit();
        double getAp();
        double getDmg();
        
        std::string getinItem();
        std::string getWeapon();



    private:

        double lvl;
        double hp;
        double str;
        double def;
        double vit;
        double ap;

        double dmg;
        double inb;
        double wnb;
        
        std::string name;
        std::string inItem;
        std::string weapon;

};

[Manga]

There does not seem to be much wrong with your code, so I think the program is running through to completion and closing.

To pause the program before it dies add this...

std::cin.ignore();
std::cin.get();

Put that just above your return 0;

[Symphoneee]

I tried what you said and it's still doing the same thing. Thank your for trying to help though!

[Manga]

ok sorry. Add this line...

std::cout << "Enter your inventory item:" << std::endl;
	std::cin.ignore(); //put this here.
	std::getline(std::cin, inven);

[Handy Andy]

Hello Symphoneee ,

A "std::getline()" followed by "std::cin >>" works just fine, but "std::cin >>" followed by a "std::getline()" does not work well because the "std::cin >>" will leave the new line character in the input buffer that the getline will extract and move on with out waiting for any input from the user. As Mange showed you this is a way to clear up the problem, but I would suggest std::cin.ignore(std::numeric_limits<std::streamsize>::max(), '\n'); // <--- Requires header file <limits>. as std::cin.ignore(); may only ignore one character and this may not be enough. Although in some cases it does work.

Any "std::getline()" that is preceded by a "std::cin >>" needs the use of "std::cin.ignore(...)" to clear the input buffer to work properly.

Hope that helps,

Andy

[Peter87]

In general, I think std::cin.ignore() belongs after std::cin>> rather than before std::getline().

The reason I think so is because it's not always easy to know if you need to use std::cin.ignore() before std::getline(). It depends on what input operation was used previously. If you use std::getline() at the beginning of a function, or after a loop that use std::cin>>, you can easily end up in situations where std::cin.ignore() is sometimes the right thing to do and sometimes it isn't but you have no way of telling.

If you say that any piece of code that reads input is responsible for reading the whole line it becomes much easier to write correct code. You no longer need to worry about doing anything special before using std::getline(), but it does mean you will have to use std::cin.ignore() after std::cin>>. If you use std::cin>> many times in a row it's probably a bit overkill to use std::cin.ignore() each time, but at least use it at the end of functions and in other situations where you are not sure what the next input operation is going to be.

[Manga]

Well in this case the use of std::cin.ignore() works fine because the last entry was a double value and not a string. So there is not a lot of junk needing to be cleared from the buffer.

@Peter87, you make a good point so for better readability your placement is correct.

@Symphoneee, we have decided this is how it should go...

std::cin >> abilitypoints;
std::cin.ignore(); //place code here.
std::cout << "Enter your inventory item:" << std::endl;

[Symphoneee]

Hey thanks a lot everyone! I think I understand it now. The explanations were great.