console snake game hit not being detected

[adam2016]

Hi guys I recently asked a similar question sorry about posting another thread I just have decided to start over because the thread was poorly explained and the title did not explain what the problem really was,

originally I thought the problem was random numbers not being generated but that does not seem to be the case,the problem seems to be that when my snake 'O' hits the food piece 'F' the hit does not get detected "HEY" never gets printed out

I tried using a debugger and setting break points but get a

Program received signal SIGTRAP, Trace/breakpoint trap. In ?? () () Cannot find bounds of current function Cannot find bounds of current function

error

thanks

 #include <iostream>
#include <stdlib.h>
#include <conio.h>
#include <time.h>

using namespace std;

enum edir{

   STOP = 0,
   UP,
   DOWN,
   RIGHT,
   LEFT
};

bool gameOver;
const int WIDTH = 20;
const int HEIGHT = 20;
int fruitX,fruitY,x,y;
edir dir;


void setUp(){

  gameOver = false;
  dir = STOP;
  x = WIDTH/2;
  y = HEIGHT/2;
  srand(time(NULL));
  fruitX = rand() % WIDTH-1;
  fruitY = rand() % HEIGHT-1;
  if(x == fruitX && y == fruitY){
    fruitX = (rand() % WIDTH-1)+1;
    fruitY = (rand() % HEIGHT-1)+1;
  }
}

void draw(){

     system("cls");

      for(int i = 0; i < WIDTH+1; i++){

        cout << "#";
      }
      cout << endl;

      for(int i = 0; i < HEIGHT; i++){

        for(int j = 0; j < WIDTH; j++){

            if(j == 0){

                cout << "#";
            }
            if(j == WIDTH-1){
                cout << "#";
            }
            if(i == x && j == y){

                cout << "O";
            }
            else if(i == fruitY && j == fruitX){

                cout << "F";
            }
            else{

                cout << " ";
            }
        }
        cout << endl;
      }
      for(int i = 0; i < WIDTH+1; i++){

        cout << "#";
      }


   }

void input(){

   while(_kbhit()){

    switch(_getch()){

case 'w':
    dir = UP;
    break;
case 'z':
    dir = DOWN;
    break;
case 'a':
    dir = LEFT;
    break;
case 's':
    dir = RIGHT;
    break;

    }
   }
}
void logic(){

 switch(dir){

 case UP:
     x--;
     break;
 case DOWN:
     x++;
     break;
 case LEFT:
    y--;
    break;
 case RIGHT:
    y++;
    break;
 }

 if(x > WIDTH || x < 0 || y > HEIGHT-2 || y < 0) // check for in bounds
    gameOver = true;
  if(x == fruitX && y == fruitY){
        fruitX = (rand() % WIDTH-1)+1;
        fruitY = (rand() % HEIGHT-1)+1;
        cout << "HEY";
    }

}

int main()
{
   setUp();
   while(!gameOver){

   draw();
   input();
   logic();
   }
   if(gameOver){
    cout << endl;
    cout << endl;
    cout << "GAME OVER!!!!!!!!!!!!" << endl;
   }
}

[Peter87]

In the draw() function i is the y-coordinate and j is the x-coordinate but when you compare them with the coordinates of the snake you have swapped them.

To avoid mistakes like this I would recommend naming the variables something more descriptive. i could be named y and j could be named x, and x and y could be named snakeX and snakeY which is more consistent with how you have named the coordinates for the fruit. If you don't want to rename the snake coordinates you could at least rename i and j as row and col (column).

[adam2016]

wow nice spot Peter :o

this bug has was "bugging" me for hours,it worked

honestly I thought it wouldn't have mattered if I mixed i and j up with x and y but it did

also very good point better naming could have solved this situation will rename the variables right away

thanks so much :)